glusterfs.git/extras, branch v3.12.14

Bash integration script should namespace variables

2018-08-17T18:29:26+00:00

In the original submitted script, it looks like there was effort
put into namespacing all global variables. However a few mistakes
remained.

GLUSTER_TOP_SUBOPTIONSx were defined, but TOP_SUBOPTIONSx were
referenced. This was likely an unrecognized defect in the
original code submission? These are now corrected to refer to
GLUSTER_TOP_SUBOPTIONSx.

FINAL_LIST, LIST, and TOP were leaked into all Bash shells and
used by the command completion functions. The most problematic
of these was TOP, which was declared with "-i" making it an
integer. This cause other code which used TOP to define a path
to fail like this:

    $ bash
    $ TOP=/abc
    bash: /abc: syntax error: operand expected (error token is "/abc")

These are now qualified as GLUSTER_FINAL_LIST, GLUSTER_LIST, and
GLUSTER_TOP to reduce impact on scripts that might choose to use
these extremely common variable names.

> Change-Id: Ic96eda8efd1f3238bbade6c6ddb69118e8d82158
> Signed-off-by: Mark Mielke 

(cherry picked from commit 89545e745e4075845c18078be67a31dea93a4e88)

Change-Id: Ic96eda8efd1f3238bbade6c6ddb69118e8d82158
Fixes: bz#1618838
Signed-off-by: Mark Mielke

gcron: create the lockfile if it is missing

2018-06-25T13:42:50+00:00

The lockfile for the job may not exist yet. If that is the case, it
should be created upon the first time it is accessed.

Change-Id: I4da2b3ecdb79cc63ed82cc7bfa026c8f08d4d043
Fixes: bz#1559829
Signed-off-by: Niels de Vos 
(cherry picked from commit 7005b1a336e483ec150c2f924a618dcfe197db0b)

gcron: catch OSError as well as IOError

2018-06-18T13:20:33+00:00

In case os.open() fails because the file does not exist, an OSError is
raised. To prevent the script to abort uncleanly, catch the OSError in
addition to the IOError.

Change-Id: I48e5b23e17d63639cc33db51b4229249a9887880
Fixes: bz#1559829
Signed-off-by: Niels de Vos 
(cherry picked from commit 26b52694feb04c98e6c9436bcd4e23e1687f0237)

geo-rep/scheduler: Fix crash

2018-06-11T10:18:52+00:00

Fix crash where session_name is referenced
before assignment. Well, this is a corner
case where the geo-rep session exists and
the status output doesn't show any rows.
This might happen when glusterd is down
or when the system is in inconsistent state
w.r.t glusterd.

Backport of:
> Patch: https://review.gluster.org/19991/
> Change-Id: Iec1557e01b35068041b4b3c1aacee2bfa0e05873
> Signed-off-by: Kotresh HR 
(cherry picked from commit 829f32c61c364323bab494cf9dab880aad4be463)

fixes: bz#1577871
Change-Id: Iec1557e01b35068041b4b3c1aacee2bfa0e05873
Signed-off-by: Kotresh HR

extras/hooks: Fix S10selinux-label-brick.sh hook script

2018-04-06T12:47:56+00:00

* script was failng due to syntax error
* shellcheck issues fixed
* improved performance: semanage & restorecon is being run on unique path

Upstream reference:
>Change-Id: I58b357d9fd37586004a2a518f7a5d1c5c9ddd7e3
>BUG: 1533342
>Signed-off-by: Milan Zink 

Change-Id: I58b357d9fd37586004a2a518f7a5d1c5c9ddd7e3
BUG: 1546627
Signed-off-by: Jiffin Tony Thottan

glusterd : introduce timer in mgmt_v3_lock

2017-11-06T12:16:15+00:00

Problem:
In a multinode environment, if two of the op-sm transactions
are initiated on one of the receiver nodes at the same time,
there might be a possibility that glusterd  may end up in
stale lock.

Solution:
During mgmt_v3_lock a registration is made to  gf_timer_call_after
which release the lock after certain period of time

>mainline patch : https://review.gluster.org/#/c/18437/

Change-Id: I16cc2e5186a2e8a5e35eca2468b031811e093843
BUG: 1503239
Signed-off-by: Gaurav Yadav

geo-rep/scheduler: Add validation for session existence

2017-10-12T18:44:40+00:00

Added validation to check for session existence
to give out proper error message out.

> Change-Id: I13c5f6ef29c1395cff092a14e1bd2c197a39f058
> BUG: 1499159
> Signed-off-by: Kotresh HR 
(cherry picked from commit 938addeb7ec634e431c2c8c0a768a2a9ed056c0d)


Change-Id: I13c5f6ef29c1395cff092a14e1bd2c197a39f058
BUG: 1499392
Signed-off-by: Kotresh HR

geo-rep/scheduler: Fix '--no-color' help msg

2017-10-06T06:31:04+00:00

> Change-Id: I0f51558083e0b11a6563b8a2ef62ec07fe2a9ca9
> BUG: 1495436
> Signed-off-by: Kotresh HR 
(cherry picked from commit 8855ebcfecde2a21e0a9ba725e9738708e03904a)

Change-Id: I0f51558083e0b11a6563b8a2ef62ec07fe2a9ca9
BUG: 1496238
Signed-off-by: Kotresh HR

gluster-block: strict-o-direct should be on

2017-08-29T13:36:24+00:00

       Backport of https://review.gluster.org/18120

tcmu-runner is not going to open block with O_SYNC anymore
so writes have a chance of getting cached in write-behind
when that happens, there is a chance that on failover some
data could be stuck in cache and be lost.

 >BUG: 1485962
 >Change-Id: If9835d914821dfc4ff432dc96775677a55d2918f
 >Signed-off-by: Pranith Kumar K 

BUG: 1486122
Change-Id: If9835d914821dfc4ff432dc96775677a55d2918f
Signed-off-by: Pranith Kumar K 
Reviewed-on: https://review.gluster.org/18126
Smoke: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
Tested-by: Krutika Dhananjay 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: Gluster should keep PID file in correct location

2017-08-12T13:38:30+00:00

Currently Gluster keeps process pid information of all the daemons
and brick processes in Gluster configuration file directory
(ie., /var/lib/glusterd/*).

These pid files should be seperate from configuration files.
Deletion of the configuration file directory might result into serious problems.
Also, /var/run/gluster is the default placeholder directory for pid files.

So, with this fix Gluster will keep all process pid information of all
processes in /var/run/gluster/* directory.

> BUG: 1258561
> Signed-off-by: Gaurav Kumar Garg 
> Signed-off-by: Saravanakumar Arumugam 
> Reviewed-on: https://review.gluster.org/13580
> Tested-by: MOHIT AGRAWAL 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> cherry pick from commit 220d406ad13d840e950eef001a2b36f87570058d

BUG: 1480459
Change-Id: Idb09e3fccb6a7355fbac1df31082637c8d7ab5b4
Signed-off-by: Mohit Agrawal 
Reviewed-on: https://review.gluster.org/18023
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System