glusterfs.git/extras, branch v3.7.15

build: systemd unit should not be marked executable

2016-08-12T21:44:52+00:00

systemd complains about the unit for GlusterD when it is executable:

  Configuration file /usr/lib/systemd/system/glusterd.service is marked executable. Please remove executable permission bits. Proceeding anyway.

The Makefile that installs the unit has some scripted commands. These
are not needed and standard "*dir" and "*DATA" postfixes for variables
can be used instead.

The EXTRA_DIST variable is needed for building the 'make dist' tarball
on systems where there is no systemd. The unit would be missing from the
tarball if it is not explicitly included.

Cherry picked from commit 9f22282795e20fd62b22847b92dffd0cde9cca1b:
> BUG: 1354489
> Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
> Reported-by: Sergej Pupykin 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14892
> Smoke: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
BUG: 1354476
Reported-by: Sergej Pupykin 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15116
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

extras: allign glusterd stop response in init script

2016-08-11T04:09:23+00:00

Backport of http://review.gluster.org/13839

An echo is missing stop() function which results in bad allignment of glusterd
stop output

Cherry-picked from commit dd02c5af9acb77cddc3bbe1ce9a51b7428b24446:
> Change-Id: I63ac9571457db90574fb1bfbf4f18ba09d3df1af
> BUG: 1321762
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/13839
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: I63ac9571457db90574fb1bfbf4f18ba09d3df1af
BUG: 1322667
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13863
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai 
CentOS-regression: Gluster Build System

scripts: bash-isms in scripts

2016-06-24T16:42:31+00:00

Backport of http://review.gluster.org/14401/

Change-Id: I05f8718fb73c16dbb37c1f7460bb7b55cc0ffe97
BUG: 1223947
Reported-by: Patrick Matthäi 
Signed-off-by: Kotresh HR 
Original-Author: Kaleb S KEITHLEY 
(cherry picked from commit 2df72780e473709128a4f5d7f274a9063b288252)
Reviewed-on: http://review.gluster.org/14774
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

common-ha: race/timing issue setting up cluster

2016-06-24T16:42:14+00:00

The ganesha_grace resource agent can start before the ganesha_mon
resource agent, with the result that the crm_attribute that
ganesha_grace expects to find has not been created yet.

This is never (never? Or just so rarely that it has never actually
been seen during development) seen with four nodes, but with just
two nodes it's very repeatable.

Note that when long (FQDN) names are used it is not unexpected to
see Failed Actions in the output of `pcs status`, e.g.:

* nfs-grace_monitor_5000 on node1.fully.qualified.domain.name.com
'unknown error' (1): call=20, status=complete, exitreason='none',
last-rc-change='Wed Jun  1 12:32:32 2016', queued=0ms, exec=0ms
* nfs-grace_monitor_5000 on node2.fully.qualified.domain.name.com
'unknown error' (1): call=18, status=complete, exitreason='none',
last-rc-change='Wed Jun  1 12:32:42 2016', queued=0ms, exec=0ms

and as long as all the ganesha_grace_clone and cluster_ip-1
resource agents are in Started state then this is okay.

backport master:
> http://review.gluster.org/14607
> BUG: 1341768
release-3.8
> http://review.gluster.org/14609
> BUG: 1341770

Change-Id: I726c9946ceb1ca92872b321612eb0f4c3cc039d8
BUG: 1341772
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14610
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE

2016-05-24T09:36:44+00:00

A little known, rarely used feature of pacemaker called
"notification" is used to follow the status of the ganesha.nfsds
in the cluster. This is done with location constraints and other
Black Magick.

When a nfsd dies, the ganesha-active attribute is cleared, the
associated floating IP (VIP) fails over to another node, and the
ganesha_grace notify method is invoked with post-stop on all the
nodes where the ganesha.nfsd is still running. The notify methods
send dbus msgs to put their nfsds into NFS-GRACE, and the nfsds
perform their grace processing, e.g. taking over locks from the
failed nfsd.

N.B. Fail-back was originally not planned to be a feature for
glusterfs-3.7, but we sorta got it for free.

For fail-back, the opposite occurs. The ganesha-active attribute
is recreated, the floating IP fails back, and the notify method is
invoked with pre-start on all the nodes where the surviving
ganesha.nfsds continue to run. The notify methods send dbus msgs
again to put their nsfds into NFS-GRACE again, and the nfsds clean
up their locks.

backport mainline
> http://review.gluster.org/14506
> BUG: 1338967
release-3.8
> http://review.gluster.org/14507
> BUG: 1338968

Change-Id: I3fc64afa20ae3a928143d69aa533a8df68dd680e
BUG: 1338969
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14508
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k

common-ha: wait for cluster to elect DC before accessing CIB

2016-05-24T09:36:31+00:00

access attempts, e.g. `pcs property set stonith-enabled=false`
will fail (or time out) if attempted "too early", i.e. before
the cluster has elected its DC.

see https://bugzilla.redhat.com/show_bug.cgi?id=1336947#c3 and
https://bugzilla.redhat.com/show_bug.cgi?id=1320740

Change-Id: Ifc0aa7ce652c1da339b9eb8fe17e40e8a09b1096
BUG: 1336948
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14428
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: jiffin tony Thottan

common-ha: log flooded with Could not map name=xxxx to a UUID

2016-05-23T09:36:50+00:00

When the cluster is configured with long (FQDN) cluster members
the log is flooded with "Could not map name=$shortname to a UUID"
notices, and setting/getting the attribute is failing

Change-Id: I954d8cef7115659cc9c8b23dae75a5a247dc5db7
BUG: 1337653
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14437
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: stonith-enabled option set error in new pacemaker

2016-05-19T10:17:30+00:00

Setting the option too early results in an error in newer versions
of pacemaker. Postpone setting the option in order for it to succeed.

N.B. We do not use a fencing agent. Yes, we know this is "not supported."

Backport of mainline
>> http://review.gluster.org/#/c/14404/
>> BUG: 1336945
>> Change-Id: I86953fdd67e6736294dbd2d0795611837188bd9d
release-3.8
> http://review.gluster.org/#/c/14405/
> BUG: 1336947
> Change-Id: I402992bcb90a92dbcc915a75fe03b25221625e98

Change-Id: I6f75a4d67618b41a4b30c341f5b7e9ea976b553e
BUG: 1336948
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14406
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

ganesha/scripts : Fixing refresh config in ganesha-ha.sh

2016-05-16T18:05:52+00:00

The change http://review.gluster.org/#/c/14225/ cause a regression
for refresh config funtion in ganesha-ha.sh due to a invalid usage
of awk arguement.

This is backport of below mainstream bug -
        http://review.gluster.org/14325

Change-Id: Id5adfb12f99b29bdb3531773cd34bd67cfff8768
BUG: 1336331
Signed-off-by: Soumya Koduri 
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14325
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14353
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: floating IP (VIP) doesn't fail over when ganesha.nfsd dies

2016-05-16T01:25:48+00:00

restore mistaken removal of 'attrd_updater delete grace-active' to
trigger fail-over

original was:
   attrd_updater -D -n grace-active
   sleep
   attrd_updater -D -n ganesha-active

mistake was:
   sleep
   attrd_updater -D -n grace-active

Change-Id: Iabd06ed042671e1fa744c4db469cd33ff40d6c4e
BUG: 1336199
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14345
Smoke: Gluster Build System 
Reviewed-by: soumya k 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System