glusterfs.git/extras, branch v3.8.4

common-ha: ganesha_mon: line 137: [: too many arguments ]" messages

2016-09-07T11:49:17+00:00

ensure that there are always valid, non-null arguments to /bin/test

Here there be dragons. Very racy, but if the races lose, they lose
in a way that's consistent with what we're testing for anyway, namely
that the ganesha.nfsd process is gone.

Change-Id: I88b770dd874ffa8576711f8009f27122a4fb0130
BUG: 1372728
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15409
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

build: systemd unit should not be marked executable

2016-08-09T14:59:41+00:00

systemd complains about the unit for GlusterD when it is executable:

  Configuration file /usr/lib/systemd/system/glusterd.service is marked executable. Please remove executable permission bits. Proceeding anyway.

The Makefile that installs the unit has some scripted commands. These
are not needed and standard "*dir" and "*DATA" postfixes for variables
can be used instead.

The EXTRA_DIST variable is needed for building the 'make dist' tarball
on systems where there is no systemd. The unit would be missing from the
tarball if it is not explicitly included.

Cherry picked from commit 9f22282795e20fd62b22847b92dffd0cde9cca1b:
> BUG: 1354489
> Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
> Reported-by: Sergej Pupykin 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14892
> Smoke: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
BUG: 1354499
Reported-by: Sergej Pupykin 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15115
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

ganesha/scripts : delete nfs-ganesha folder from shared storage during clean up

2016-07-04T13:28:24+00:00

A directory named "nfs-ganesha" will be created inside shared storage when
'gluster nfs-ganesha enable' is executed. Similarly this directory should be
removed when 'gluster nfs-ganesha disable' is executed.

Upstream reference:
>Change-Id: Icc09b32010de07c9809e22aafbb2fd08a5c8252f
>BUG: 1349398
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14782
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit ec3ea75513347deb95960f49d58fc19478a7ad17)

Change-Id: Icc09b32010de07c9809e22aafbb2fd08a5c8252f
BUG: 1351154
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14833
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

common-ha: race/timing issue setting up cluster

2016-06-08T12:14:56+00:00

The ganesha_grace resource agent can start before the ganesha_mon
resource agent, with the result that the crm_attribute that
ganesha_grace expects to find has not been created yet.

This is never (never? Or just so rarely that it has never actually
been seen during development) seen with four nodes, but with just
two nodes it's very repeatable.

Note that when long (FQDN) names are used it is not unexpected to
see Failed Actions in the output of `pcs status`, e.g.:

* nfs-grace_monitor_5000 on node1.fully.qualified.domain.name.com
'unknown error' (1): call=20, status=complete, exitreason='none',
last-rc-change='Wed Jun  1 12:32:32 2016', queued=0ms, exec=0ms
* nfs-grace_monitor_5000 on node2.fully.qualified.domain.name.com
'unknown error' (1): call=18, status=complete, exitreason='none',
last-rc-change='Wed Jun  1 12:32:42 2016', queued=0ms, exec=0ms

and as long as all the ganesha_grace_clone and cluster_ip-1
resource agents are in Started state then this is okay.

backport master:
> http://review.gluster.org/14607
> BUG: 1341768

Change-Id: I726c9946ceb1ca92872b321612eb0f4c3cc039d8
BUG: 1341770
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14609
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

ganesha: fix the shebang for the copy-export script

2016-05-30T14:36:27+00:00

Backport of:
> BUG: 1340488
> Change-Id: I22061a8b8bc0ea43da91e5b2904a27a674a004be
> Reviewed-on: http://review.gluster.org/14548
> Reported-by: Patrick Matthäi 
> Signed-off-by: Niels de Vos 

BUG: 1340487
Change-Id: I22061a8b8bc0ea43da91e5b2904a27a674a004be
Reported-by: Patrick Matthäi 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14550
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

common-ha: wait for cluster to elect DC before accessing CIB

2016-05-24T09:36:16+00:00

access attempts, e.g. `pcs property set stonith-enabled=false`
will fail (or time out) if attempted "too early", i.e. before
the cluster has elected its DC.

see https://bugzilla.redhat.com/show_bug.cgi?id=1336947#c3 and
https://bugzilla.redhat.com/show_bug.cgi?id=1320740

Change-Id: Ifc0aa7ce652c1da339b9eb8fe17e40e8a09b1096
BUG: 1336947
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14427
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: jiffin tony Thottan

common-ha: post fail-back, ganesha.nfsds are not put into NFS-GRACE

2016-05-24T08:41:30+00:00

A little known, rarely used feature of pacemaker called
"notification" is used to follow the status of the ganesha.nfsds
in the cluster. This is done with location constraints and other
Black Magick.

When a nfsd dies, the ganesha-active attribute is cleared, the
associated floating IP (VIP) fails over to another node, and the
ganesha_grace notify method is invoked with post-stop on all the
nodes where the ganesha.nfsd is still running. The notify methods
send dbus msgs to put their nfsds into NFS-GRACE, and the nfsds
perform their grace processing, e.g. taking over locks from the
failed nfsd.

N.B. Fail-back was originally not planned to be a feature for
glusterfs-3.7, but we sorta got it for free.

For fail-back, the opposite occurs. The ganesha-active attribute
is recreated, the floating IP fails back, and the notify method is
invoked with pre-start on all the nodes where the surviving
ganesha.nfsds continue to run. The notify methods send dbus msgs
again to put their nsfds into NFS-GRACE again, and the nfsds clean
up their locks.

Backport mainline
> http://review.gluster.org/14506
> BUG 1338967

Change-Id: I3fc64afa20ae3a928143d69aa533a8df68dd680e
BUG: 1338968
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14507
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Niels de Vos

common-ha: log flooded with Could not map name=xxxx to a UUID

2016-05-23T09:36:33+00:00

When the cluster is configured with long (FQDN) cluster members
the log is flooded with "Could not map name=$shortname to a UUID"
notices, and setting/getting the attribute is failing

Backport of:
> Change-Id: I954d8cef7115659cc9c8b23dae75a5a247dc5db7
> Reviewed-on: http://review.gluster.org/14435
> BUG: 1337650
> Signed-off-by: Kaleb S KEITHLEY 

Change-Id: I954d8cef7115659cc9c8b23dae75a5a247dc5db7
BUG: 1337652
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14436
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

ganesha/scripts : Fixing refresh config in ganesha-ha.sh

2016-05-19T16:50:14+00:00

The change http://review.gluster.org/#/c/14225/ cause a regression
for refresh config funtion in ganesha-ha.sh due to a invalid usage
of awk arguement.

>Change-Id: Id5adfb12f99b29bdb3531773cd34bd67cfff8768
>BUG: 1333319
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14325
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>(cherry picked from commit 8299ad374b2b93f123b29e0d411930733a372a04)

Change-Id: Id5adfb12f99b29bdb3531773cd34bd67cfff8768
BUG: 1336798
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14420
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: stonith-enabled option set error in new pacemaker

2016-05-19T10:17:19+00:00

Setting the option too early results in an error in newer versions
of pacemaker. Postpone setting the option in order for it to succeed.

N.B. We do not use a fencing agent. Yes, we know this is "not supported."

Backport from mainline
> http://review.gluster.org/#/c/14404/
> BUG: 1336945
> Change-Id: I86953fdd67e6736294dbd2d0795611837188bd9d

Change-Id: I402992bcb90a92dbcc915a75fe03b25221625e98
BUG: 1336947
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14405
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System