glusterfs.git/geo-replication/src/gsyncd.c, branch v7.0rc2

libglusterfs: Move devel headers under glusterfs directory

2018-12-05T21:47:04+00:00

libglusterfs devel package headers are referenced in code using
include semantics for a program, this while it works can be better
especially when dealing with out of tree xlator builds or in
general out of tree devel package usage.

Towards this, the following changes are done,
- moved all devel headers under a glusterfs directory
- Included these headers using system header notation <> in all
code outside of libglusterfs
- Included these headers using own program notation "" within
libglusterfs

This change although big, is just moving around the headers and
making it correct when including these headers from other sources.

This helps us correctly include libglusterfs includes without
namespace conflicts.

Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b
Updates: bz#1193929
Signed-off-by: ShyamsundarR

geo-rep : fix high sev coverity isuue

2018-10-25T05:34:27+00:00

This patch fixes CID: 1382374: USE_AFTER_FREE.

Change-Id: If408f52ee291312fb83095126ebd6bb79ae95e26
updates: bz#789278
Signed-off-by: Sunny Kumar

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu

geo-rep: Remove unused working directory check in gsyncd

2018-01-29T07:33:00+00:00

To append the default config file path, gsyncd calls gluster
command to get the workdir path and constructs config file path.
This is not required now since the Config management in Geo-replication
is changed with patch 18257(Issue #73)

BUG: 1539545
Change-Id: Ia7eb39e36ed59ece4de65ea7ec71a0f615e338bb
Signed-off-by: Aravinda VK

geo-rep: address potential leak of memory

2016-07-19T11:25:35+00:00

fix memory leak reported by clang analyzer:
gsyncd.c:411:17: warning: Potential leak of 
                 memory pointed to by 'argv'
                 in main()


Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
BUG: 1332419
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14151
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Kotresh HR

core: use syscall wrappers instead of direct syscalls - miscellaneous

2015-10-28T20:38:42+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: I1f47820534c890a00b452fa61f7438eb2b3f667c
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12276
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

geo-rep: Fix gsyncd failing to start on slave

2015-08-06T05:40:22+00:00

This is a regression introduced by 2ca6441.
The memory is freed while the caller expects
it be not. The patch fixes the same.

Change-Id: I76d95eef15b3f7af365b392f2426c8b0388254fc
BUG: 1222898
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11751
Reviewed-by: Saravanakumar Arumugam 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Venky Shankar

geo-replication: fix memory leak in gsyncd

2015-07-14T13:12:06+00:00

1. leak in str2argv() function:

char *strdup(const char *s);
The strdup() function returns a pointer to a new string which is a
duplicate of the  string  s. Memory for the new string is obtained
with malloc(3), and can be freed with free(3).

so when using strdup, user has to take care of freeing the memory
allocated by strdup library function.

2. leak in main() function:

str2argv() function calls calloc and allocates memory pointed to argv,
after return from str2argv() memory pointed to argv has to be cleaned
in main().

This patch is to fix 2 memory leaks mentioned above.

Change-Id: I6bf26101e0460a7324ac7bdb69905839688d4987
BUG: 1222898
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/10831
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Kotresh HR 
Reviewed-by: Venky Shankar

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

geo-rep: Fixing the typo errors

2015-02-03T18:03:41+00:00

Change-Id: Iacc67e4ba9ac45e0858f3befe84ffb8fccf7e1c3
BUG: 1075417
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/9502
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal