glusterfs.git/geo-replication, branch v4.0dev

geo-rep: Handle possible entry failures gracefully

2017-07-21T10:38:12+00:00

Updates: #246

Change-Id: If0ce83fe8dd3068bfb671f398b2e82ac831288d0
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17577
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Fix changelog encoding to encode only space and newline

2017-07-21T04:44:30+00:00

libgfchangelog was encoding path using spec rfc3986, but encoding only
required for SPACE and NEWLINE chars since the NEWLINE char is used as
record separator and SPACE as field separator in the parsed changelogs
output.

Changed the encoding function to encode only SPACE and NEWLINE.

BUG: 1451724
Change-Id: I1936efad31788a9e636f912c832ed7d7efea4fe2
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17787
Reviewed-by: Prashanth Pai 
Reviewed-by: Kotresh HR 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

geo-rep: Fix entry failure because parent dir doesn't exist

2017-07-05T15:44:23+00:00

In a distributed volume on master, it can so happen that
the RMDIR followed by MKDIR is recorded in changelog on
a particular subvolume with same gfid and pargfid/bname
but not on all subvolumes as below.

E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 RMDIR \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2
E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 MKDIR 16877 0 0 \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2

While processing this changelog, geo-rep thinks RMDIR is
successful and does recursive rmdir on slave. But in the
master the directory still exists. This could lead to
data discrepancy between master and slave.

Cause:
RMDIR-MKDIR pair gets recorded so in changelog when the
directory removal is successful on cached subvolume and
failed in one of hashed subvol for some reason
(may be down). In this case, the directory is re-created
on cached subvol which gets recorded as MKDIR again in
changelog.

Solution:
So while processing RMDIR geo-replication should stat on
master with gfid and should not delete it if it's present.

Change-Id: If5da1d6462eb4d9ebe2e88b3a70cc454411a133e
BUG: 1467718
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17695
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Structured log support

2017-06-20T06:00:47+00:00

Changed all log messages to structured log format

Change-Id: Idae25f8b4ad0bbae38f4362cbda7bbf51ce7607b
Updates: #240
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17551
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR

geo-rep: Added metrics related to Sync Time

2017-06-15T07:20:56+00:00

In Geo-rep, Sync jobs can be configured using, `config sync-jobs 3`. This
patch adds following information related to the sync job(Rsync/Tarssh)

Example output:

    [2017-06-13 09:09:32.532181] I [master(/bricks/b1):1713:syncjob] Syncer: \
        Sync Time Taken (Job:2 Files:5484 ReturnCode:0): 4.8774 secs

Change-Id: Ifceb96d4b8d14e00fd1290c0aeff60d64b4d7f37
BUG: 1455179
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17531
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR

geo-rep: Fix string format issue caused due to #17489

2017-06-13T06:09:05+00:00

With Patch #17489, values from Geo-rep config always represented
as Unicode string, which is not compatible with rest of the code.

Changed the format with this patch to fix the issue.

BUG: 1459620
Change-Id: I935fca0d24f02e90757f688f92ef73fad9f9b8e1
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17503
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Kotresh HR

geo-rep: Fix ConfigInterface Template issue

2017-06-08T11:16:20+00:00

ConfigParser uses string Template to substitute the dynamic values
for config. For some of the configurations, Geo-rep worker will
not restart. Due to this conf object may have non string values.

If val is not string in Template(val), then it fails with
"TypeError: expected string or buffer"

BUG: 1459620
Change-Id: I25b8bbc1df42f6f29e9563a55b3e27a228321c44
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17489
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR

geo-rep: Fix meta data sync on symlink

2017-06-04T08:27:19+00:00

chmod doesn't support 'no dereference' option.
It always deference the symlink. But 'chown'
does support metadata changes on symlink itself,
which was not taken care while syncing. This
patch fixes the same.

Change-Id: Ic9985f4e39d15b5a9deb379841bcfb2c263d3e6c
BUG: 1455559
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17389
NetBSD-regression: NetBSD Build System 
Reviewed-by: Aravinda VK 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System

geo-rep: Log time taken to sync entries

2017-05-29T06:44:08+00:00

With each batch having the type and count of
each fop helps to know the kind of I/O.
Having time taken to sync entry ops, metadata
ops and data ops gives us good understanding
into where the more time is being spent.
This patch does the same.

Change-Id: Ib52a0f9ede905f28a468b68bdf6d23e4b043f3e3
BUG: 1455179
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17066
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Aravinda VK

geo-rep: Make changelog-batch-size configurable

2017-05-24T06:12:02+00:00

Changelog batch size is set to 727040 bytes which
is the size of all the changelogs in a single batch.
It's based on few tests which approximately processes
5K entries. But it might vary on different machines.
Making it configurable gives more control on the
frequency of stime updates. This patch does the same.

Change-Id: I9a5ebb3d92c1327dded0e0a712c43a5a9046c1b0
BUG: 1454872
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17376
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK