glusterfs.git/glusterfsd/src/glusterfsd-mgmt.c, branch v3.3.1qa2

glusterfsd: rpcsvc actors must return success after an attempt to submit reply

2012-08-30T10:26:44+00:00

rpcsvc attempts to send "error reply" using the req object. If actor has
already performed rpcsvc_submit_generic, then req is destroyed. So if the
actor returned -1 (RPCSVC_ACTOR_ERROR) on failing to submit reply, then req
would be 'free'd' twice and will result in a crash eventually.

Change-Id: I5eae19570202bbe5e154e9cb03390cfeb9b5f223
BUG: 851410
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3863
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/3875
Reviewed-by: Vijay Bellur

rpc: Reduce frame-timeout for glusterd connections

2012-08-17T08:13:01+00:00

Reduce frame-timeout for glusterd connections from 30mins to 10 mins. 30mins is
too long when compared to cli timeout of 2mins. Changing to 10mins reduces the
disparity between cli and glusterd.

Also, fix glusterfs_submit_reply() so that a reply is sent even if serialize
failed.

BUG: 843003
Change-Id: Ie8d5ec16fbbb54318a5935a47065e66fd3338b87
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3812
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

calls to dict_allocate_and_serialize() are not 64-bit clean

2012-08-03T10:54:50+00:00

All calls to dict_allocate_and_serialize() pass the address of a 32-bit
type, but must cast it to the 64-bit pointer type (size_t *).

This happens to work on LE machines, but even if it's apparently benign,
it's still a bug. On BE machines it is not benign.

GF_PROTOCOL_DICT_SERIALIZE() hacks around it by creating a size_t temp
var, but that's, well, a hack, IMO when you consider that all the callers
are actually passing &; the param should just be a u_int * and
eliminate the buggy casts and the temp var in the macro.

Nobody apparently uses the Fedora/EPEL PPC RPMs, but they might. People
are trying to build gluster.org bits on SPARC and tripping over this.

Change-Id: I92ea139f9e3e91ddbbb32a51b96fa582a9515626
Signed-off-by: Kaleb S. KEITHLEY 
BUG: 838928
Reviewed-on: http://review.gluster.com/3643
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Remove dht dependency on glusterfsd-mgmt

2012-08-02T03:57:30+00:00

glusterfs_ctx->notify can be used by any xlator to talk to
glusterfsd-mgmt.
Note- This is for any rpc communication initiated by the xlator,
      and not from glusterd.

Change-Id: Ic0e4af106fe1e98d797ca621facda8839b87598a
BUG: 835757
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3610
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

glusterfs/rebalance: Register cbk for glusterfs_rebalance_event_notify

2012-05-23T09:02:10+00:00

In case of n/w failures, cbk needs to be passed to
mgmt_submit_request

BUG: 822086
Change-Id: Ie443902b94a09e11a2696b89de44a11fb477ca3e
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3403
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

glusterfsd: Change a free() to GF_FREE()

2012-04-27T03:24:23+00:00

Change-Id: I19bad33864b67e7ac79d8c5e642efa19dbc5bd80
BUG: 816163
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3231
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

rebalance: handshake_event_notify to make fsd talk to glusterd

2012-04-25T11:05:35+00:00

Event_notify can be used by others to communicate with glusterd.
A cbk event is also added for future use.

req has a op, and dict.
rsp has op_ret, op_errno, and dict.

With this, rebalance process can update the status before
exiting.

Signed-off-by: shishir gowda 
Change-Id: If5c0ec00514eb3a109a790b2ea273317611e4562
BUG: 807126
Reviewed-on: http://review.gluster.com/3013
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

glusterd,glusterfsd : Perform proper cleanup of connections and socket files

2012-04-24T01:54:55+00:00

Perform proper disconnections and cleanup in glusterd on stopping nfs-server and
self-heal daemon processes to prevent glusterd from opening unneded unix domain
socket connections.

glusterfsd processes will cleanup the socket files properly in
cleanup_and_exit() to prevent junk socket files.

Also, fix rpcsvc_program_unregister() to preform the unregistering properly.

Change-Id: I1c7302c1166cf43feba1c7a813c3dc10169dc53a
BUG: 810089
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3168
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

glusterfsd: print entire path of functions whenever serializing a reply fails

2012-04-24T01:50:22+00:00

Change-Id: I72c0296e16c90ec09ecb1678b4c78e8ffd834580
BUG: 814926
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/3205
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Fix compiler warnings and typos from Debian build.

2012-04-10T21:37:29+00:00

Mostly to do with "-Werror=format-security" being buggy, but while we're
here we might as well fix some typos and such.  Credit goes to Patrick
Matthäi  for pointing these out.

Change-Id: Ia32d1111d7c10b1f213df85d86b17a1326248ffd
BUG: 811387
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.com/3117
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati