glusterfs.git/glusterfsd, branch v3.13.0

glusterfsd: Dereferencing the null pointer

2017-10-20T02:31:47+00:00

Problem: When control reaches to out, one of (iobref, iobuf, frame) can
be null.for iobref, iobuf iobref_unref() and iobuf_unref() functions
are called respectively, which are using GF_VALIDATE_OR_GOTO(), so
there won't be null pointer dereference. But for frame without null
checking STACK_DESTROY(frame->root) is called causing null pointer
dereference.

Fix: adding a line for null checking, the function
STACK_DESTROY(frame->root) is called only when frame is not null.

Change-Id: I3a6684c11fb7b694b81d6ad4fec3bced5562ad88
BUG: 1503394
Signed-off-by: Sanju Rakonde

gfproxyd: Let glusterd manage gfproxy daemon

2017-10-18T14:15:05+00:00

Updates: #242
BUG: 1428063
Change-Id: Iaaf2edf99b2ecc75f6d30762c752a6d445c1c826
Signed-off-by: Poornima G

glusterfsd: Coverity Issue "MISSING_BREAK" in parse_opts

2017-09-29T15:10:03+00:00

Issue:Event unterminated_case: 	The case for value
"ARGP_LOCALTIME_LOGGING_KEY" is not terminated by a
'break' statement.

Solution: A break statement is added in the fallthrough case.

Change-Id: Ie44d1a291afaa0e9fb9ef2aa45368b9401a8bb82
BUG: 789278
Signed-off-by: Subha sree Mohankumar

stack.h:PW.INCLUDE_RECURSION

2017-09-29T07:46:53+00:00

The headerfile globals.h is recursively adding itself.
( globals.h -> xlator.h -> stack.h -> globals.h).
We are finding the source files which are including the header
file globals.h and removing the inclusion line.

I used git grep -l stack.h | xargs git grep globals.h --
to find out the files and removed the header file from all files
except libglusterfs/src/xlator.h and libglusterfs/src/Makefile.am

When I try to remove header file from libglusterfs/src/xlator.h
I'm getting some errors. In libglusterfs/src/Makefile.am it is
required for building RPMs.

Change-Id: I537218c09ade6d7ea51717768b26563a247daf60
BUG: 789278
Signed-off-by: Sanju Rakonde

Glusterfsd: Unreachable statements

2017-09-26T13:06:33+00:00

Issue: Event unreachable at line number 1111 in glusterfsd/src/glusterfsd.c

There was a statement in outer if block after the break statement.
Ideally the break statement should be inside the inner if block so
that the statement will not become unreachable. I put the break
inside the inner if block.

Change-Id: Id4917305333e1638f35b3f2fb59ac42e62a12d02
BUG: 789278
Signed-off-by: Sanju Rakonde

mount/fuse: Make event-history feature configurable

2017-09-24T06:22:07+00:00

... and disable it by default.

This is because having it disabled seems to improve performance.
This could be due to the lock contention by the different epoll threads
on the circular buff lock in the fop cbks just before writing their response
to /dev/fuse.

Just to provide some data - wrt ovirt-gluster hyperconverged
environment, I saw an increase in IOPs by 12K with event-history
disabled for randrom read workload.

Usage:
mount -t glusterfs -o event-history=on $HOSTNAME:$VOLNAME $MOUNTPOINT
OR
glusterfs --event-history=on --volfile-server=$HOSTNAME --volfile-id=$VOLNAME $MOUNTPOINT

Change-Id: Ia533788d309c78688a315dc8cd04d30fad9e9485
BUG: 1467614
Signed-off-by: Krutika Dhananjay

Command to identify client process

2017-09-06T11:52:40+00:00

command: gluster volume status  client-list

output:
Client connections for volume v1
Name                                                       count
-----                                                     ------
fuse                                                           2
tierd                                                          1

total clients for volume v1 : 3
-----------------------------------------------------------------

Client connections for volume v2
Name                                                       count
-----                                                     ------
tierd                                                          1
fuse.gsync                                                     1

total clients for volume v2 : 2
-----------------------------------------------------------------

Updates: #178
Change-Id: I0ff2579d6adf57cc0d3bd0161a2ec6ac6c4747c0
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/18095
Smoke: Gluster Build System 
Tested-by: hari gowtham 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

Infra to indentify process

2017-08-16T15:38:49+00:00

Problem: currently we can't identify which process is running and
how many instances of it are available.

Fix: name the process when its spawned and send it to the server
and save it in the client_t

The processes that abide by this change from this patch are:
1) fuse mount,
2) rebalance,
3) selfheal,
4) tier,
5) quota,
6) snapshot,
7) brick.
8) gfapi (by default. gfapi. if processname is found)

Note: fuse gets a process name as native-fuse-client by default.
If the user gives a name for the fuse and spawns it, it will be of
this type --process-name native-fuse-client..
This can be made use by the process like aux mount done by quota,
geo-rep, etc by adding another option in the aux mount " -o
process-name=gsync_mount"

Updates: #178
Signed-off-by: hari gowtham 
Change-Id: Ie4d02257216839338043737691753bab9a974d5e
Reviewed-on: https://review.gluster.org/17957
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Aravinda VK 
Reviewed-by: Niels de Vos

glusterfsd: allow subdir mount

2017-08-04T05:26:42+00:00

Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set  auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates #175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi 
Reviewed-on: https://review.gluster.org/17141
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System

logging: localtime logging, cmdline, volume set option

2017-08-03T12:03:18+00:00

Despite the fact that appliances generally use UTC, some
users really want log entries in localtime.

fixes gluster/glusterfs#272

feature page: https://review.gluster.org/17807

Change-Id: I5fbf2c3eedd9eb128fb3f851dd67b2f4081c8bba
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/16911
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Samikshan Bairagya 
Reviewed-by: Shyamsundar Ranganathan