glusterfs.git/libglusterfs/src/client_t.c, branch v3.7.9

protocol/server: Fix memory corruption during client-table-expand.

2016-01-20T07:01:26+00:00

gf_client_clienttable_expand frees up old entries after expanding. So,
cliententry should be reassigned to a free slot in new array of
cliententries. Earlier it used to point to a slot in oldentries
resulting in a use-after-free bug.

Thanks to Pranith for the assistance provided.

Change-Id: Iabe40c7df475471a7df7bccb302aef496ded3f1c
BUG: 1299314
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/13249
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

mem-pool,stack,store,syncop,timer/libglusterfs : Porting to a new logging framework

2015-07-14T09:35:13+00:00

        Backport of http://review.gluster.org/10827

Cherry picked from 2b9b3ef3b646989bbc0412dca187b3f5fcad3283
>Change-Id: Idd3dcaf7eeea5207b3a5210676ce3df64153197f
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10827
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: NetBSD Build System 

Change-Id: Idd3dcaf7eeea5207b3a5210676ce3df64153197f
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11478
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

protocol/server: Add null check to gf_client_put

2015-07-09T10:10:49+00:00

Change-Id: I8bab3cd7387f89743e15e7569f0bc83a7df3c754
BUG: 1240603
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/11550
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11562
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

call-stub,circ-buff,client_t,compat,dict/libglusterfs : Porting to a new logging framework

2015-07-09T07:11:04+00:00

        Backport of http://review.gluster.org/10828

Cherry picked from a1e32fbcfbfaf6e4c63e140b3b90a80dc748a269
>Change-Id: Ie7d180e0ab2fed1270d66504606d1b2522884020
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10828
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 

Change-Id: Ie7d180e0ab2fed1270d66504606d1b2522884020
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11406
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

core: use reference counting for mem_acct structures

2015-05-09T21:27:36+00:00

When freeing memory, our memory-accounting code expects to be able to
dereference from the (previously) allocated block to its owning
translator.  However, as we have already found once in option
validation and twice in logging, that translator might itself have
been freed and the dereference attempt causes on of our daemons to
crash with SIGSEGV.  This patch attempts to fix that as follows:

 * We no longer embed a struct mem_acct directly in a struct xlator,
   but instead allocate it separately.

 * Allocated memory blocks now contain a pointer to the mem_acct
   instead of the xlator.

 * The mem_acct structure contains a reference count, manipulated in
   both the normal and translator allocate/free code using atomic
   increments and decrements.

 * Because it's now a separate structure, we can defer freeing the
   mem_acct until its reference count reaches zero (either way).

 * Some unit tests were disabled, because they embedded their own
   copies of the implementation for what they were supposedly testing.
   Life's too short to spend time fixing tests that seem designed to
   impede progress by requiring a certain implementation as well as
   behavior.

Change-Id: Id929b11387927136f78626901729296b6c0d0fd7
BUG: 1219026
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10417
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Niels de Vos 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/10723
Tested-by: NetBSD Build System

client_t: fix for potential NULL pointer dereference

2014-12-12T09:19:05+00:00

In case an error occurs, 'client' is free'd. The log message just before
exiting the function should therefore not use the structure anymore.

BUG: 789278
Change-Id: I0848328b29585057cd037a5972c4e5f06a7f978b
CID: 1226165
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9262
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

libglusterfs: wrong function definition of synclock_destory().

2014-08-06T08:29:28+00:00

synclock_destory() has been prototyped in syncop.h,
how-ever synclock_destroy() is the actual function used in syncop.c.
Correcting this function definition along with few typos.


Change-Id: I35a818190c1d37c303279ca7a820f01895751bd9
BUG: 1075417
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/8266
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: soumya k 
Reviewed-by: Poornima G 
Reviewed-by: Vijay Bellur

client_t: Fix memory leaks

2014-07-09T12:09:26+00:00

- Assign frame->root->client so that gf_client_unref happens
  in server_connection_cleanup_flush_cbk
- Avoid taking extra ref in gf_client_get

TODO:
The whole reason why there are two types of refs
bind, ref-count is to avoid lock inside lock which
is not the case now. I will be sending one more patch
which will accomplish that as well as changing the
tablearray to list

Change-Id: Ic9971cf248c5ee2cdbfdef8e9ff6d54e3ec60ced
BUG: 1116672
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8247
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

libglusterfs/client_t: cliententries are never expanded

2014-07-02T17:07:41+00:00

clienttable->cliententries are never expanded once all the available
entries have been used.

Also removed a couple chatty log messages.

Change-Id: Iff2d92fe1116cc6c6b72ff3d173aee26e69780ed
BUG: 1113745
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8184
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: MacOSX Porting fixes

2014-04-24T21:41:48+00:00

git@forge.gluster.org:~schafdog/glusterfs-core/osx-glusterfs

Working functionality on MacOSX

 - GlusterD (management daemon)
 - GlusterCLI (management cli)
 - GlusterFS FUSE (using OSXFUSE)
 - GlusterNFS (without NLM - issues with rpc.statd)

Change-Id: I20193d3f8904388e47344e523b3787dbeab044ac
BUG: 1089172
Signed-off-by: Harshavardhana 
Signed-off-by: Dennis Schafroth 
Tested-by: Harshavardhana 
Tested-by: Dennis Schafroth 
Reviewed-on: http://review.gluster.org/7503
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati