glusterfs.git/libglusterfs/src/common-utils.c, branch v3.7.9

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

cli : 'gluster volume help' output sorted alphabetically

2015-11-02T10:03:28+00:00

'gluster volume help' output is not sorted alphabetically.
This makes little harder for the user to search or get to know of
few gluster volume commands usage just from gluster cli.

    Backport of http://review.gluster.org/11663

Cherry picked from 323e71617fee5020324540776d0d4469577f0afe
Change-Id: I855da2e4748a5c2ff3be319c50fa9548d676ee8a
BUG: 1276208
Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/11663
>Tested-by: Gluster Build System 
>Reviewed-by: Manikandan Selvaganesh 
>Reviewed-by: Anand Nekkunti 
Reviewed-on: http://review.gluster.org/12452
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Anand Nekkunti

libglusterfs removing strerror in logging

2015-07-28T13:47:06+00:00

        Backport of  http://review.gluster.org/11464

Cherry picked from 9384a824041aeef0e58644cc9fe71dc7fa13eb35
>Change-Id: I8a0f40834da1151ddaef6139af3782bc076df57e
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq Liyazudeen 
>Reviewed-on: http://review.gluster.org/11464
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System 
>Reviewed-by: Pranith Kumar Karampuri 

Change-Id: I8a0f40834da1151ddaef6139af3782bc076df57e
BUG: 1217722
Signed-off-by: Mohamed Ashiq Liyazudeen 
Reviewed-on: http://review.gluster.org/11727
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

rpc: fix binding brick issue while bind-insecure is enabled

2015-07-27T04:31:56+00:00

This patch is backport of http://review.gluster.org/#/c/11512/

> problem:

> When bind-insecure is turned on (which is the default now), it may happen
> that brick is not able to bind to port assigned by Glusterd for example
> 49192-49195...
>
> It seems to occur because the rpc_clnt connections are binding to ports in
> the same range. so brick fails to bind to a port which is already used by
> someone else
>
> solution:
>
> fix for now is to  make rpc_clnt to get port numbers from 65535 in a
> descending
> order, as a result port clash is minimized
>
> other fixes:
>
> previously rdma binds to port >= 1024 if it cannot find a free port < 1024,
> even when bind insecure was turned off(ref to commit '0e3fd04e'), this patch
> add's a check for bind-insecure in gf_rdma_client_bind function
>
> This patch also re-enable bind-insecure and allow insecure by default
> which was reverted (ref: commit cef1720) previously

> Change-Id: Ia1cfa93c5454e2ae0ff57813689b75de282ebd07
> BUG: 1238661
> Signed-off-by: Prasanna Kumar Kalever 

Change-Id: Iea55f9b2a57b5e24d3df2c5fafae12fe99e9dee0
BUG: 1246481
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/11758
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

features/bitrot: cleanup, v2

2015-07-09T10:13:25+00:00

    Backport of http://review.gluster.org/11148

This patch uses "cleanup, v1" infrastrcuture to cleanup scrubber
(data structures, threads, timers, etc..) on brick disconnection.
Signer is not cleaned up yet: probably would be done as part of
another patch.

Change-Id: I78a92b8a7f02b2f39078aa9a5a6b101fc499fd70
BUG: 1226666
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11540
Reviewed-by: Raghavendra Bhat 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

stack: use list_head for managing frames

2015-07-01T11:18:13+00:00

PROBLEM
--------

statedump requests that traverse call frames of all call stacks in
execution may race with a STACK_RESET on a stack.  This could crash the
corresponding glusterfs process. For e.g, recently we observed this in a
regression test case tests/basic/afr/sparse-self-heal.t.

FIX
---

gf_proc_dump_pending_frames takes a (TRY_LOCK) call_pool->lock before
iterating through call frames of all call stacks in progress.  With this
fix, STACK_RESET removes its call frames under the same lock.

Additional info
----------------

This fix makes call_stack_t to use struct list_head in place of custom
doubly-linked list implementation. This makes call_frame_t manipulation
easier to maintain in the context of STACK_WIND et al.

BUG: 1234408
Change-Id: I7e43bccd3994cd9184ab982dba3dbc10618f0d94
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11095
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
(cherry picked from commit 79e4c7b2fad6db15863efb4e979525b1bd4862ea)
Reviewed-on: http://review.gluster.org/11352

common-utils/libglusterfs : port log messages to a new framework

2015-07-01T09:16:03+00:00

        Backport of http://review.gluster.org/10824/
                    http://review.gluster.org/11400/

Cherry picked from 515a4c4e08eb9fcd92c9cca693ef9978b8a1b05c
>Change-Id: Iee1c083774c988375a7261cfd6d510ed4c574de2
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10824
>Tested-by: Gluster Build System 
>Reviewed-by: Kaushal M 

Change-Id: Iee1c083774c988375a7261cfd6d510ed4c574de2
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11289
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

protocol/client,server: Move EEXIST logs in mkdir and mknod to DEBUG level

2015-05-29T02:24:41+00:00

        Backport of: http://review.gluster.org/10791

Change-Id: I096296f0b97f62f49577ca698ae34e28cce4a4b4
BUG: 1225919
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10973
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

quota: support for inode quota in quota.conf

2015-05-08T06:54:33+00:00

Currently when quota limit is set, corresponding gfid
is set in quota.conf. This patch supports storing
inode-quota limits in quota.conf and also stores
additional byte for each gfid to differentiate
between usage quota limit and inode quota limit.

Change-Id: I444d7399407594edd280e640681679a784d4c46a
BUG: 1218170
Signed-off-by: vmallika 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/10069
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/10524

quota/cli: validate quota hard-limit option

2015-04-10T11:21:48+00:00

Quota hard-limit is supported only upto: 9223372036854775807 (int 64)

In CLI, it is allowed to set the value upto 16384PB (unsigned int 64),
this is not a valid value as the xattrop for quota accounting and
the quota enforcer operates on a signed int64 limit value.

This patches fixes the problem in CLI and allows user to set
the hard-limit value only from range 0 - 9223372036854775807

Change-Id: Ifce6e509e1832ef21d3278bacfa5bd71040c8cba
BUG: 1206432
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10022
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Vijay Bellur