glusterfs.git/libglusterfs/src/refcount.c, branch v5.3

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu

All: run codespell on the code and fix issues.

2018-07-22T14:40:16+00:00

Please review, it's not always just the comments that were fixed.
I've had to revert of course all calls to creat() that were changed
to create() ...

Only compile-tested!

Change-Id: I7d02e82d9766e272a7fd9cc68e51901d69e5aab5
updates: bz#1193929
Signed-off-by: Yaniv Kaul

refcount: correct the return value of GF_REF_PUT()

2017-03-22T01:00:17+00:00

It is documented that GF_REF_PUT() returns a 0 in case the call resulted
in free'ing the structure. However the implementations did not have a
return value, so nothing can actually use it.

Change-Id: Ic57091f5ddd7e0b80929dc335a5b6d37f5fe1b2e
BUG: 1433405
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/16910
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Xavier Hernandez 
Reviewed-by: Jeff Darcy 
Reviewed-by: Kaleb KEITHLEY

refcount: return pointer to the structure instead of a counter

2016-12-11T08:47:05+00:00

There are no real users of the counter. It was thought of a handy tool
to track and debug refcounting, but it is not used at all. Some parts of
the code would benefit from a pointer getting returned instead.

BUG: 1399780
Change-Id: I97e52c48420fed61be942ea27ff4849b803eed12
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15971
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Xavier Hernandez 
Reviewed-by: Kaleb KEITHLEY

core: add "gf_ref_t" for common refcounting structures

2015-06-20T12:01:43+00:00

Checks for compiler supported atomic operations comes from client_t.h.

An example usage of this change can be found in adding reference
counting to "struct auth_cache_entry" in http://review.gluster.org/11023

Basic usage looks like this:

   #include "refcount.h"

   struct my_struct {
       GF_REF_DECL;
       ... /* more members */
   }

   void my_destructor (void *data)
   {
       struct my_struct *my_ptr = (struct my_struct *) data;

       ... /* do some more cleanups */
       GF_FREE (my_ptr);
   }

   void init_ptr (struct parent *parent)
   {
       struct my_struct *my_ptr = malloc (sizeof (struct my_struct));

       GF_REF_INIT (my_ptr, my_destructor); /* refcount is set to 1 */

       ... /* my_ptr probably gets added to some parent structure */
       parent_add_ptr (parent, my_ptr);
   }

   void do_something (struct parent *parent)
   {
       struct my_struct *my_ptr = NULL;

       /* likely need to lock parent, depends on its access pattern */
       my_ptr = parent_remove_first_ptr (parent);
       /* unlock parent */

       ... /* do something */

       GF_REF_PUT (my_ptr); /* calls my_destructor on refcount = 0 */
   }

URL: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/11202
Change-Id: Idb98a5861a44c31676108ed8876db12c320912ef
BUG: 1228157
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11022
Reviewed-by: Xavier Hernandez 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System