glusterfs.git/libglusterfs/src/store.c, branch v3.7.9

libglusterfs: write error handling when filesystem have no space left

2015-08-25T06:09:20+00:00

When no space left on filesystem and user want to perform any operation
which result to change in /var/lib/glusterd/* files then glusterd is
failing to write on temporary file.

Fix is to handle error when write failed on temporary files due to no
space left on file system.

Change-Id: I79d595776b42580da35e1282b4a3cd7fe3d14afe
BUG: 1253148
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11029
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Cedric Buissart
(cherry picked from commit e7f737e62a9ea9eac730b6ba3ef8739e497e1540)
Reviewed-on: http://review.gluster.org/11902
Reviewed-by: Atin Mukherjee

mem-pool,stack,store,syncop,timer/libglusterfs : Porting to a new logging framework

2015-07-14T09:35:13+00:00

        Backport of http://review.gluster.org/10827

Cherry picked from 2b9b3ef3b646989bbc0412dca187b3f5fcad3283
>Change-Id: Idd3dcaf7eeea5207b3a5210676ce3df64153197f
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10827
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: NetBSD Build System 

Change-Id: Idd3dcaf7eeea5207b3a5210676ce3df64153197f
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11478
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

nfs: make it possible to disable nfs.mount-rmtab

2015-05-03T18:16:09+00:00

When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.

By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.

Cherry picked from commit 331ef6e1a86bfc0a93f8a9dec6ad35c417873849:
> BUG: 1169317
> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
> Reported-by: Cyril Peponnet 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/9223
> Tested-by: Gluster Build System 
> Reviewed-by: soumya k 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 

This change also contains the fixes to the test-case from:
>
> nfs: fix spurious failure in bug-1166862.t
>
> In some environments, "showmount" could return an NFS-client that does
> not start with "1". This would cause the test-case to fail. The check is
> incorrect, the number of lines should get counted instead.
>
> Also moving the test-case to the .../nfs/... subdirectory.
>
> Cherry picked from commit ee9b35a780607daddc2832b9af5ed6bf414aebc0:
> BUG: 1166862
> Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10419
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 
>

Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
BUG: 1215385
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10379
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libglusterfs : dead code fix.

2015-03-31T08:34:48+00:00

CID          : 1124884

Change-Id: I3332e844a01c1432f1d80a6acda7a87e8b01801c
BUG: 789278 
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9677
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

store: fix compile warning in gf_store_unlock()

2014-11-11T10:50:39+00:00

The following warning is logged when building on Fedora 20:

  store.c:712:15: warning: ignoring return value of 'lockf', declared
  with attribute warn_unused_result [-Wunused-result]

It does not really matter if unlocking fails, close() will release the
lock in any case. But, log the error in case close() can not finish and
hangs indefinitely (is that possible?).

Change-Id: If6c832f9aec10da6c1adb761b13b58e22d38a065
BUG: 1009076
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9078
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur

glusterd: Parsing key/value pair with value containing '='

2014-08-25T16:02:15+00:00

Parsing key/value pair in the brickinfo file, where value contains '='
would truncate everything after '=' in value.

For example:
A key/value pair
mnt-opts=rw,noatime,allocsize=1MiB,noattr2

is parsed as:
mnt-opts=rw,noatime,allocsize

BUG: 1132451
Change-Id: I756b2fc4b06875267212b1a5c3e91c5a40c6accb
Signed-off-by: Vijaikumar M 
Reviewed-on: http://review.gluster.org/8524
Reviewed-by: Sachin Pandit 
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

mgmt/gluster: Use fsync instead of O_SYNC

2014-05-05T20:52:51+00:00

Glusterd uses O_SYNC to write to temp file then performs renames
to the actual file and performs fsync on parent directory. Until
this rename happens syncing writes to the file can be deferred.
In this patch O_SYNC open of temp file is removed and fsync of the
fd before rename is done.

Change-Id: Ie7da161b0daec845c7dcfab4154cc45c2f49d825
BUG: 908277
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/7370
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

gluster: GlusterFS Volume Snapshot Feature

2014-04-11T23:29:17+00:00

This is the initial patch for the Snapshot feature. Current patch
includes following features:
* Snapshot create
* Snapshot delete
* Snapshot restore
* Snapshot list
* Snapshot info
* Snapshot status
* Snapshot config

Change-Id: I2f46920c0d61c515f6a60e0f8b46fff886d9f6a9
BUG: 1061685
Signed-off-by: shishir gowda 
Signed-off-by: Sachin Pandit 
Signed-off-by: Vijaikumar M 
Signed-off-by: Raghavendra Bhat 
Signed-off-by: Rajesh Joseph 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7128
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libglusterfs: Allow all valid file handle values to be closed.

2014-02-06T06:26:07+00:00

Zero (0) is a valid file handle. The code, as written, interprets return
values of open(2) that are less than or equal to zero to indicate an
error.  Only -1 indicates an error.

BUG: 789278
CID: 1124756

Change-Id: Ie77c25f1f557d5d5adcec464b49dc7df2e3dc7e5
Signed-off-by: Christopher R. Hertel 
Reviewed-on: http://review.gluster.org/6884
Reviewed-by: Lalatendu Mohanty 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Glusterd : glusterd process generates core due to NULL store handle

2014-01-04T06:24:27+00:00

Problem : glusterd crashed as backtrace revealed that store handle was
set to NULL.

Solution : In glusterd_store_global_info() function out block the
handle is dereferenced with out any NULL check which caused this
segmentation fault. A NULL check is introduced to avoid this. While
testing this fix, another issue was noticed where GF_ASSERT macro again
does not gurantee the NULL dereference check and hence this macro call
has been replaced by GF_VALIDATE_OR_GOTO macro call in places where
there is a danger of macro getting crashed due to NULL dereference
check.

Change-Id: Ic301aa45ce4bbdc2da751d2386439df7bb24c016
BUG: 1040844
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/6619
Reviewed-by: Niels de Vos 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur