glusterfs.git/rpc/rpc-lib/src/rpcsvc.c, branch v3.4.2qa3

rpcsvc: allocate large auxgid list on demand

2013-09-19T21:06:33+00:00

For rpc requests having large aux group list, allocate large list
on demand. Else use small static array by default.

Without this patch, glusterfsd allocates 140+MB of resident memory
just to get started and initialized.

Change-Id: I3a07212b0076079cff67cdde18926e8f3b196258
Signed-off-by: Anand Avati 
BUG: 953694
Reviewed-on: http://review.gluster.org/5927
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/5928

rpc: change dict key for fqdn

2013-05-23T16:54:31+00:00

changed the key from "client.fqdn", which could be wrongly
construed as belonging to protocol/client, to "fqdn".

This is a backport of 8403f9a2d976c33e01fbd9e4a4b04e8f1e936806.

Change-Id: Ib5f4a875a00b99cd903a29da19bafeb70baaab4e
BUG: 950056
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4536
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4965
Reviewed-by: Jeff Darcy

rpcsvc: fix dangerous setting of pointer on free'd structure.

2013-05-21T06:08:12+00:00

Change-Id: I6b666115a8ce155563078d7fc476d41486bab54f
BUG: 884452
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4995
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

rpc: get hostnames of client to allow FQDN based authentication

2013-02-07T00:15:54+00:00

If FQDNs are used to authenticate clients, then from
this commit forth, the client ip(v4,6) is reverse looked up
using getnameinfo to get a hostname associated with it,
if any, thereby making FQDN-based rpc authentication possible.

Change-Id: I4c5241e7079a2560de79ca15f611e65c0b858f9b
BUG: 903553
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4439
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc/dump: return correct return value

2013-02-06T21:02:47+00:00

fix e8d09b9ab9 resulted in rpcsvc_dump returning large non-zero
values to caller in case of success. This patch fixes that issue
by returning 0

Change-Id: I594703dada74da17b33c98b073627a3378d170c5
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4477
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero

2013-02-05T21:35:16+00:00

The convention followed is that any actor should return non-zero
value only if it has not attempted to send the reply back. If an
actor returns non-zero, rpcsvc_handle_rpc_call tries to send an
error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong
to invoke it more than once on same rpc_req. When the transport is not
connected, rpcsvc_dump used to pass the non-zero value it got from
 transport to rpcsvc resulting in memory corruption. Hence this patch
makes rpcsvc_dump to return 0.

Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Jeff Darcy

"gcc -pedantic": made 'inline' functions as 'static inline' functions

2013-01-23T19:12:15+00:00

for passing the build with -pedantic flag

Change-Id: I80fd9528321e4c6ea5bec32bf5cdc54cc4e4f65e
BUG: 875913
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/4186
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: Add an extra log message

2012-12-10T22:09:15+00:00

Adds an extra log message in rpcvsc_check_and_reply_error().
Also, makes a small change in the test-script.

Change-Id: I2b686e6fa86529cc4fbf0066df64057a9784b849
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4285
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: do a 'iobuf_ref()' on buffer while synctaskizing actor

2012-12-10T05:59:41+00:00

Starting rpc actors using synctask causes rpcsvc to return before the actor
actually finishes its actions. This would cause the buffer to be unreffed by
socket and be possibly reused, before the actor used it, leading to failures
in the actor.
This patch makes rpcsvc take a ref on the buffer when synctaskizing the actor
and store it in the request structure, and then later unref it when the request
structure is destroyed. This makes sure that the buffer is not reused before the
actor has finished.

Change-Id: I8f81e1fef8f3719db220471d2d8ffb8916958956
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4277
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: framework for executing actors as synctask

2012-09-20T06:18:08+00:00

An rpcsvc_program can be registered by setting .synctask field
to 1 which will make actors of that program be executed in a
synctask, thus freeing up the rpc/poll thread while the actor
executes.

Change-Id: Idacef2ad3bcae0f354fd0fc16ca06ba7094d7b98
BUG: 762935
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/3833
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi