glusterfs.git/rpc/rpc-lib, branch v3.4.0alpha2

rpc: bring in root-squashing behavior in rpc

2013-03-05T07:44:04+00:00

* requests coming in as root are converted to nfsnobody

* with open-behind some acl checks wont happen and nfsnobody
  can read the file "whose owner is root and other users do not
  have permission to read the file". This is becasue open-behind
  does not send the open to the brick and sends success to the
  application, thus the acl related tests on the file wont happen
  which would have prevented the file from being opened.

Change-Id: I12a3e6b2a12884d00bb81f2779074fed09b1b2e4
BUG: 887145
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4619
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

rpc: get hostnames of client to allow FQDN based authentication

2013-02-07T00:15:54+00:00

If FQDNs are used to authenticate clients, then from
this commit forth, the client ip(v4,6) is reverse looked up
using getnameinfo to get a hostname associated with it,
if any, thereby making FQDN-based rpc authentication possible.

Change-Id: I4c5241e7079a2560de79ca15f611e65c0b858f9b
BUG: 903553
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4439
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

nfs/nlm: use req's uid and gid for open_and_resume

2013-02-07T00:14:55+00:00

Previously, NLM was setting the frame->root->{uid,gid}
to root by default. This causes permission problems with
root squashing for lock calls. Now, we obtain the uid and
gid from rpc request. And duplicate #defines are removed
from rpcsvc.h

Change-Id: I5d6c87aed8d04aab2619bb913408048c0a02d1e7
BUG: 906884
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4466
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc/dump: return correct return value

2013-02-06T21:02:47+00:00

fix e8d09b9ab9 resulted in rpcsvc_dump returning large non-zero
values to caller in case of success. This patch fixes that issue
by returning 0

Change-Id: I594703dada74da17b33c98b073627a3378d170c5
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4477
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Use client-op-versions during "volume set"

2013-02-06T20:17:49+00:00

The supported op-versions of the client and the name of the requested volume,
are saved during server_getspec(). These are used during the staging of volume
set. If the option being set is not supported by any of the clients which
currently have the volume mounted, then set will fail.

Change-Id: I4e6b60b274d5200508762dc0204cfa848a6c0aa4
BUG: 907311
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4424
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero

2013-02-05T21:35:16+00:00

The convention followed is that any actor should return non-zero
value only if it has not attempted to send the reply back. If an
actor returns non-zero, rpcsvc_handle_rpc_call tries to send an
error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong
to invoke it more than once on same rpc_req. When the transport is not
connected, rpcsvc_dump used to pass the non-zero value it got from
 transport to rpcsvc resulting in memory corruption. Hence this patch
makes rpcsvc_dump to return 0.

Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Jeff Darcy

"gcc -pedantic": made 'inline' functions as 'static inline' functions

2013-01-23T19:12:15+00:00

for passing the build with -pedantic flag

Change-Id: I80fd9528321e4c6ea5bec32bf5cdc54cc4e4f65e
BUG: 875913
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/4186
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: Add an extra log message

2012-12-10T22:09:15+00:00

Adds an extra log message in rpcvsc_check_and_reply_error().
Also, makes a small change in the test-script.

Change-Id: I2b686e6fa86529cc4fbf0066df64057a9784b849
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4285
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: do a 'iobuf_ref()' on buffer while synctaskizing actor

2012-12-10T05:59:41+00:00

Starting rpc actors using synctask causes rpcsvc to return before the actor
actually finishes its actions. This would cause the buffer to be unreffed by
socket and be possibly reused, before the actor used it, leading to failures
in the actor.
This patch makes rpcsvc take a ref on the buffer when synctaskizing the actor
and store it in the request structure, and then later unref it when the request
structure is destroyed. This makes sure that the buffer is not reused before the
actor has finished.

Change-Id: I8f81e1fef8f3719db220471d2d8ffb8916958956
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4277
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati