glusterfs.git/rpc/rpc-transport/socket, branch v4.1dev

build: Link libgfrpc within rpc-transport shared libraries

2018-01-11T12:41:54+00:00

Now with https://review.gluster.org/#/c/19056/ merged, we perform
dlopen() with RTLD_LOCAL so that every shared library is expected to
be explicitly linked against other required libraries.

"undefined symbol ..." was seen while trying to access GlusterFS volumes
via NFS-Ganesha/Samba using libgfapi resulting in an unusable state.

This is a follow-up patch to https://review.gluster.org/#/c/17659/
to make sure that we link libgfrpc too while making socket and rdma
rpc-transport shared libraries.

Change-Id: I9943cdc449c257ded3cb9f9f2becdd5784d1d82d
BUG: 1532238
Signed-off-by: Anoop C S

Revert "rpc: merge ssl infra with epoll infra"

2018-01-07T03:55:51+00:00

This reverts commit 56e5fdae74845dfec0ff7ad0c8fee77695d36ad5.

Change-Id: Ia62cee5440bbe8e23f5da9cff692d792091d544a
Signed-off-by: Milind Changire

rpc: merge ssl infra with epoll infra

2017-12-12T14:42:05+00:00

Patch attempts to use the epoll infra for handling SSL connections
as well instead of the socket_poller() thread func.
This essentially makes priv->own_thread flag redundant.

SSL_connect()/SSL_accept() is now non-blocking which has done away
with the localised poll() in ssl_do(). So, ssl_do() has been updated
appropriately.

own_thread and coincidently socket_poller() thread for SSL processing
is now deprecated.

Added a timeout to test whether seal-heal daemon is up and running
as per Ravi's suggestion.

Change-Id: If2b5d7b4fd19e321cb289e08d49a718d2161aafe
Signed-off-by: Milind Changire

rpc: Fix several coverity issues in rpc/socket code

2017-11-10T07:26:02+00:00

This patch fixes issues 287,289,286,809,690,276,401,402,403 from [1]

[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/

BUG: 789278
Change-Id: I2716d07fbdab59f779c2852bde07756b0e9a4ddc
Signed-off-by: Mohit Agrawal

rpc/rpc-transport/: MISSING_BREAK in name.c

2017-11-08T02:16:39+00:00

Coverity ID: 286, 287, 288, 289, 290

Issue: Event unterminated_case:	The case for value "27" is not
terminated by a 'break' statement.

Added Fall through in comment between switch cases.

Change-Id: I9e3f205c05ac22a85a87423ef690fc18891eaece
BUG: 789278
Signed-off-by: Girjesh Rajoria

gluster: IPv6 single stack support

2017-10-24T09:28:08+00:00

Summary:
- This diff changes all locations in the code to prefer inet6 family
  instead of inet.  This will allow change GlusterFS to operate
  via IPv6 instead of IPv4 for all internal operations while still
  being able to serve (FUSE or NFS) clients via IPv4.
- The changes apply to NFS as well.
- This diff ports D1892990, D1897341 & D1896522 to the 3.8 branch.

Test Plan: Prove tests!

Reviewers: dph, rwareing

Signed-off-by: Shreyas Siravara 

Change-Id: I34fdaaeb33c194782255625e00616faf75d60c33
BUG: 1406898
Reviewed-on-3.8-fb: http://review.gluster.org/16059
Reviewed-by: Shreyas Siravara 
Tested-by: Shreyas Siravara

rpc/rpc-transport/socket/: Coverity Issue MISSING_BREAK

2017-09-29T06:34:47+00:00

Issue: Event unterminated_case:	The case for value "AF_INET_SDP"
is not terminated by a 'break' statement.

Function: socket_server_get_local_sockaddr

Added Fall through in comment after case AF_INET_SDP.

Change-Id: I5340cde2257be33ff13c53cee6ccdb33df7d2c88
BUG: 789278
Signed-off-by: Girjesh Rajoria

rpc-transport/socket: tab -> spaces cleanup

2017-09-15T08:28:42+00:00

tired of review comments about use of tabs when the whole file uses tabs

Change-Id: I4f822a53f47886da04282f9c3fb84d81a7b3f8d0
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/18286
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

rpc: TLSv1_2_method() is deprecated in OpenSSL-1.1

2017-09-13T18:22:47+00:00

Fedora 26 has OpenSSL-1.1. Compile-time warnings indicate
that TLSv1_2_method() is now deprecated. As per the SSL man page:

  TLS_method(), TLS_server_method(), TLS_client_method()
    These are the general-purpose version-flexible SSL/TLS methods.
    The actual protocol version used will be negotiated to the highest
    version mutually supported by the client and the server. The
    supported protocols are SSLv3, TLSv1, TLSv1.1 and TLSv1.2.
    Applications should use these methods, and avoid the version-
    specific methods described below.
  ...
  TLSv1_2_method(), ...
  ...

Note that OpenSSL-1.1 is the version of OpenSSL; Fedora 25 and RHEL 7.3
and other distributions (still) have OpenSSL-1.0.

TLS versions are orthogonal to the OpenSSL version.  TLS_method() is the
new — in OpenSSL-1.1 — version flexible function intended to replace the
TLSv1_2_method() function in OpenSSL-1.0 and the older (?), insecure
TLSv23_method(). (OpenSSL-1.0 does not have TLS_method())

Change-Id: I190363ccffe7c25606ea2cf30a6b9ff1ec186057
BUG: 1491025
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/18268
Reviewed-by: Emmanuel Dreyfus 
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System

socket: Use granular mutex locks during pollin and pollout event processing

2017-09-08T16:18:48+00:00

... instead of one global lock. This is because pollin and pollout
processing code operate on mutually exclusive members of
socket_private_t. Keeping this in mind, this patch introduces
the more granular priv->in_lock and priv->out_lock locks.

For pollerr, which modifies both priv->incoming and priv->ioq, both
locks need to be taken.

Change-Id: Id7aeb608dc7755551b6b404470d5d80709c81960
BUG: 1467614
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17687
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: mohammed rafi  kc 
CentOS-regression: Gluster Build System