glusterfs.git/rpc/rpc-transport, branch release-3.7

rpc/socket: Close pipe on disconnection

2016-10-26T11:38:17+00:00

Encrypted connections create a pipe, which isn't closed when the
connection disconnects. This leaks fds, and gluster eventually ends up
in a situation with fd starvation which leads to operation failures.

> Change-Id: I144e1f767cec8c6fc1aa46b00cd234129d2a4adc
> BUG: 1336371
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/14356
> Tested-by: MOHIT AGRAWAL 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Raghavendra G 

Change-Id: I144e1f767cec8c6fc1aa46b00cd234129d2a4adc
BUG: 1336369
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/15704
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: lidi 
CentOS-regression: Gluster Build System

socket: log the client identifier in ssl connect

2016-08-04T05:10:26+00:00

Backport of commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a

> Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
> BUG: 1333912
> Signed-off-by: Raghavendra Bhat 
> Reviewed-on: http://review.gluster.org/14242
> Tested-by: Vijay Bellur 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Smoke: Gluster Build System 
> (cherry picked from commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a)

Change-Id: I2a57a206edab3e0c05ce28c299d78264c9a33d8b
BUG: 1351933
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/14844
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Atin Mukherjee

rpc/socket: pthread resources are not cleaned up

2016-07-27T10:12:58+00:00

A socket_connect failure creates a new pthread which
is not a detached thread. As no pthread_join is called,
the thread resources are not cleaned up causing a memory leak.

Now, socket_connect creates a detached thread to handle failure.

> Change-Id: Idbf25d312f91464ae20c97d501b628bfdec7cf0c
> BUG: 1343374
> Signed-off-by: N Balachandran 
> Reviewed-on: http://review.gluster.org/14875
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
(cherry picked from commit 9886d568a7a8839bf3acc81cb1111fa372ac5270)

Change-Id: If0a65c50fef2a32148cf3a1d7992e63f044bf0ad
BUG: 1360553
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/15019
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Tested-by: Oleksandr Natalenko 
Reviewed-by: Raghavendra G

rpc/socket.c : Modify socket_poller code in case of ENODATA error code.

2016-07-26T17:07:28+00:00

Problem:  Polling failure errors are coming till volume is not come while
          SSL is enabled.

Solution: To avoid the message update one condition in socket_poller code
          It will not exit from thread in case of received ENODATA from
          ssl_do function.

Backport of commit 84e9fc2fb5fabf9d1e553a420854a306cdb8a168

> Change-Id: Ia514e99b279b07b372ee950f4368ac0d9c702d82
> BUG: 1349709
> Signed-off-by: Mohit Agrawal 
> Reviewed-on: http://review.gluster.org/14786
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> (cherry picked from commit 84e9fc2fb5fabf9d1e553a420854a306cdb8a168)

BUG: 1359651
Signed-off-by: Mohit Agrawal 

Change-Id: I86aa9955eca13d23120ba17b787f619c7de6be0c
Reviewed-on: http://review.gluster.org/14998
Tested-by: MOHIT AGRAWAL 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Jeff Darcy

rpc/socket.c: Modify approach to cleanup threads of socket_poller in socket_spawn.

2016-07-26T11:42:18+00:00

Problem: Current approach to cleanup threads of socket_poller is not appropriate.

Solution: Enable detach flag at the time of thread creation in socket_spawn.

Fix: Write a new wrapper(gf_create_detach_thread) to create detachable thread
         instead of store thread ids in a queue.

Test: Fix is verfied on gluster process, To test the patch followed below
      procedure
      Enable the client.ssl and server.ssl option on the volume
      Start the volume and count anon segment in pmap output for glusterd process
      pmap -x  | grep "\[ anon \]" | wc -l
      Stop the volume and check again count of anon segment it should not increase.

Backport of commit 2ee48474be32f6ead2f3834677fee89d88348382

> Signed-off-by: Mohit Agrawal 
> Change-Id: Ib8f7ec7504ec8f6f74b45ce6719b6fb47f9fdc37
> BUG: 1336508
> Reviewed-on: http://review.gluster.org/14694
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

BUG: 1354394
Change-Id: I271e83e7a210ecd27a7471c53147ceb837a33cad
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/14886
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G

rpc: invalid argument when function setsockopt sets option TCP_USER_TIMEOUT

2016-07-12T12:07:16+00:00

If option "transport.tcp-user-timeout" hasn't been setted, glusterd's
priv->timeout will be -1, which will cause invalid argument when
set TCP_USER_TIMEOUT.

Cherry picked from commit b2c73cbf423de6201f956f522b7429615c88869d:
> Change-Id: Ibc16264ceac0e69ab4a217ffa27c549b9fa21df9
> BUG: 1349657
> Signed-off-by: Zhou Zhengping 
> Reviewed-on: http://review.gluster.org/14785
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: Ibc16264ceac0e69ab4a217ffa27c549b9fa21df9
BUG: 1354404
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14889
Smoke: Gluster Build System 
Reviewed-by: Zhou Zhengping 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

rpc: change client insecure port ceiling from 65535 to 49151

2016-05-20T10:55:35+00:00

current port allocation to various processes (clumsy):

 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> fall back to this, if in above case ports exhaust
65535 - 1024    -> client port range if bind insecure is on
49152 - 65535   -> brick port range

now, we have segregated port ranges 0 - 65535 to below 3 ranges

 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> client port range if bind insecure is on
                   (fall back to this, if in above case ports exhaust)
49152 - 65535   -> brick port range

so now we have a clean segregation of port mapping

Backport of:
> Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
> BUG: 1335776
> Signed-off-by: Prasanna Kumar Kalever 
> Reviewed-on: http://review.gluster.org/14326
> Tested-by: Prasanna Kumar Kalever 
> Reviewed-by: Raghavendra Talur 
> Tested-by: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Raghavendra G 

Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
BUG: 1335813
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14412
Tested-by: Prasanna Kumar Kalever 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

socket: Fix incorrect handling of partial reads

2016-05-12T05:17:39+00:00

The usage of function local variables in the protocol state
machine caused an incorrect behaviour when a partial read
from the socket forced the function to return and restart
later when more data was available. At this point the local
variables contained incorrect data.

> Change-Id: I4db1f4ef5c46a3d2d7f7c5328e906188c3af49e6
> BUG: 1334285
> Signed-off-by: Xavier Hernandez 
> Reviewed-on: http://review.gluster.org/14270
> Reviewed-by: Raghavendra G 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Tested-by: Raghavendra G 
> CentOS-regression: Gluster Build System 

Change-Id: I0465969f27a38912a1b2cd50f5c8ae61bc782e8c
BUG: 1331502
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/14292
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

rpc: define client port range

2016-05-05T03:24:42+00:00

Problem:
when bind-insecure is 'off', all the clients bind to secure ports,
if incase all the secure ports exhaust the client will no more bind
to secure ports and tries gets a random port which is obviously insecure.

we have seen the client obtaining a port number in the range 49152-65535
which are actually reserved as part of glusterd's pmap_registry for bricks,
hence this will lead to port clashes between client and brick processes.

Solution:
If we can define different port ranges for clients incase where secure ports
exhaust, we can avoid the maximum port clashes with in gluster processes.

Still we are prone to have clashes with other non-gluster processes, but
the chances being very low, but that's a different story on its own, which
will be handled in upcoming patches.

> Change-Id: Ib5ce05991aa1290ccb17f6f04ffd65caf411feaf
> BUG: 1322805
> Signed-off-by: Prasanna Kumar Kalever 
> Reviewed-on: http://review.gluster.org/13998
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Raghavendra G 
> Signed-off-by: Prasanna Kumar Kalever 

Change-Id: I712676d3e79145d78a17f2c361525e6ef82a4732
BUG: 1323564
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14205
Tested-by: Prasanna Kumar Kalever 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G

rpc: assign port only if it is unreserved

2016-05-05T03:24:32+00:00

Current order:
    assign port;
    check for port;
    if reserved {
        port--;
        continue to i;
    }
    bind();

basically, we are assigning port first then checking if it is reserved

Fix:
    get unreserved port;
    assign port;
    bind();

from now, we get unreserved port first and then assign it

Backport of:
> Change-Id: I004580c5215e7c9cae3594af6405b20fcd9fa4ad
> BUG: 1323659
> Signed-off-by: Prasanna Kumar Kalever 
> Reviewed-on: http://review.gluster.org/13900
> Tested-by: Prasanna Kumar Kalever 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Jeff Darcy 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra Talur 
> Smoke: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Signed-off-by: Prasanna Kumar Kalever 

Change-Id: I772c1323606f1853542e22d8ab4d80934871efcb
BUG: 1332838
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14204
Tested-by: Prasanna Kumar Kalever 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G