glusterfs.git/rpc/rpc-transport, branch v3.10dev

rpc: fix unused variable warnings/errors

2016-08-29T12:00:49+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I20d91091bee0bf8f198a307ebba4b284bc3817ff
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15240
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

socket: SSL_shutdown should be called before socket shutdown

2016-08-16T19:46:45+00:00

SSL_shutdown shuts down an active SSL connection. But we
are calling this after underlying socket is disconnected.

Change-Id: Ia943179d23395f42b942450dbcf26336d4dfc813
BUG: 1362602
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/15072
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

rpc/socket.c : Modify socket code to avoid fd leak in case of socket_poller thread

2016-07-20T12:37:39+00:00

Update socket code to avoid fd leak in case of socket_poller thread.

Change-Id: Ifa9718fbaf065988a299cda7ba0282dfd6b10a32
BUG: 1356888
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/14929
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

rpc: invalid argument when function setsockopt sets option TCP_USER_TIMEOUT

2016-07-11T01:59:04+00:00

If option "transport.tcp-user-timeout" hasn't been setted, glusterd's
priv->timeout will be -1, which will cause invalid argument when
set TCP_USER_TIMEOUT.

Change-Id: Ibc16264ceac0e69ab4a217ffa27c549b9fa21df9
BUG: 1349657
Signed-off-by: Zhou Zhengping 
Reviewed-on: http://review.gluster.org/14785
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

rpc/socket: pthread resources are not cleaned up

2016-07-08T20:17:12+00:00

A socket_connect failure creates a new pthread which
is not a detached thread. As no pthread_join is called,
the thread resources are not cleaned up causing a memory leak.

Now, socket_connect creates a detached thread to handle failure.

Change-Id: Idbf25d312f91464ae20c97d501b628bfdec7cf0c
BUG: 1343374
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/14875
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

rpc/socket.c : Modify socket_poller code in case of ENODATA error code.

2016-07-08T14:39:03+00:00

Problem:  Polling failure errors are coming till volume is not come while
          SSL is enabled.

Solution: To avoid the message update one condition in socket_poller code
          It will not exit from thread in case of received ENODATA from
          ssl_do function.

Change-Id: Ia514e99b279b07b372ee950f4368ac0d9c702d82
BUG: 1349709
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/14786
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

socket: log the client identifier in ssl connect

2016-06-30T22:24:20+00:00

Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
BUG: 1333912
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/14242
Tested-by: Vijay Bellur 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Smoke: Gluster Build System

rpc/socket.c: Modify approach to cleanup threads of socket_poller in socket_spawn.

2016-06-24T13:23:51+00:00

    Problem: Current approach to cleanup threads of socket_poller is not appropriate.

    Solution: Enable detach flag at the time of thread creation in socket_spawn.

    Fix: Write a new wrapper(gf_create_detach_thread) to create detachable thread
         instead of store thread ids in a queue.

    Test: Fix is verfied on gluster process, To test the patch followed below procedure
          Enable the client.ssl and server.ssl option on the volume
          Start the volume and count anon segment in pmap output for glusterd process
          pmap -x  | grep "\[ anon \]" | wc -l
          Stop the volume and check again count of anon segment it should not increase.

Signed-off-by: Mohit Agrawal 
Change-Id: Ib8f7ec7504ec8f6f74b45ce6719b6fb47f9fdc37
BUG: 1336508
Reviewed-on: http://review.gluster.org/14694
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

libglusterfs (timer): race conditions, illegal mem access, mem leak

2016-06-01T13:50:13+00:00

While investigating gfapi memory consumption with valgrind, valgrind
reported several memory access issues.

Also see the timer 'registry' being recreated (shortly) after being
freed during teardown due to the way it's currently written.

Passing ctx as data to gf_timer_proc() is prone to memory access
issues if ctx is freed before gf_timer_proc() terminates. (And in
fact this does happen, at least in valgrind.) gf_timer_proc() doesn't
need ctx for anything, it only needs ctx->timer, so just pass that.

Nothing ever calls gf_timer_registry_init(). Nothing outside of
timer.c that is. Making it and gf_timer_proc() static.

Change-Id: Ia28454dda0cf0de2fec94d76441d98c3927a906a
BUG: 1333925
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14247
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Poornima G 
Reviewed-by: Niels de Vos 
Reviewed-by: Jeff Darcy

rpc: change client insecure port ceiling from 65535 to 49151

2016-05-18T10:26:01+00:00

current port allocation to various processes (clumsy):

 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> fall back to this, if in above case ports exhaust
65535 - 1024    -> client port range if bind insecure is on
49152 - 65535   -> brick port range

now, we have segregated port ranges 0 - 65535 to below 3 ranges

 1023 - 1       -> client ports range if bind secure is turned on
49151 - 1024    -> client port range if bind insecure is on
                   (fall back to this, if in above case ports exhaust)
49152 - 65535   -> brick port range

so now we have a clean segregation of port mapping

Change-Id: Ie3b4e7703e0bbeabbe0adbdd6c60d9ef78ef7c65
BUG: 1335776
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14326
Tested-by: Prasanna Kumar Kalever 
Reviewed-by: Raghavendra Talur 
Tested-by: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra G