glusterfs.git/rpc/rpc-transport, branch v3.9.1

socket: log the client identifier in ssl connect

2017-01-10T06:32:50+00:00

Problem: client identifier is not logged in message in ssl_setup_connection

Solutuion: In ssl_setup_connection xl_private is not available in rpc_transport
           so changed to this peerinfo.identifier.

Backport of commit 2e23c62cc50037c8e61bcd9c04348409e7627181
BUG: 1383879
Signed-off-by: Mohit Agrawal 

> BUG: 1380275
> Change-Id: I05006a3d63e46de8c388298c22faa9a3329eb6f3
> Signed-off-by: Mohit Agrawal 
> Reviewed-on: http://review.gluster.org/15596
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Vijay Bellur 
> (cherry picked from commit 2e23c62cc50037c8e61bcd9c04348409e7627181)

Change-Id: I904f267937e0e12b0b1e19027c017e5d979b8197
Reviewed-on: http://review.gluster.org/15625
Tested-by: MOHIT AGRAWAL 
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

rpc/socket.c : Modify gf_log message in socket_poller code in case of error

2017-01-10T06:28:45+00:00

Problem:  In case of SSL after stopping the volume if client(mount point) is
          still trying to write the data on socket then it will throw an EIO
          error on that socket and given this log message is captured at every
          attempt this would flood the log file.

Solution: To reduce the frequency of stored log message use GF_LOG_OCCASIONALLY
          instead of gf_log.

> BUG: 1381115
> Change-Id: I66151d153c2cbfb017b3ebc4c52162278c0f537c
> Signed-off-by: Mohit Agrawal 
> Reviewed-on: http://review.gluster.org/15605
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> (cherry picked from commit 070145750006c87099f945b4990a4460d814c21f)

Change-Id: I9536dcb2cbf3f8082dccf049cbfb21a034f5eac1
BUG: 1384363
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/15632
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra G

rpc/socket: Close pipe on disconnection

2016-10-25T11:09:08+00:00

Encrypted connections create a pipe, which isn't closed when the
connection disconnects. This leaks fds, and gluster eventually ends up
in a situation with fd starvation which leads to operation failures.

> Change-Id: I144e1f767cec8c6fc1aa46b00cd234129d2a4adc
> BUG: 1336371
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/14356
> Tested-by: MOHIT AGRAWAL 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Raghavendra G 
> Signed-off-by: Kaushal M 

Change-Id: I144e1f767cec8c6fc1aa46b00cd234129d2a4adc
BUG: 1387960
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/15702
Tested-by: Atin Mukherjee 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra G

rpc/socket.c : Modify socket_poller code in case of ENODATA error code.

2016-10-24T13:46:51+00:00

Problem:  Continuous warning message(ENODATA) are coming in socket_rwv
          while SSL is enabled.

Solution: To avoid the warning message update one condition in
          socket_poller loop code before break from loop in case
          of error returned by poll functions.

> BUG: 1386450
> Change-Id: I19b3a92d4c3ba380738379f5679c1c354f0ab9b1
> Signed-off-by: Mohit Agrawal 
> Reviewed-on: http://review.gluster.org/15677
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 
> (cherry picked from commit ec64ce2e1684003f4e7a20d4372e414bfbddb6fb)

BUG: 1387975
Change-Id: Ia61e6576d16f377850dc43991180571b2ed6997f
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/15711
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Jeff Darcy

socket: pollerr event shouldn't trigger socket_connnect_finish

2016-09-21T15:21:18+00:00

If connect fails with any other error than EINPROGRESS we cannot get
the error status using getsockopt (... SO_ERROR ... ). Hence we need
to remember the state of connect and take appropriate action in the
event_handler for the same.

As an added note, a event can come where poll_err is HUP and we have
poll_in as well (i.e some status was written to the socket), so for
such cases we need to finish the connect, process the data and then
the poll_err as is the case in the current code.

Special thanks to Kaushal M & Raghavendra G for figuring out the issue.

>Signed-off-by: Shyam 
>Reviewed-on: http://review.gluster.org/15440
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Raghavendra G 

Change-Id: Ic45ad59ff8ab1d0a9d2cab2c924ad940b9d38528
BUG: 1377386
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15533
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

rpc: fix unused variable warnings/errors

2016-08-29T12:00:49+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I20d91091bee0bf8f198a307ebba4b284bc3817ff
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15240
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

socket: SSL_shutdown should be called before socket shutdown

2016-08-16T19:46:45+00:00

SSL_shutdown shuts down an active SSL connection. But we
are calling this after underlying socket is disconnected.

Change-Id: Ia943179d23395f42b942450dbcf26336d4dfc813
BUG: 1362602
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/15072
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

rpc/socket.c : Modify socket code to avoid fd leak in case of socket_poller thread

2016-07-20T12:37:39+00:00

Update socket code to avoid fd leak in case of socket_poller thread.

Change-Id: Ifa9718fbaf065988a299cda7ba0282dfd6b10a32
BUG: 1356888
Signed-off-by: Mohit Agrawal 
Reviewed-on: http://review.gluster.org/14929
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

rpc: invalid argument when function setsockopt sets option TCP_USER_TIMEOUT

2016-07-11T01:59:04+00:00

If option "transport.tcp-user-timeout" hasn't been setted, glusterd's
priv->timeout will be -1, which will cause invalid argument when
set TCP_USER_TIMEOUT.

Change-Id: Ibc16264ceac0e69ab4a217ffa27c549b9fa21df9
BUG: 1349657
Signed-off-by: Zhou Zhengping 
Reviewed-on: http://review.gluster.org/14785
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

rpc/socket: pthread resources are not cleaned up

2016-07-08T20:17:12+00:00

A socket_connect failure creates a new pthread which
is not a detached thread. As no pthread_join is called,
the thread resources are not cleaned up causing a memory leak.

Now, socket_connect creates a detached thread to handle failure.

Change-Id: Idbf25d312f91464ae20c97d501b628bfdec7cf0c
BUG: 1343374
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/14875
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy