glusterfs.git/rpc/rpc-transport, branch v4.1dev

build: Link libgfrpc within rpc-transport shared libraries

2018-01-11T12:41:54+00:00

Now with https://review.gluster.org/#/c/19056/ merged, we perform
dlopen() with RTLD_LOCAL so that every shared library is expected to
be explicitly linked against other required libraries.

"undefined symbol ..." was seen while trying to access GlusterFS volumes
via NFS-Ganesha/Samba using libgfapi resulting in an unusable state.

This is a follow-up patch to https://review.gluster.org/#/c/17659/
to make sure that we link libgfrpc too while making socket and rdma
rpc-transport shared libraries.

Change-Id: I9943cdc449c257ded3cb9f9f2becdd5784d1d82d
BUG: 1532238
Signed-off-by: Anoop C S

Revert "rpc: merge ssl infra with epoll infra"

2018-01-07T03:55:51+00:00

This reverts commit 56e5fdae74845dfec0ff7ad0c8fee77695d36ad5.

Change-Id: Ia62cee5440bbe8e23f5da9cff692d792091d544a
Signed-off-by: Milind Changire

rpc-transport/rdma: Fix coverity issues in rdma transport

2017-12-28T06:59:04+00:00

Issues:
[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-12-25-0bc22bef/cov-errors.txt

Resolved:
[1] rdma.c:128 var_deref_op: Dereferencing null pointer "post".
[2] rdma.c:677: Potentially overflowing expression
[3] rdma.c:4250: freed_arg: "rpc_transport_unref" frees "peer->trans".
[4] rdma.c:4644: var_deref_op: Dereferencing null pointer "rdma_ctx".
[5] rdma.c:4945: cond_false: Condition "rdma_ctx != NULL", taking false branch.

Change-Id: Iec38f118d645df4131739da412a6c741ebbd2f85
BUG: 789278
Signed-off-by: Yi Wang

all: Simplify component message id's definition

2017-12-14T02:33:51+00:00

This patch creates a new way of defining message id's that is easier
and less error prone because it doesn't require so many manual changes
each time a new component is defined or a new message created.

Change-Id: I71ba8af9ac068f5add7e74f316a2478bc991c67b
Signed-off-by: Xavier Hernandez

rpc: merge ssl infra with epoll infra

2017-12-12T14:42:05+00:00

Patch attempts to use the epoll infra for handling SSL connections
as well instead of the socket_poller() thread func.
This essentially makes priv->own_thread flag redundant.

SSL_connect()/SSL_accept() is now non-blocking which has done away
with the localised poll() in ssl_do(). So, ssl_do() has been updated
appropriately.

own_thread and coincidently socket_poller() thread for SSL processing
is now deprecated.

Added a timeout to test whether seal-heal daemon is up and running
as per Ravi's suggestion.

Change-Id: If2b5d7b4fd19e321cb289e08d49a718d2161aafe
Signed-off-by: Milind Changire

rpc-transport/rdma: Add a mutex for the list of RDMA Memory Region(MR) access

2017-12-12T05:49:35+00:00

Problem: gf_rdma_device_t->all_mr is a __gf_rdma_arena_mr(includes MR content)
	 kind of list in the rdma rpc-transport. The rdma rpc-transport will
	 add/delete items to the list when MRs register, deregister, and free.
	 Because gf_rdma_device_t->all_mr is used by different threads
	 and it is not mutex protected, rdma transport maybe access obsolete
	 items in it.

Solution: Add a mutex protection for the gf_rdma_device_t->all_mr.

Change-Id: I2b7de0f7aa516b90bb6f3c6aae3aadd23b243900
BUG: 1522651
Signed-off-by: Yi Wang

rpc/rpc-transport: dead code coverity fix

2017-11-21T07:07:27+00:00

issue: Execution cannot reach this statement: "iobuf_unref(iobuf);"

function: gf_rdma_do_reads

fix: removed the statement and the corresponding 'if' block

Change-Id: Ia21b872996dbc8e0a66c8c28dd90b367d3c9aadd
BUG: 789278
Signed-off-by: Kartik_Burmee

rpc: Fix several coverity issues in rpc/socket code

2017-11-10T07:26:02+00:00

This patch fixes issues 287,289,286,809,690,276,401,402,403 from [1]

[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/

BUG: 789278
Change-Id: I2716d07fbdab59f779c2852bde07756b0e9a4ddc
Signed-off-by: Mohit Agrawal

rpc/rpc-transport/: MISSING_BREAK in name.c

2017-11-08T02:16:39+00:00

Coverity ID: 286, 287, 288, 289, 290

Issue: Event unterminated_case:	The case for value "27" is not
terminated by a 'break' statement.

Added Fall through in comment between switch cases.

Change-Id: I9e3f205c05ac22a85a87423ef690fc18891eaece
BUG: 789278
Signed-off-by: Girjesh Rajoria

rpc/rpc-transport/rdma/: Coverity Issue MISSING_BREAK

2017-11-06T07:50:00+00:00

Issue: Event unterminated_case:	The case for value "27" is not
terminated by a 'break' statement.

Function: gf_rdma_get_transport_identifiers, gf_rdma_server_get_local_sockaddr

Added Fall through in comment after case AF_INET_SDP.

Change-Id: Ia30d0143a63a63af2b4b1d9b02551b9260444f35
BUG: 789278
Signed-off-by: Girjesh Rajoria