glusterfs.git/tests/bugs/bitrot, branch release-8

feature/changelog: Avoid thread creation if xlator is not enabled

2020-02-09T12:42:56+00:00

Problem:
Changelog creates threads even if the changelog is not enabled

Background:
Changelog xlator broadly does two things
  1. Journalling - Cosumers are geo-rep and glusterfind
  2. Event Notification for registered events like (open, release etc) -
     Consumers are bitrot, geo-rep

The existing option "changelog.changelog" controls journalling and
there is no option to control event notification and is enabled by
default. So when bitrot/geo-rep is not enabled on the volume, threads
and resources(rpc and rbuf) related to event notifications consumes
resources and cpu cycle which is unnecessary.

Solution:
The solution is to have two different options as below.
 1. changelog-notification : Event notifications
 2. changelog : Journalling

This patch introduces the option "changelog-notification" which is
not exposed to user. When either bitrot or changelog (journalling)
is enabled, it internally enbales 'changelog-notification'. But
once the 'changelog-notification' is enabled, it will not be disabled
for the life time of the brick process even after bitrot and changelog
is disabled. As of now, rpc resource cleanup has lot of races and is
difficult to cleanup cleanly. If allowed, it leads to memory leaks
and crashes on enable/disable of bitrot or changelog (journal) in a
loop. Hence to be safer, the event notification is not disabled within
lifetime of process once enabled.

Change-Id: Ifd00286e0966049e8eb9f21567fe407cf11bb02a
Updates: #475
Signed-off-by: Mohit Agrawal

features/bitrot: add check for corrupted object in f{stat}

2016-01-10T12:43:28+00:00

Check for corrupted objects is done bt bitrot stub component
for data operations and such fops are denied processing by
returning EIO. These checks were not done for operations such
as get/set extended attribute, stat and the likes - IOW, stub
only blocked pure data operations.

However, its necessary to have these checks for certain other
fops, most importantly stat (and fstat). This is due to the
fact that clients could possibly get stale stat information
(such as size, {a,c,m}time) resulting in incorrect operation
of the application that rely on these fields. Note that, the
data that replication would take care of fetching good (and
correct) data, but the staleness of stat information could
lead to data inconsistencies (e.g., rebalance, tier).

Change-Id: I5a22780373b182a13f8d2c4ca6b7d9aa0ffbfca3
BUG: 1296399
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/13120
Reviewed-by: Kotresh HR 
Reviewed-by: mohammed rafi  kc 
Reviewed-by: Raghavendra Bhat 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

features/bit-rot-stub: handle REOPEN_WAIT on forgotten inodes

2015-07-28T09:55:51+00:00

Change-Id: Ia8706ec9b66d78c4e33e7b7faf69f0d113ba68a4
BUG: 1245981
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11729
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Venky Shankar

Revert "tests/bitrot: Induce delay before invoking bitrot subcommands"

2015-06-25T11:44:48+00:00

This reverts commit a615f6c078c76791318c2a58efcc8baef18c25db.

Change-Id: I8b014a99686cd4ee07da9d26bca561b420c8bec7
BUG: 1231617
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11263
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

features/bitrot: fix fd leak in truncate (stub)

2015-06-16T09:22:21+00:00

The need to perform object versioning in the truncate() code path
required an fd to reuse existing versioning infrastructure that's
used by fd based operations (such as writev(), ftruncate(), etc..).

This tempted the use of anonymous fd which was never ever unref()'d
after use resulting in fd and/or memory leak depending on the code
path taken. Versioning resulted in a dangling file descriptor left
open in the filesystem effecting the signing process of a given
object (no release() would be trigerred, hence no signing would be
performed). On the other hand, cases where the object need not be
versioned, the anonymous fd in still ref()'d resulting in memory
leak (NOTE: there's no "dangling" file descriptor in this case).

Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
BUG: 1227996
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11077
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

bitrot/glusterd: gluster volume set command for bitrot should not supported

2015-06-16T07:39:19+00:00

Currently gluster volume set  bitrot succeeds. gluster volume
set command for bitrot is not supported.
Gluster should only accept gluster volume bitrot  * commands.

Change-Id: I5ff4b79f202ad018c76188f19d6311aad0d7c166
BUG: 1229134
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11118
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Tested-by: Atin Mukherjee

features/bitrot: tuanble object signing waiting time value for bitrot

2015-06-15T12:23:46+00:00

 Currently bitrot using 120 second waiting time for object to be signed
 after all fop's released. This signing waiting time value should be tunable.

 Command for changing the signing waiting time will be
 #gluster volume bitrot  signing-time 

Change-Id: I89f3121564c1bbd0825f60aae6147413a2fbd798
BUG: 1228680
Signed-off-by: Gaurav Kumar Garg 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11105

tests/bitrot: Induce delay before invoking bitrot subcommands

2015-06-04T10:51:40+00:00

This is to prevent access to uninitialized variable in reconfigure()
that's currently getting inititlized on CHILD_UP.

[
    NOTE: This is a temporary fix and would not be needed when BZ
           #1226666 is fixed.
]

Change-Id: I8779073fe7f315a380b833ddc248c99958de67d0
BUG: 1226902
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11033
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

bitrot: Volfile generation should not proceed if node doesn't have any brick.

2015-05-10T05:25:15+00:00

glusterd crashes when bitrot is enabled on a distributed volume from a node
which doesn't host a brick.

While generating volfile glusterd should check number of brick on that node. If
node doesn't have any brick then graph generation for bitrot and scrubber should
not proceed further.

Change-Id: I2158113e20e93738cde2a22fd73f0ae6b22aae9e
BUG: 1219784
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/10664
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

tests: fix bitrot spurious failures

2015-05-09T12:58:44+00:00

Change-Id: I342b7f8ec9c37cfd8d4cbd4090319330345bed4c
BUG: 1220016
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/10707
Reviewed-by: Atin Mukherjee 
Tested-by: Vijay Bellur 
Reviewed-by: Vijay Bellur