glusterfs.git/tests/bugs, branch bug-deprecated

tests: move all test-cases into component subdirectories

2015-01-06T11:24:24+00:00

There are around 300 regression tests, 250 being in tests/bugs. Running
partial set of tests/bugs is not easy because this is a flat directory
with almost all tests inside.

It would be valuable to make partial test/bugs easier, and allow the use
of mulitple build hosts for a single commit, each running a subset of
the tests for a quicker result.

Additional changes made:
- correct the include path for *.rc shell libraries and *.py utils
- make the testcases pass checkpatch
- arequal-checksum in afr/self-heal.t was never executed, now it is
- include.rc now complains loudly if it fails to find env.rc

Change-Id: I26ffd067e9853d3be1fd63b2f37d8aa0fd1b4fea
BUG: 1178685
Reported-by: Emmanuel Dreyfus 
Reported-by: Atin Mukherjee 
URL: http://www.gluster.org/pipermail/gluster-devel/2014-December/043414.html
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9353
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/uss: Perform NULL check on @name in svc_getxattr

2015-01-02T13:10:12+00:00

LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.

FIX:
Add the necessary NULL check.

Change-Id: I70024d40dc0695648c6d41b423c2665d030e1232
BUG: 1178079
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9378
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Sachin Pandit 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

test: Make gfid-access.py more generic.

2014-12-31T09:20:37+00:00

Few of the hard coded values, uid, gid and file permissions
are made as arguments to make the script more generic.
Also fixes the permission issue which was hard coded
as integer instead of octal.

Change-Id: Icec700770de2b7cae00e02f783d072860e6d5e2b
BUG: 1176934
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9366
Tested-by: Gluster Build System 
Reviewed-by: Aravinda VK 
Reviewed-by: Vijay Bellur

quota: For a rename operation, do quota_check_limit only till the

2014-12-27T13:52:07+00:00

common ancestor of src and dst file

Example:
set quota limit set to 1GB on /
create a file /a1/b1/file1 of 600MB
mv /a1/b1/file1 /a1/b1/file2
This rename fails as it takes delta into account which sums up to 1.2BG.
Though we are not creating new file, we still get quota exceeded error.
So quota enforce should happen only till b1.

Similarly:
mv /a/b/c/file /a/b/x/y/file
quota enforce should happen only till dir 'b'

Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
BUG: 1153964
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/8940
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3

2014-12-23T04:14:14+00:00

In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.

We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.

Solution is to maintain a per transaction local xaction_peers list for every
syncop.

Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.

Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.

Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1173414
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

features/snapview-client: handle readdir requests differently for samba

2014-12-10T04:27:33+00:00

* For samba export, the entry point is also added to the readdir response.

Change-Id: I825c017e0f16db1f1890bb56e086f36e6558a1c2
BUG: 1168875
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9218
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

uss/gluster: Send success on parent lookup of entry-point

2014-12-05T11:22:20+00:00

When a lookup sent to snapview-server for entry-point directory
protocol server first tries to resolve gfid of a parent directory.

looking up the parent gfid from a latest snapshot can fail if the
volume is a restored volume. As this gfid is already looked-up by
snapview-client, we can return success for the parent gfid.

Change-Id: Ic9b20561ef79b93032f07c3a81eae54a94e1747b
BUG: 1162498
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9229
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Vijay Bellur

USS : fill proper uid and gid during a access call from nfs

2014-12-01T16:04:06+00:00

Problem : when an user tries to access a file/folder for which
he does not have a proper permission required then fuse gives out
a proper error "Permission denied", but nfs does not give out that
error, rather he can access the file/folder. The reason being uid and
gid of call frame stack takes a default value of uid and gid which
point to root permission.

Solution : Set a proper uid and gid during a access call from nfs

Change-Id: Ib060706fde66ec7e60f242fab1f3e59122ed2245
BUG: 1167580
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9194
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd/uss: if snapd is not running, return success from glusterd_handle_snapd_option

2014-12-01T07:05:25+00:00

glusterd_handle_snapd_option was returning failure if snapd is not running
because of which gluster commands were failing.

Change-Id: I22286f4ecf28b57dfb6fb8ceb52ca8bdc66aec5d
BUG: 1168803
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9206
Reviewed-by: Kaushal M 
Reviewed-by: Avra Sengupta 
Tested-by: Gluster Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

Regression test portability: batch of bugs (volume 2)

2014-11-26T12:18:47+00:00

Fix various regression test portability in tests/bugs.

bug-861542.t
- Avoid syntax specific to GNU sed.

bug-860663.t
- Command argument length is system dependent, and specifying 1000 file
  path may overflow it. Use a C program to do the job in a portable and
  efficient way.
- Add a test that we created the specified amount of files.

bug-858242.c, bug-808400-fcntl.c, bug-808400-flock.c
- fstat64() is Linux-specific. Define it as fstat for other systems.

bug-823081.t
- Use portable tail -n instead of tail --lines

In many tests:
- Do not assume python interpreter name. Use $PYTHON as defined
  in env.rc by configure.

utils/libcxattr.py
- If python version is 2.6 or higher, use a portable mechanism to
  recover errno. The original version is retained for python version
  2.5 and earlier but it only works on Linux.

BUG: 1129939
Change-Id: If2fea1ffec5cc6ab2de426fb200e884450afe61b
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9097
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur