glusterfs.git/tests, branch bug-deprecated

cluster/ec: Handle internal xattr get/set

2015-01-09T05:55:37+00:00

Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.

Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.

Change-Id: I39cec96ae12826b506b496fda7da74201015fd75
BUG: 1178688
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9385
Tested-by: Gluster Build System 
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Emmanuel Dreyfus 
Reviewed-by: Xavier Hernandez

test : removing quota-anon-fd-nfs.t for time being.

2015-01-07T06:19:45+00:00

I am removing quota-anon-fd-nfs.t for time being as it is causing
lots of regression failure. Meanwhile I will be working in parallel
to find out the root cause for this spurious failure in another patch
(http://review.gluster.org/#/c/9381/). I'll revert this patch once a proper fix is found.

Change-Id: I0ef205241219ed3210d58d2b487f1b00292115f0
BUG: 1163543
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9390
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

tests: move all test-cases into component subdirectories

2015-01-06T11:24:24+00:00

There are around 300 regression tests, 250 being in tests/bugs. Running
partial set of tests/bugs is not easy because this is a flat directory
with almost all tests inside.

It would be valuable to make partial test/bugs easier, and allow the use
of mulitple build hosts for a single commit, each running a subset of
the tests for a quicker result.

Additional changes made:
- correct the include path for *.rc shell libraries and *.py utils
- make the testcases pass checkpatch
- arequal-checksum in afr/self-heal.t was never executed, now it is
- include.rc now complains loudly if it fails to find env.rc

Change-Id: I26ffd067e9853d3be1fd63b2f37d8aa0fd1b4fea
BUG: 1178685
Reported-by: Emmanuel Dreyfus 
Reported-by: Atin Mukherjee 
URL: http://www.gluster.org/pipermail/gluster-devel/2014-December/043414.html
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9353
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

tests: return non-zero value instead of exit in functions within the test run

2015-01-02T15:21:14+00:00

using 'exit 1' would terminate the test script which means cleanup
will never get triggered for that test run which is incorrect. 
Instead use 'return 1'.

Change-Id: I48c36cff4b2ddfcc2bd8ceb85484720161fe58f0
BUG: 1163543
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9333
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

features/uss: Perform NULL check on @name in svc_getxattr

2015-01-02T13:10:12+00:00

LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.

FIX:
Add the necessary NULL check.

Change-Id: I70024d40dc0695648c6d41b423c2665d030e1232
BUG: 1178079
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9378
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Sachin Pandit 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

test: Make gfid-access.py more generic.

2014-12-31T09:20:37+00:00

Few of the hard coded values, uid, gid and file permissions
are made as arguments to make the script more generic.
Also fixes the permission issue which was hard coded
as integer instead of octal.

Change-Id: Icec700770de2b7cae00e02f783d072860e6d5e2b
BUG: 1176934
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9366
Tested-by: Gluster Build System 
Reviewed-by: Aravinda VK 
Reviewed-by: Vijay Bellur

quota: For a rename operation, do quota_check_limit only till the

2014-12-27T13:52:07+00:00

common ancestor of src and dst file

Example:
set quota limit set to 1GB on /
create a file /a1/b1/file1 of 600MB
mv /a1/b1/file1 /a1/b1/file2
This rename fails as it takes delta into account which sums up to 1.2BG.
Though we are not creating new file, we still get quota exceeded error.
So quota enforce should happen only till b1.

Similarly:
mv /a/b/c/file /a/b/x/y/file
quota enforce should happen only till dir 'b'

Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
BUG: 1153964
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/8940
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

cluster/afr : Change in volume heal info command

2014-12-23T15:09:23+00:00

	gluster volume heal  info command
will now also display if the files listed (in the output
of the command) are in split-brain or possibly being
healed.

This patch also fixes build warning that occurs.
Change-Id: I1fc92e62137f23b2b9ddf6e05819cee6230741d1
BUG: 1163804
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/9119
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3

2014-12-23T04:14:14+00:00

In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.

We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.

Solution is to maintain a per transaction local xaction_peers list for every
syncop.

Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.

Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.

Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1173414
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

Regression test portability: ec.t

2014-12-17T17:14:07+00:00

This test unmount/remount the filesystem to invalidate cache,
but this leads to timing problems on NetBSD. We can work them
around without sleeping by remounting on another mount point.

BUG: 1129939
Change-Id: I10b3183e5e715053de162a6980af188710b607bb
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9285
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez