glusterfs.git/tests, branch v3.5.8

nfs: a unix-domain-socket should not be created as fifo

2015-07-23T12:59:20+00:00

Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244118
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11710
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

nfs: make it possible to disable nfs.mount-rmtab

2015-07-07T16:11:58+00:00

When there are many NFS-clients doing very often mount/unmount actions,
the updating of the 'rmtab' can become a bottleneck and cause delays. In
these situations, the output of 'showmount' may be less important than
the responsiveness of the (un)mounting.

By setting 'nfs.mount-rmtab' to the value "/-", the cache file is not
updated anymore, and the entries are only kept in memory.

Cherry picked from commit 40407afb529f6e5fa2f79e9778c2f527122d75eb:
> Cherry picked from commit 331ef6e1a86bfc0a93f8a9dec6ad35c417873849:
>> BUG: 1169317
>> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
>> Reported-by: Cyril Peponnet 
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/9223
>> Tested-by: Gluster Build System 
>> Reviewed-by: soumya k 
>> Reviewed-by: jiffin tony Thottan 
>> Reviewed-by: Kaleb KEITHLEY 
>
> This change also contains the fixes to the test-case from:
>>
>> nfs: fix spurious failure in bug-1166862.t
>>
>> In some environments, "showmount" could return an NFS-client that does
>> not start with "1". This would cause the test-case to fail. The check is
>> incorrect, the number of lines should get counted instead.
>>
>> Also moving the test-case to the .../nfs/... subdirectory.
>>
>> Cherry picked from commit ee9b35a780607daddc2832b9af5ed6bf414aebc0:
>> BUG: 1166862
>> Change-Id: Ic03aa8145ca57d78aea01564466e924b03bb302a
>> Signed-off-by: Niels de Vos 
>> Reviewed-on: http://review.gluster.org/10419
>> Tested-by: Gluster Build System 
>> Reviewed-by: Vijay Bellur 
>>
>
> Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
> BUG: 1215385
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10379
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

GLUSTERD_WORKDIR has been added to tests/include.rc and is not
configurable through ./configure like on newer branches. It is not
suitable to change the GlusterD working directory in an update for a
stable release.

Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
BUG: 1166862
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11336
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaleb KEITHLEY

afr: Don't write to sparse regions of sink.

2015-02-12T12:09:13+00:00

Corresponding afr-v2 fix: http://review.gluster.org/#/c/9480/

Problem:
When data-self-heal-algorithm is set to 'full', shd just reads from
source and writes to sink. If source file happened to be sparse (VM
workloads), we end up actually writing 0s to the corresponding regions
of the sink causing it to lose its sparseness.

Fix:
If the source file is sparse, and the data read from source and sink are
both zeros for that range, skip writing that range to the sink.

Change-Id: Iade957e4173c87e45a2881df501ba2ad3eb1a172
BUG: 1190633
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9611
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/marker: Filter internal xattrs in lookup

2015-02-12T12:08:12+00:00

        Backport of http://review.gluster.com/9061

Afr should ignore quota-size-key as part of self-heal
but should heal quota-limit key.

BUG: 1162230
Change-Id: I639cfabbc44468da29914096afc7e2eca1ff1292
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9091
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Raghavendra G 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Niels de Vos

tests: spurious failure fix for quota-anon-fd-nfs.t

2014-11-27T14:19:21+00:00

Cherry picked from commit 463d3e379d63e37764bc190be6c2f790769bea58:
> Change-Id: I4f7ee68c514d8d322e25cf74167f288a8b6f8164
> BUG: 1163543
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/9108
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Also include the usage() function in the test, and some other
improvements introduced with commit 27628b7b.

BUG: 1168173
Change-Id: I4153af903178893361157af2ab06ce4989dd849b
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9200
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

cluster/afr: Fix xattr heal comparison checks

2014-11-13T19:53:07+00:00

        Backport of part of the fixes in http://review.gluster.org/8558

Problem:
While implementing list-xattr based meta-data self-heal for afr-v2 we found
2 issues, with afr-v1's implementation.

1) change in QUOTA_SIZE_KEY xattr value can trigger spurious  metadata
   self-heal.
2) xattr comparison function that is implemented for afr-v1 checks if the
   number of xattrs in both the xattrs is same and then checks that the xattrs
   present in brick-1's response are present and equal. But what we observed me
   was that count also contains the gluster internal/virtual xattrs where as
   the compare function should only compare on-disk external xattrs that can be
   healed. So the correct implementation should check that the external xattrs
   in first brick's response are present in second brick's response and vide
   versa.

Fix:
This patch is partly backported from afr-v2's implementation. Will be providing
the links where necessary.

1) Added QUOTA_SIZE_KEY xattr to the list of xattrs that need to be ignored.
   (http://review.gluster.org/#/c/8558/10/xlators/cluster/afr/src/afr-common.c
   line: 1155)
2) For xattrs to be equal, check all keys in xattr-dict1 are in xattr-dict2 and
   equal and vice versa.
   (http://review.gluster.org/#/c/8558/10/xlators/cluster/afr/src/afr-common.c
   line: 1195)

Change-Id: I63aa74858c6f608b98d1fe425b3fa56f925bb5b3
BUG: 1162230
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9090
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

socket: disallow CBC cipher modes

2014-10-28T15:49:41+00:00

This is related to CVE-2014-3566 a.k.a. POODLE.

	http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3566

POODLE is specific to CBC cipher modes in SSLv3.  Because there is no
way to prevent SSLv3 fallback on a system with an unpatched version of
OpenSSL, users of such systems can only be protected by disallowing CBC
modes.  The default cipher-mode specification in our code has been
changed accordingly.  Users can still set their own cipher modes if they
wish.  To support them, the ssl-authz.t test script provides an example
of how to combine the CBC exclusion with other criteria in a script.

Cherry picked from commit 378a0a19d95e552220d71b13be685f4772c576cd:
> Change-Id: Ib1fa547082fbb7de9df94ffd182b1800d6e354e5
> BUG: 1155328
> Signed-off-by: Jeff Darcy 
> Reviewed-on: http://review.gluster.org/8962
> Tested-by: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Vijay Bellur 

ssl-auth.t has been modified to not set the auth.ssl-allow option. This
option is not available in the 3.5 branch.

Change-Id: Ib1fa547082fbb7de9df94ffd182b1800d6e354e5
BUG: 1157661
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8979
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

glusterd/quota: Heal pgfid xattr on existing data when the quota is

2014-10-20T16:13:34+00:00

enable

        Backport of: http://review.gluster.org/8878

The pgfid extended attributes are used to construct the ancestry path
(from the file to the volume root) for nameless lookups on files.
As NFS relies on nameless lookups heavily, quota enforcement through NFS
would be inconsistent if quota were to be enabled on a volume with
existing data.

Solution is to heal the pgfid extended attributes as a part of lookup
perfomed by quota-crawl process. In a posix lookup check for pgfid xattr
and if it is missing set the xattr.

Change-Id: I956128907aa1d975cd5719ed3ab2f4f9b37d4c31
BUG: 1153900
Signed-off-by: vmallika 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8938
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

mount/fuse: Handle fd resolution failures

2014-10-01T10:44:28+00:00

        Backport of http://review.gluster.org/8402

Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.

Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
  to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
  fop right away.
- loc resolution failures are already handled in the corresponding
  fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE

BUG: 1136835
Change-Id: I5074f7a9b177c54051ef37a4f73de7f8d1fcc5b7
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8595
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

cluster/dht: Fix dht_access treating directory like files

2014-09-29T10:50:14+00:00

When the cluster topology changes due to add-brick, all sub
volumes of DHT will not contain the directories till a rebalance
is completed. Till the rebalance is run, if a caller bypasses
lookup and calls access due to saved/cached inode information
(like NFS server does) then, dht_access misreads the error
(ESTALE/ENOENT) from the new subvolumes and incorrectly tries
to handle the inode as a file. This results in the directories
in memory state in DHT to be corrupted and not heal even post
a rebalance.

This commit fixes the problem in dht_access thereby preventing
DHT from misrepresenting a directory as a file in the case
presented above.

Change-Id: Idcdaa3837db71c8fe0a40ec0084a6c3dbe27e772
BUG: 1140338
Signed-off-by: Shyam 
Reviewed-on: http://review.gluster.org/8462
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
(cherry picked from commit 6630fff4812f4e8617336b98d8e3ac35976e5990)
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/8721
Reviewed-by: Niels de Vos