glusterfs.git/tests, branch v3.7.1

tiering/nfs: duplication of nodes in client graph

2015-06-01T04:40:47+00:00

        Back port of http://review.gluster.org/10820

When creating client volfiles, xlator tier-dht will
be loaded for each volume. So for services like nfs
have one or more volumes . So for each volume in the
graph a tier-dht xlator will be created. So the graph
parser will fail because of the redundant node in
graph.

By this change tier-dht will be renamed as volname-tier-dht

 >Change-Id: I3c9b9c23ddcb853773a8a02be7fd8a5d09a7f972
 >BUG: 1222840
 >Signed-off-by: Mohammed Rafi KC 
 >Reviewed-on: http://review.gluster.org/10820
 >Reviewed-by: Atin Mukherjee 
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System
 >Reviewed-by: Kaushal M 

Change-Id: I5629d48d4d1dbec8790f75e2fee66729aa2f6eed
BUG: 1226029
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10981
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Joseph Fernandes
Reviewed-by: Kaushal M

featuress/changelog: On snapshot, notify irrespective of failures

2015-06-01T02:39:24+00:00

During snapshot, changelog barrier is enabled and a
explicit rollover of changelog is initiated. During
rollover of changelog, if any error or changelog is
empty, the notification was not sent to reconfigure
and hence snapshot was failing because of timeout.
This patch addresses it by sending notification
irrespective of failures and sends error if any
back to barrier.

BUG: 1225543
Change-Id: I971ef3bdc63bb50bda0b655e55cd814e44254ba9
Reviewed-On: http://review.gluster.org/10951
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/10988
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

features/bit-rot-stub: implement mknod fop

2015-06-01T02:33:21+00:00

    Backport of http://review.gluster.org/10790

With the absence of mknod() fop implementation in bitrot stub,
further operations that trigger versioning resulted in crashes
as they expect the inode context to be valid. Therefore, this
patch implements mknod() following similar simantics to fops
such as create().

Furthermore, bitrot stub test C program is fixed to stop lying
and validate obj versions according to the versioning protocol.

Change-Id: If76f252577445d1851d6c13c7e969e864e2183ef
BUG: 1226139
Original-Author: Raghavendra Bhat 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/10987
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

tests : fix spurious failure in bug-973073.t

2015-05-31T18:29:29+00:00

Backport of http://review.gluster.org/11006

remove_brick_completed needs the same fix as 02c04579

Change-Id: I1a65f9095e4b01e6bb014440fc89696a4eebf8ca
BUG: 1226629
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11006
Reviewed-by: Niels de Vos 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Shyamsundar Ranganathan 
(cherry picked from commit 8edc416f05d48560a387de9e3eb55a3c4087f23f)
Reviewed-on: http://review.gluster.org/11017
Tested-by: Gluster Build System

tests/uss.t: wait for connection to complete before accessing a file in snapshot

2015-05-31T04:06:52+00:00

Change-Id: I82d0cb378d006777d5a304afe8d5be15e92c7245
BUG: 1224894
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/10915
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/11013
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System

afr: allow readdir to proceed for directories in split-brain

2015-05-29T12:29:27+00:00

Problem:
afr_read_txn() bails out if read_subvol==-1. This meant that for
directories that were in entry split-brain, FOPS like readdir, access,
stat etc were not allowed.

Fix:
Except for getxattr, all other FOPS are wound on the first up child
of afr.

Change-Id: Iacec8fbb1e75c4d2094baa304f62331c81a6f670
BUG: 1218863
BUG:
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/10776
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anuradha Talur 
(cherry picked from commit 49b428433a03fcf709fdc8c08603b4cf02198e0a)
Reviewed-on: http://review.gluster.org/10962
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

Quota: fix testcases not to send parallel writes for accurate

2015-05-29T06:29:07+00:00

 quota enforcement

This is a backport of http://review.gluster.org/#/c/10878

> Currently quota enforcer doesn't consider parallel writes
> and allows quota to exceed limit where there are high rate
> of parallel writes. Bug# 1223658 tracks the issue.
>
> This patch fixes the spurious failures by not sending
> parallel writes.
> Using O_SYNC and O_APPEND flags and block size
> not more that 256k (For higher block size NFS client
> splits the block into 256k chinks and does parallel writes)
>
> Change-Id: I297c164b030cecb87ce5b494c02b09e8b073b276
> BUG: 1223798
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10878
> Tested-by: NetBSD Build System
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I78b6250eb0b3fbbbab1d4348d4e81d6292c6c6bb
BUG: 1224894
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10910
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Pranith Kumar Karampuri

posix: Do not update unmodified xattr in (f)xattrop

2015-05-29T05:54:34+00:00

        Backport of http://review.gluster.org/10886

If a (f)xattrop is issued with a value that only contains 0's,
then we don't modify or create the extended attribute. This
is useful to avoid ctime modifications when the only purpose
of the xattrop was to get the current value.

Change-Id: Ia62494e9009962e683c8276783f671da17a8b03a
BUG: 1225320
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/10928
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/ec: Fix all EIO errors in EC

2015-05-28T11:12:06+00:00

        Backport of http://review.gluster.org/10770
        Backport of http://review.gluster.org/10806
        Backport of http://review.gluster.org/10787
        Backport of http://review.gluster.org/10868
        Backport of http://review.gluster.com/10852

 - When a blocking lock is requested, lock request is succeeded even when
ec->fragment number of locks are acquired successfully in non-blocking locking
phase. This will lead to fop succeeding only on the bricks where the locks are
acquired, leading to the necessity of self-heals. To prevent these un-necessary
self-heals, if the remaining locks fail with EAGAIN in non-blocking lock phase
try blocking locking phase instead.

 -  Handle lookup failures while op in progress

 - cluster/ec: Correctly cleanup delayed locks
When a delayed lock is pending, a graph switch doesn't correctly
terminate it. This means that the update of version and size xattrs
is lost, causing EIO errors. This patch handles GF_EVENT_PARENT_DOWN
event to correctly finish pending udpdates before completing the
graph switch.

 - Fix use after free crash
ec_heal creates ec_fop_data but doesn't run ec_manager. ec_fop_data_allocate
adds this fop to ec->pending_fops, because ec_manager is not run on this heal
fop it is never removed from ec->pending_fops. When it is accessed after free
it leads to crash. It is better to not to add HEAL fops to ec->pending_fops
because we don't want graph switch to hang the mount because of a BIG
file/directory heal.

- Forced unlock when lock contention is detected
EC uses an eager lock mechanism to optimize multiple read/write
requests on the same entry or inode. This increases performance
but can have adverse results when other clients try to access the
same entry/inode. To solve this, this patch adds a functionality
to detect when this happens and force an earlier release to not
block other clients.

The method consists on requesting GF_GLUSTERFS_INODELK_COUNT and
GF_GLUSTERFS_ENTRYLK_COUNT for all fops that take a lock. When this
count is greater than one, the lock is marked to be released. All
fops already waiting for this lock will be executed normally before
releasing the lock, but new requests that also require it will be
blocked and restarted after the lock has been released and reacquired
again.

Another problem was that some operations did correctly lock the
parent of an entry when needed, but got the size and version xattrs
from the entry instead of the parent.

This patch solves this problem by binding all queries of size and
version to each lock and replacing all entrylk calls by inodelk ones
to remove concurrent updates on directory metadata.  This also allows
rename to correctly update source and destination directories.

BUG: 1225279
Change-Id: I02a6084b138dd38e018a462347cd9ce38610c7ef
Reviewed-on: http://review.gluster.org/10926
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

tests: Await for graph switch before testing open fop count

2015-05-28T09:34:28+00:00

In performance/open-behind.t, a test for open fop reaching the brick is done by
switching off open-behind and performing a read operation. If the read operation
is performed before a graph switch, the read happens on the old graph and hence
open does not get accounted in the brick.

To overcome this EXPECT_WITHIN 10 seconds has now been added to ensure that a
graph switch has happened. The read operation happens subsequently after the
graph switch.

Cleaned up a "No volumes present" message from stderr while doing this.

Change-Id: I05f7cbfd1ce51782f5ab778468a980d3732509a2
BUG: 1225077
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/10941
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Krishnan Parthasarathi