glusterfs.git/tests, branch v3.7.2

features/bitrot: fix fd leak in truncate (stub)

2015-06-19T08:37:54+00:00

    Backport of http://review.gluster.org/#/c/11077

The need to perform object versioning in the truncate() code path
required an fd to reuse existing versioning infrastructure that's
used by fd based operations (such as writev(), ftruncate(), etc..).

This tempted the use of anonymous fd which was never ever unref()'d
after use resulting in fd and/or memory leak depending on the code
path taken. Versioning resulted in a dangling file descriptor left
open in the filesystem effecting the signing process of a given
object (no release() would be trigerred, hence no signing would be
performed). On the other hand, cases where the object need not be
versioned, the anonymous fd in still ref()'d resulting in memory
leak (NOTE: there's no "dangling" file descriptor in this case).

Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
BUG: 1232179
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11300
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

quota: fix double accounting with rename operation

2015-06-19T05:33:30+00:00

This is a backport of http://review.gluster.org/#/c/11264/

> When a rename operation is performed, we are renaming
> the file first and performing remove-xattr when reducing
> the contri size from parents.
> This remove-xattr fails as the file is alreday renamed,
> this failure causes reduce-parent-size to abort resulting
> in double quota accounting
>
> This patch fixes the problem. We don't need to perform remove-xattr
> operation on a file when performing reduce-parent-size txn as this
> will be alreday done before starting reduce-parent-size txn
>
> Change-Id: If86e3dbb0233f6deaaa90bee72cb0ec1689c7325
> BUG: 1232572
> Signed-off-by: vmallika 

Change-Id: I7b12962d731ce9acf3ac78a99b2c23491722b78a
BUG: 1233117
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11312
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

bitrot/glusterd: gluster volume set command for bitrot should not supported

2015-06-18T06:53:02+00:00

Currently gluster volume set  bitrot succeeds. gluster volume
set command for bitrot is not supported.
Gluster should only accept gluster volume bitrot  * commands.

Change-Id: I5ff4b79f202ad018c76188f19d6311aad0d7c166
BUG: 1232589
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11118
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Tested-by: Atin Mukherjee 
(cherry picked from commit 1ac3d28d8dde6360550c80a10d8add572937be16)
Reviewed-on: http://review.gluster.org/11265

tests: fix spurious failure in bug-857330/xml.t

2015-06-17T22:31:28+00:00

Backport of http://review.gluster.org/11054

get-task-status () used to always return 0 *until and unless* the CLI command
itself fails which is unlikely. However if the CLI command fails due to some
reason EXPECT_WITHIN will abort.

Change-Id: Ibe54dcdccc26b3ee003677fc3516cfed98b5c06f
BUG: 1232602
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11054
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11266
Reviewed-by: Vijay Bellur

features/bitrot: tuanble object signing waiting time value for bitrot

2015-06-17T16:38:59+00:00

 Currently bitrot using 120 second waiting time for object to be signed
 after all fop's released. This signing waiting time value should be tunable.

 Command for changing the signing waiting time will be
 #gluster volume bitrot  signing-time 

Change-Id: I89f3121564c1bbd0825f60aae6147413a2fbd798
BUG: 1231832
Signed-off-by: Gaurav Kumar Garg 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11105
(cherry picked from commit 554fa0c1315d0b4b78ba35a2d332d7ac0fd07d48)
Reviewed-on: http://review.gluster.org/11235
Tested-by: Gluster Build System

tier/volume set: Validate volume set option for tier

2015-06-17T05:13:18+00:00

Volume set option related to tier volume can only be set
for tier volume, also currently all volume set i for tier
option accepts a non-negative integer. This patch validate
both condition.

Back port of:
>Change-Id: I3611af048ff4ab193544058cace8db205ea92336
>BUG: 1216960
>Signed-off-by: Mohammed Rafi KC 
>Signed-off-by: Dan Lambright 
>Reviewed-on: http://review.gluster.org/10751
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System 
>Reviewed-by: Joseph Fernandes


(cherry picked from commit f6a062044a3447bea5bf0fcf21a3f85c00fb6c7d)

Change-Id: Ic6081f0ce7ae7effac69ba192bd35c8d382a11d5
BUG: 1230560
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/11173
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes

glusterd: subvol_count value for replicate volume should be calculate correctly

2015-06-16T12:20:51+00:00

glusterd was crashing while trying to remove bricks from replica set
after shrinking nx3 replica to nx2 replica to nx1 replica.

This is because volinfo->subvol_count is calculating value from old
replica count value.

Change-Id: I1084a71e29c9cfa1cd85bdb4e82b943b1dc44372
BUG: 1231646
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11165
Reviewed-by: Atin Mukherjee 
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Krishnan Parthasarathi 
(cherry picked from commit 3fb18451311c34aeced1054472b6f81fc13dd679)
Reviewed-on: http://review.gluster.org/11224

cluster/ec: Prevent Null dereference in dht-rename

2015-06-16T08:29:43+00:00

        Backport of http://review.gluster.com/11178

BUG: 1230653
Change-Id: I708d4d84b1341fb7cb515808836721735dc63f14
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11179
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

Upcall/cache-invalidation: Ignore fops with frame->root->client not set

2015-06-09T18:49:04+00:00

Server-side internally generated fops like 'quota/marker' will
not have any client associated with the frame. Hence we need a
check for clients to be valid before processing for upcall cache
invalidation. Also fixed an issue with initializing reaper-thread.

Added a testcase to test the fix.

Change-Id: If7419b98aca383f4b80711c10fef2e0b32498c57
BUG: 1221941
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10909
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11141
Tested-by: NetBSD Build System

snapshot: Fix finding brick mount path logic

2015-06-09T14:20:06+00:00

    Backport of http://review.gluster.org/#/c/11060/

Previously while finding brick mount paths
of snap volume's bricks, we were taking brick order
into consideration. This logic fails when a brick is
removed or a tier is added.

Hence modifying the logic to look for the first
occurence of the word "brick" in the brick path.
From there we iterate till we find a '/'. The string
till the first '/' after we encounter the word brick
is the brick mount path.

Change-Id: Ic85983c4e975e701cdfd4e13f8e276ac391a3e49
BUG: 1228592
Signed-off-by: Avra Sengupta 
(cherry picked from commit bf3a6dcdf3c8a8a64e7c864b56c4d9be60fca8e6)
Reviewed-on: http://review.gluster.org/11100
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Krishnan Parthasarathi