glusterfs.git/xlators/cluster/afr, branch v3.4.0qa4

afr: send unique dict_t instances to replicas in self-heal fxattrop

2012-11-29T17:34:14+00:00

afr_sh_data_fxattrop() currently allocates and sends a single xattr
dict_t instance to each replica. The callback codepath references
the returned object in the self-heal in-memory state for the
particular replica. If storage/posix is in the same address-space
(i.e., running a single glusterfs client with a fuse->afr->posix
graph), the same object is modified and returned for each child,
causing corrupted in-memory state and afr xattrs.

Allocate and send independent xattr dict_t's for each replica. This
allows self-heal to work correctly in a single address-space
graph.

BUG: 868478
Change-Id: I42832e85b5d1abb6098c28944c717e129300109e
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4149
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

afr: handle short writes in afr_writev_wind and self-heal to avoid corruption

2012-11-29T17:00:28+00:00

The current failure to handle short writes on writev fops leaves
us open to file corruption. A short write on a user request is
ignored and leaves replicas in an inconsistent state. A short write
during a self-heal is ignored and incorrectly marks the files as
consistent if the heal completes.

Modify user writev handling to return the best case return value
from each of the replicas. Short writes that occur relative to this
value are marked as failed and will require a heal. Modify
self-heal to set an error on a short write and abort the heal.

BUG: 853690
Change-Id: I18b30f58702326249230eeebb361b29e40b535f5
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4150
Reviewed-by: Jeff Darcy 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

cluster/afr: handle GF_XATTR_LOCKINFO_KEY appropriately.

2012-11-28T06:43:18+00:00

values from all children need to be aggregated into a dictionary
and serialized buffer of this aggregated dictionary has to be
the value of GF_XATTR_LOCKINFO_KEY in the dict sent as a result of
fgetxattr.

Change-Id: Ie877f7c637c07feaee4c44d7ef86aa967a17b7e7
BUG: 808400
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4121
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

replicate: don't stop checking xattrs because one was absent

2012-11-27T05:34:33+00:00

The functional issue is described by the subject line.  This patch also
addresses several efficiency/structure issues, such as...

* Calling dict_set_ptr once for each txn type, instead of once overall.

* Calling afr_index_for_transaction_type once per iteration instead of
  once per call (or better yet zero since the conversion is unnecessary).

* Implementation of inner functions in a different file than their one
  caller, creating a spurious header-file dependency.

Change-Id: I29e0df906a820533b66b9ced73e015dfe77267d2
BUG: 865825
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4070
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anand Avati

Cluster/afr: Fix output for gluster volume heal vn info healed

2012-11-26T09:04:52+00:00

Problem:
Whenever gluster volume heal vol full command is executed, the entries
stored in the circual buffer for sh->healed are added in the dictionary
in the _crawl_post_sh_action function irrespective of whether actual self heal
(due to non-zero values in chage log) takes place or not.

Fix:
Value of key (actual-sh-done) will be set to 1 whenever self heal takes place
due to non-zero change log values and if for some FOP self heal daemon finds
that no self heal required after examining the pending matrix, the value will
be 0.

Change-Id: I11fd0b9ee76759af17c5bca6bfafbaf66bcaacbc
BUG: 863068
Signed-off-by: Venkatesh Somyajula 
Reviewed-on: http://review.gluster.org/4181
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: check transaction type for eager-lock after it is set

2012-11-21T20:03:37+00:00

Problem:
Eager locking lk-owner decision is taken before transaction
type is set. Default transaction type is DATA so all transactions
are treated as DATA transactions at the time of eager-locking
decision.

Fix:
Move the code that takes lk-owner decision after the transaction
type is set.

Test:
Checked that the transaction type is set properly in gdb at
the time of the lk-owner decision.

Change-Id: I7607c7ff4f88c7ced5416a1cddb6586cf45d88f9
BUG: 861335
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4220
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr : Edited log message in afr_sh_entry_expunge_entry_cbk

2012-10-12T16:17:40+00:00

Change-Id: I9f7562d28c8bc798552c403164397f929a7bd1e7
BUG: 860246
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4052
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Preventing client crashing as the callings of GF_CALLOC has been failed.

2012-10-12T03:59:45+00:00

As the callings of GF_CALLOC can seldom come to a failure, glusterfs client
will crash due to segment fault. We should have returned once the variables
of transaction's local can't be alloced.

Change-Id: Ia3798b8349d832b23c7825e64dbad93ebe29cd1b
BUG: 861335
Signed-off-by: linbaiye 
Reviewed-on: http://review.gluster.org/4005
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

replicate: don't use synctask_new from within a synctask

2012-10-12T01:08:49+00:00

Change-Id: Iebf821ff720c63ab6da4b219d82c7f1d00769992
BUG: 862838
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4032
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anand Avati

cli: Changes and enhancements to XML output

2012-10-11T23:34:16+00:00

This patch contains several xml related changes which fix some bugs and
introduce xml output for commands which were missing it. These include,
* XML output for rebalance & remove-brick status
* XML output for replace-brick
* XML output for 'volume status all' in on xml document
* proper XML output for "volume {create|start|stop|delete}"
* type & status of a volume in 'volume info' is now given as a string as well

This patch also cleans up the '#if (HAVE_LIB_XML)' sections from the code-base,
so that it is not littered around.

Change-Id: I5bb022adf0fedf7e3ead92b4b79bfa02b0b5fef5
BUG: 828131
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3869
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati