glusterfs.git/xlators/cluster/dht/src/dht-rebalance.c, branch v3.5qa2

cluster/dht: Handle Link-info getxattr failure in rebalance

2013-11-26T18:37:41+00:00

When getxattr fails with errno other than ENODATA fail rebalance
on that file. Log the reason for error.

Change-Id: Ia519870b88e6e6dd464d1c0415411aa999f80bc9
BUG: 1032927
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6341
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Vijay Bellur

Have #include for kill(2)

2013-11-18T09:36:45+00:00

BUG: 764655
Change-Id: I4d18c9a6c00cb4696645fcb437398562f00b9d24
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/6284
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

bd: Add BD support to other xlators

2013-11-13T19:38:55+00:00

Make changes to distributed xlator to work with BD xlator. Unlike files,
a block device can't be removed when its opened. So some part of the
code were moved down to avoid this situation. Also before truncating a
BD file its BD_XATTR should be set otherwise truncate will result in
truncating posix file. So file is created with needed BD_XATTR and
truncate is invoked. Also enables BD xlator in stripe volume type.

Change-Id: If127516e261fac5fc5b137e7fe33e100bc92acc0
BUG: 1028672
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/5235
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

distribute: Rebalance should provide even disk space distribution

2013-09-19T16:25:28+00:00

Earlier disk space check had an issue which didn't
provide the needed functionality to avoid migration
when the destination had lesser available space,
scenario we need to avoid is stated below :

During rebalance `migrate-data` - Destination subvol experiences
a `reduction` in 'blocks' of free space, at the same time source
subvol gains certain 'blocks' of free space. A valid check is
necessary here to avoid errorneous move to destination where
the space could be scantily available.

This patch provides a proper fix in place by subtracting
necessary file blocks from destination and adding those blocks
to source.

Change-Id: I9c7840716a4256ef614ffc0fbfd9f2b456ac28c8
BUG: 982919
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/5961
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Anand Avati

cli/glusterd: improve rebalance fix-layout status reporting

2013-09-19T16:22:36+00:00

Problem:
Currenly the CLI rebalance status command output does not indicate the
'type' of rebalance, i.e. whether a full rebalance or only a fix-layout
was carried out.

Fix: After the rebalance status of all peers is received by the
originator glusterd, alter it to reflect the type of rebalance
before passing it on to the CLI process.

Change-Id: I1940ffda0d36e25e5b33c84a0ea210394cc9e1d3
BUG: 1004744
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/5826
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Revert "cluster/distribute: Rebalance should also verify free inodes"

2013-09-18T00:45:25+00:00

This reverts commit 215fea41a96479312a5ab8783c13b30ab9fe00fa

Realized soon after merging, that this patch is actually useless.
Checking for inode utilization on dst relative to src is of no use
because dst is already storing linkfile and inode is already consumed
no matter what. We might as well perform the rebalance and save on an
inode on the src node.

Change-Id: I7b8b8d35d9063a710e1bee1c7c6c7739fcc45ad4
Reviewed-on: http://review.gluster.org/5960
Reviewed-by: Harshavardhana 
Tested-by: Anand Avati

cluster/distribute: Rebalance should also verify free inodes

2013-09-17T23:37:24+00:00

Currently during `MIGRATE_DATA` we never verified about the total
inode usage among new and old bricks. Such checks are available for
disk space usage but it is also needed for inodes during data
migration. Such a check leads to uniform outcome of file distribution
upon rebalance.

Patch provides:

- Check dst_inodes < src_inodes, a friendly `warning` message to
  indicate we have to ignore such an attempt
- Rename __dht_check_free_space() --> __dht_check_free_space_and_inodes()

Change-Id: I7bc4dd8b507883f0fb836300e99f0bb083493f5f
BUG: 982919
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/5948
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Fix non-regular file ownership during rebalance

2013-07-31T10:42:42+00:00

Currently non-regular files were created as root:root, and
their ownership never healed during rebalance process.

Also, in dht_linkfile_attr_heal, we have to heal the linkfiles
as default, as currently linkfiles are created as root:root.

That check existed, as earlier linkfiles were created as
frame->root->uid/gid

Change-Id: I6cd88361b81bdd500e15bc47b623f5db8eec88e9
BUG: 990154
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5434
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

cluster/dht: Treat migration failures due to space constraints as skipped

2013-07-31T06:55:59+00:00

Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)

These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter

Change-Id: I674904d380b5f8300e9ca9e6af557c3d30d6cff4
BUG: 989846
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5399
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Unlink dst file after cleanup during migration

2013-07-12T07:40:31+00:00

If a rename happens during migration, unlink fails. This leads
to stale xattrs, and Sticky bits still being set.

By removing the xattrs and Sticky bits from dst (through fd ops),
the stale link file would be cleaned up eventually (even if unlink
fails on src).

Change-Id: Iec537d021905438327a20e1d811aa06e74034364
BUG: 983399
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5316
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati