glusterfs.git/xlators/cluster/dht/src/tier-common.c, branch release-3.7

tier: Fix unused-but-set-variable warning

2016-03-04T03:44:40+00:00

        Backport of http://review.gluster.org/13591

Change-Id: I20c205849f511acf4797a8a53ea59bfaad60bd35
BUG: 1314548
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/13598
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/tier: Create linkfiles to hardlinks correctly

2016-02-27T18:48:50+00:00

There is a bug in the way hardlinks are handled in tiered volumes.
Ideally, the tier linkto files on the cold tier to files that are
hardlinks to each other on the hot tier, should themselves be
hardlinks of each other. As they are not, they end up being files
with the same gfid but different names for the cold tier dht,
and end up overwriting the cached-subvol information stored in the dht inode-ctx.

> Change-Id: Ic658a316836e6a1729cfea848b7d212674b0edd2
> BUG: 1305277
> Signed-off-by: N Balachandran 
> Reviewed-on: http://review.gluster.org/13391
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Dan Lambright 
> Tested-by: Dan Lambright 
(cherry picked from commit eb362c74db84d95aac07febf0d888bd98b3fb2b9)

Change-Id: I5dd98e6d248619147974a630d7d72e1942a1cc83
BUG: 1311836
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/13517
Smoke: Gluster Build System 
Reviewed-by: mohammed rafi  kc 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

tier/create: store TIER_LINKFILE_GFID in xattr dictionary

2016-02-22T14:54:15+00:00

In tier_create, a new key TIER_LINKFILE_GFID was introduced to
avoid a race in stale linkfile deletion. Storing this key in
xattr dictionary instead of using local->params dictionary.

Because local->params dictionary was also used to create the file
before stale linkfile deletion, that leads posix_create to fail,
trying to set the added key as extended attributes

Back port of>
>Change-Id: I24fecb62b47bee65a1e86103925a67d13304c5df
>BUG: 1290677
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13130
>Tested-by: Gluster Build System 
>Reviewed-by: N Balachandran 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: I301c159ee51c77d3876e30f216d0375d761eb91e
BUG: 1295359
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13410
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Dan Lambright

tier/create: Dynamically allocate gfid memory

2016-02-22T14:53:50+00:00

Currently we are storing the memory as a static pointer.
There is a chance to go that variable in out of scope.
So we should allocate in Dynamic way.

Backport of>
>Change-Id: I096876deb8055ac3a44681599591a0a032bc0c24
>BUG: 1290677
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13102
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: N Balachandran 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: Ibc5cde24db4846ef3152366cdaca81dd1d0e7b21
BUG: 1295359
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13162
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Dan Lambright

tier:delete the linkfile if data file creation fails

2016-02-22T14:53:07+00:00

If we are creating data file in a hot subvolume
then we will create a linkfile in cold subvolume.
Linkfile creation happens first. If linkfile creation
was successful and data file creation failed, then
linkfile in cold subvolume will become stale

This patch will delete the linkfile as well, if data
file creation fails

Also this code duplicates dht_create to make tier_create

backport of>
>Change-Id: I377a90dad47f288e9576c7323b23cf694a91a7a3
>BUG: 1290677
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/12948
>Reviewed-by: N Balachandran 
>Tested-by: NetBSD Build System 
>Reviewed-by: Raghavendra G 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: I3689e8ee387fb6731b4b3a7fe8f8190143482eaa
BUG: 1295359
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13161
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

tier/unlink: symlink failed to unlink

2016-02-22T14:51:34+00:00

during unlink of a file, we will get stat just after
deleting the file, to see if the file is under migration or not

but this stat call will fail for symlink if the actual file
was deleted.

So it is better not to send stat request from client if it is
a symlink as we are not migrating symlink

back port of>
>Change-Id: Idc033b24fa3522b5261e579889d2195b43419682
>BUG: 1293963
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13074
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: Ic53a9ad29722927f44004d2e7289c807c7485df0
BUG: 1295347
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13159
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Dan Lambright

tier:unlink during migration

2016-02-22T14:50:54+00:00

files deleted during promotion were not deleting as the
files are moving from hashed to non-hashed

On deleting a file that is undergoing promotion,
the unlink call is not sent to the dst file as the
hashed subvol == cached subvol. This causes
the file to reappear once the migration is complete.

This patch also fixes a problem with stale linkfile
deleting.

Backport of>
>Change-Id: I4b02a498218c9d8eeaa4556fa4219e91e7fa71e5
>BUG: 1282390
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/12829
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

(cherry picked from commit b5de382afa8c5777e455c7a376fc4f1f01d782d1)

Change-Id: I951adb4d929926bcd646dd7574f7a2d41d57479d
BUG: 1282388
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12991
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

cluster/tier: readdirp to cold tier only

2015-11-24T12:13:53+00:00

It is possible a file would get migrated in the middle
of a readdir operation. If there are four subvolumes A,B,C,D,
and if readdir reads them in order and reaches subvol B,
then, if a file is moved from D to A, it will not be included
in the readdir output.

This phenonema has pre-existed in DHT migration but is more
apparent in tiering.

When a file is moved off the hashed subvolume a T file is created.
For tiering, we will make the cold subvolume the hashed subvolume.
This will ensure the creation of a T file. Readdir will not skip T
files in the tier translator.

Making the cold subvolume the hashed subvolume ensures the T
files created on promotions or creates will be less likely to
fill the volume.

Creates still put the data on the hot subvolume.

This is a backport of 12530

> Change-Id: Ifde557d3d0e94a4570ca9f115adee3db2ee75407
> BUG:  1281598
> Signed-off-by: Dan Lambright 
> Reviewed-on: http://review.gluster.org/12530
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 
> Reviewed-by: N Balachandran 
> Reviewed-by: Raghavendra G 
Signed-off-by: Dan Lambright 

Signed-off-by: Dan Lambright 

Conflicts:
	xlators/cluster/dht/src/tier.c

Change-Id: I5720a4cd04ae5088e5d7d23439b0f90d6bbc6265
BUG: 1283923
Reviewed-on: http://review.gluster.org/12722
Tested-by: NetBSD Build System 
Reviewed-by: N Balachandran 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright