glusterfs.git/xlators/cluster/dht, branch v3.7.0beta1

tier: relax libgfdb required version number

2015-04-28T17:30:05+00:00

When calling dlopen() for libgfdb, do not specify the library
version number "libgfdb.so.0.0.1", since libtool will not always
create libraries or link with that name with the full 3-digit
version. For instance on NetBSD only up to the 2-digit version is
available and "libgfdb.so.0.0.1" does not exist.

Instead, just specify "libgfdb.so" and rely on smymlinks installed
by libtool to find the relevant library.

Backport of: I074b1009d3622a122fdaeb4b99658bca3277e211

BUG: 1212676
Change-Id: I334cb6be8508051105c393ce4bb350f9df014df5
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10408
Reviewed-by: Dan Lambright 
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

tier: fix off-by-one overrun in UUID string

2015-04-27T12:33:00+00:00

UUID strings are UUID_CANONICAL_FORM_LEN (36) bytes long
plus the trailing nul character that various function (e.g.:
uuid_unparse) will add. As a consequence, UUID strings must
be declared as UUID_CANONICAL_FORM_LEN+1 long, otherwise
we get a off-by-one overrun that corrupts the next variable
on stack.

Backport of: I5837ad6ca06fa17cc7ab143eedd02d8099ecca2a

BUG: 1212676
Change-Id: I27bd223bdd72cda679b7cdc861e09e0f367bd6e4
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10395
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

Cluster/DHT Mismatching gfid values in dht_local_t

2015-04-08T19:45:55+00:00

If multiple files with the same name but different gfids
exist on different subvolumes, dht_lookup_everywhere_cbk()
copies the gfid from the last received response into
local->gfid but does not update the local->stbuf structure.
dht_linkfile_create() uses the value in local->gfid, but
dht_linkfile_attr_heal() uses the one in local->stbuf, causing
a mismatch and failure while trying to heal the linkfile attrs.

Change-Id: I80d152be95b42d736c5d9182b955f42e374b82a5
BUG: 1205785
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/9998
Reviewed-by: Susant Palai 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Shyamsundar Ranganathan

dht : null dereference coverity fix

2015-04-08T19:19:38+00:00

Change-Id: I700e7ebdfe4929a6d74406ea081059bdddcf7a79
BUG: 789278
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9628
Reviewed-by: N Balachandran 
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Shyamsundar Ranganathan

libglusterfs/syncop: Add xdata to all syncop calls

2015-04-08T15:14:59+00:00

This patch adds support for xdata in both the
request and response path of syncops.

Few calls like lookup already had the support;
have renamed variables in few places to maintain
uniformity.

xdata passed downwards is known as xdata_in
and xdata passed upwards is known as xdata_out.

There is an old patch by Jeff Darcy at
http://review.gluster.org/#/c/8769/3 which does the
same for some selected calls. It also brings in
xdata support at gfapi level.

xdata support at gfapi level would be introduced
in subsequent patches.

Change-Id: I340e94ebaf2a38e160e65bc30732e8fe1c532dcc
BUG: 1158621
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/9859
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

ctr : Fix for heating of files during promotion/demotion

2015-04-08T10:29:58+00:00

This fix will solve the heating of the files during the promotion
or demotion.
Promotion:
~~~~~~~~~
When a file gets promoted it get the current time stamp
 during creation only, but following writes or reads during the
migration wont heat the file.
Demotion:
~~~~~~~~
When a file gets demoted it get the wind/unwind time stamp is set to
zero. The following writes or reads during the migration wont heat
the file.

What is remaining ?
~~~~~~~~~~~~~~~~~
Bug 1209129 ( https://bugzilla.redhat.com/show_bug.cgi?id=1209129 )
Inspite of this fix there is still a issue remaining, i.e the heat of
the file is not keep intact during a internal rebalance activity i.e
a rebalance within a tier.

Change-Id: I01e82dc226355599732d40e699062cee7960b0a5
BUG: 1207867
Signed-off-by: Joseph Fernandes 
Signed-off-by: Dan Lambright 
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/10080
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System

glusterd: Support distributed replicated volumes on hot tier

2015-04-08T07:28:21+00:00

We did not set up the graph properly for hot tiers with replicated
subvolumes. Also add check that the file has not already been moved
by another replicated brick on the same node.

Change-Id: I9adef565ab60f6774810962d912168b77a6032fa
BUG: 1206517
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/10054
Reviewed-by: Joseph Fernandes 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

dht : coverity fixes

2015-04-07T10:52:05+00:00

CID : 1124352,1124365 (unchecked return value),
      1124377 ( logically dead code),
      1124511 (null dereference)

Change-Id: I61e029a078559cfe15d36bf0aa53418f6214e5cb
BUG: 789278
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/9622
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: N Balachandran 
Reviewed-by: Vijay Bellur

cluster/dht: Unwind with proper op_ret

2015-04-06T13:27:13+00:00

1. Expected behavior of get_real_filename feature.

A getxattr on a existing dir with glusterfs.get_real_filename:
as key should result in one of the following things.

a. A value returned for that key having the real filename (a file whose
match is a case insensitive match to the filename passed in key).
b. op_ret = -1 and errno set to ENOENT meaning that no such file exists
under the specified dir in any case.
c. op_ret = -1 and errno set to ENODATA. This is a case assuming no
xlator interprets the glusterfs.get_real_filename key and it get
passed down to the posix xlator. Naturally, posix xlator would not
find any xattr with this key and would return ENODATA. This will be
interpreted specially by the caller as the feature not being supported
by underlying glusterfs.

2. What assumptions are wrong?
Initially the key used to be user.glusterfs.get_real_filename.
In that case, when posix xlator did a getxattr call it would have
received ENODATA as error. However, the key has now changed to
glusterfs.get_real_filename. This leads to a EOPNOTSUPP error instead.

Considering the above information, this is a rewrite of
get_real_filename logic in dht.

Change-Id: I012e9150047fc8563be91b0d112a368ac1cbf598
BUG: 1204140
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/9956
Tested-by: Gluster Build System 
Reviewed-by: N Balachandran 
Reviewed-by: Shyamsundar Ranganathan

cluster/dht: fix spurious smoke test failure

2015-04-06T13:14:12+00:00

There is smoke test failure due to implici declaration of function
"uuid_parse" and "uuid_compare".

Fix is to change these function caller name to "gf_uuid_parse" and
"gf_uuid_compare."

Change-Id: I79efa00c44d112c2ca732a9d9711c07bd5f1a069
BUG: 1207532
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/10139
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos