glusterfs.git/xlators/cluster/ec/src/ec.c, branch v3.7.19

cluster/ec: Restrict the launch of replace brick heal

2016-06-09T09:04:07+00:00

Problem: When features.cache-invalidation is ON, a lot of
ec_notify function gets called which leads to launch of
too many heals. This leads to no heal completion,
which causes accumulation of heals.

Solution: ec_launch_replace_heal should not be launch
for every event. Replace brick will trigger a child up
event and then only this heal function should be called.

master -
http://review.gluster.org/#/c/14649/

Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d
BUG: 1342964
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/14652
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Xavier Hernandez

cluster/ec: Provide an option to enable/disable eager lock

2016-03-21T05:52:53+00:00

Problem: If a fop takes lock, and completes its operation,
it waits for 1 second before releasing the lock. However,
If ec find any lock contention within this time period,
it release the lock immediately before time expires. As we
take lock on first brick, for few operations, like read, it
might happen that discovery of lock contention might take
long time and can degrades the performance.

Solution: Provide an option to enable/disable eager lock.
If eager lock is disabled, lock will be released as soon
as fop completes.

gluster v set  disperse.eager-lock on
gluster v set  disperse.eager-lock off

master-
http://review.gluster.org/13605

Change-Id: I000985a787eba3c190fdcd5981dfbf04e64af166
BUG: 1318965
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/13773
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/ec: Automate heal for replace brick

2016-02-10T08:31:12+00:00

Problem:
After a replace brick command, newly added
brick does not contain data which existed
on old brick.

Solution:
Do getxattr after initialization of all the
bricks. This will trigger heal for brick root
as soon as it finds the version mismatch on
newly added brick.

Removing tests from ec-new-entry.t which were
required to simulate automation of heal after
replace brick.

master -
http://review.gluster.org/#/c/13353/

Change-Id: I08e3dfa565374097f6c08856325ea77727437e11
BUG: 1305755
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/13353
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/13403
Reviewed-by: Xavier Hernandez 
Tested-by: Xavier Hernandez

cluster/ec: Create this->itable in all cases

2016-01-31T02:27:07+00:00

Problem:
glfsheal operates based on mount's volfile which doesn't have iamshd flag due
to which this->itable is NULL, this leads to "inode not found" logs in glfsheal
logs.

Fix:
Ec only allocates itable with 10 inodes, so allocating this->itable in all
cases in init.

 >Change-Id: I01d3c05e93a17007a4716a2d6f392d2aa306a34b
 >BUG: 1294743
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/13112
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >(cherry picked from commit 080ddb79d8805253a7f4274606351570faae1add)

Change-Id: I4fb624fc26d47128221322da077d04b12add6452
Signed-off-by: Pranith Kumar K 
BUG: 1302943
Reviewed-on: http://review.gluster.org/13312
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

cluster/ec: Implement gfid-hash read-policy

2015-10-29T11:52:49+00:00

Add a policy in ec to performs reads from same bricks as long as they
are good. Based on the gfid of the file/directory it determines the
bricks to be considered for reading.

 >Change-Id: Ic97b5c54c086a28b5e07a330a4fd448551b49376
 >BUG: 1261260
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/12133
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 

BUG: 1270705
Change-Id: Ibf0d21d7210125fa7aaa12b3f98bcdf7cd89ef02
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12456
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

cluster/ec: Minimize usage of EIO error

2015-08-08T15:36:57+00:00

>Change-Id: I82e245615419c2006a2d1b5e94ff0908d2f5e891
>BUG: 1245276
>Signed-off-by: Xavier Hernandez 
>Reviewed-on: http://review.gluster.org/11741
>Tested-by: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: NetBSD Build System 

Change-Id: Ifd3d63f88a686a2963c5ba2e62110249f84f338d
BUG: 1250864
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11852
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

cluster/ec: Handle race between unlock-timer, new lock

2015-07-23T16:36:46+00:00

Problem:
New lock could come at the time timer is on the way to unlock. This was leading
to crash in timer thread because thread executing new lock can free up the
timer_link->fop and then timer thread will try to access structures already
freed.

Fix:
If the timer event is fired, set lock->release to true and wait for unlock to
complete.

Thanks to Xavi and Bhaskar for helping in confirming that this race is the RC.
Thanks to Kritika for pointing out and explaining how Avati's patch can be used
to fix this bug.

> Change-Id: I45fa5470bbc1f03b5f3d133e26d1e0ab24303378
> BUG: 1243187
> Signed-off-by: Pranith Kumar K 
> Reviewed-on: http://review.gluster.org/11670
> Tested-by: Gluster Build System 
> Reviewed-by: Xavier Hernandez 
> Tested-by: NetBSD Build System 

Change-Id: I9af012e717493684b7cd7d1c63baf2fa401fb542
BUG: 1246121
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11752
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

cluster/ec: Make background healing optional behavior

2015-07-21T21:37:38+00:00

Provide options to control number of active background heal count and qlen.

 >Change-Id: Idc2419219d881f47e7d2e9bbc1dcdd999b372033
 >BUG: 1237381
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11473
 >Reviewed-by: Xavier Hernandez 
 >Tested-by: Gluster Build System 

BUG: 1238476
Change-Id: I22ba902d9911195656db9e458c01b54cf0afcd7a
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11680
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

cluster/ec: Add throttling in background healing

2015-07-21T21:35:37+00:00

- 8 parallel heals can happen.
- 128 heals will wait for their turn
- Heals will be rejected if 128 heals are already waiting.

 >Change-Id: I2e99bf064db7bce71838ed9901a59ffd565ac390
 >BUG: 1237381
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11471
 >Tested-by: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 
 >Tested-by: NetBSD Build System 

BUG: 1238476
Change-Id: Id9625536197c1f5d6c3a9ed53f80bd9e6d14c507
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11679
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

ec: Porting messages to new logging framework

2015-06-27T09:19:38+00:00

This is a backport of http://review.gluster.org/#/c/10465/

cherry-picked from commit b0b9eaea9dbb4e9a535f5e969defc4556a9e2204
>Change-Id: Ia05ae750a245a37d48978e5f37b52f4fb0507a8c
>BUG: 1194640
>Signed-off-by: Nandaja Varma 

Change-Id: Ia05ae750a245a37d48978e5f37b52f4fb0507a8c
BUG: 1217722
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/11429
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri