glusterfs.git/xlators/cluster, branch v3.4.2qa2

cluster/afr: handle NULL check before strlen/strcmp in fgetxattr

2013-12-04T11:33:46+00:00

xattr name can legally be NULL. Handle that case without crashing.

Change-Id: Ie214cb05ccd52565dc247a9234ad83ae799d3866
BUG: 1036879
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6420
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: handle NULL check before strlen/strcmp in fgetxattr

2013-12-03T10:23:18+00:00

@key can legally be NULL. Handle that case without crashing.

Change-Id: Iaae293caa7eeb24afc9cd2580799173e2ce00911
BUG: 1036879
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6402
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: set layout in inode ctx even if linkfile fails

2013-11-26T20:52:25+00:00

Creating linkfile could have failed, but we dont care about linkfile
for setting layout in the inode ctx (could be EEXIST etc.)

So ignore @inode in cbk and pick it up from local->loc.inode

Change-Id: I2952799d7ae0d3441b84b2ca2981afd75d7576e2
BUG: 1032859
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6358
Tested-by: Gluster Build System

core: fix errno for non-existent GFID

2013-11-26T19:49:05+00:00

When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.

Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6322
Tested-by: Gluster Build System

Disable eager-locks on NetBSD for 3.4 branch

2013-10-24T12:21:26+00:00

As described in https://bugzilla.redhat.com/show_bug.cgi?id=1005526
eager-locks are broken on release-3.4, at least for NetBSD. This
change disable them by default, leaving the admin the possibility
to explicitely enable the feature if needed.

BUG: 1005526
Change-Id: I6f1b393865b103ec56ad5eb5143f59bb8672f19c
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/6020
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Treat migration failures due to space constraints as skipped

2013-09-20T06:39:40+00:00

Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)

These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter

BUG: 989846
Change-Id: I4efa7ce69dd43680ff47181afed0c561954c5080
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5977
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Ignore subvols with error in min-free-disk/inodes

2013-09-10T16:05:18+00:00

Currently when selecting a alternative subvolume when hashed
subvol has exceeded min-free-disk/inodes, we do not check if
layouts have errors (including decommissioning). This leads
to data being written to those subvolumes, and in case of
decommissioning, will lead to data loss.

BUG: 982919

> Original-Author: shishir gowda 
> Reviewed-on: http://review.gluster.org/5299

Change-Id: If301a86cf3ca5fad6529bd2e61382f9901663ba0
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/5888
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: unlock before aborting transaction

2013-09-10T08:20:26+00:00

Else this results in a missing frame causing a hang

Change-Id: Ib5f3dc6a3999449faa2853cee2944af2fb065a20
BUG: 1002399
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5878
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: assign layout onto missing directories too

2013-09-10T08:14:48+00:00

The current self-healing algorithm is ignoring missing directories
for assigning new layout. When lookup() is racing against mkdir()
or when self-healing a half-done mkdir(), the layout assignment split
must happen based on the final number of directories, and not the
currently existing number of directories (because we finish mkdir()
of missing directories before hash layout assignment).

Without this fix, concurrent mkdir() and lookup() will step on
each others feet, create a messed up layout on disk, and end up
with different in-memory layouts.

Once two clients have different in-memory layouts, creation of
subdirectory will not arbitrate on the same hashed subvolume and will
result in GFID mismatch of the sub-directory.

Change-Id: Ia47acad67c265060405984c822b4d37512b9dbb3
BUG: 907072
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5871
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Perform delayed changelog wakeups for anon fd

2013-06-10T20:04:21+00:00

Problem:
Nfs xlator never does open on a file for performing writes,
afr does not perform changelog wakeup for this fd so operations
which do metadata operations as soon as the data operations are
completed perceive a delay od 'post-op-delay-secs'.

Fix:
Perform changelog wakeup on anon-fd if the fd with same pid is
not present in inode-list.

Note:
This approach is a short-term fix. A proper fix needs a new domain
for taking metadata locks so that data/metadata locks don't compete
with each other.

BUG: 966018
Change-Id: Ia9188a253e7943801b665e1b9205e2f551952d87
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/5067
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati