glusterfs.git/xlators/cluster, branch v3.6.2beta1

ec: Fix return errors when not enough bricks

2014-12-13T06:10:54+00:00

Changes introduced by this patch:

* Fix an incorrect error propagation when the state of the life
  cycle of a fop returns an error.

* Fix incorrect unlocking of failed locks.

* Return ENOTCONN if there aren't enough bricks online.

* In readdir(p) check that the fd has been successfully open by
  a previous opendir.

This is a backport of http://review.gluster.org/9098/

Change-Id: Ib44f25a1297849ebcbab839332f3b6359f275ebe
BUG: 1161066
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9107
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

ec: Change license

2014-12-13T06:06:13+00:00

This is a backport of http://review.gluster.org/9201/

Change-Id: Iae90ade2421898417b53dec0417a610cf306c44b
BUG: 1170515
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9233
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

cluster/afr: Eliminate locking in sh domain in metadata self-heal

2014-12-10T06:14:13+00:00

        Backport of: http://review.gluster.org/9240

Change-Id: I2ab2ad9a02d88c299cfb32e0cf6baa44d1c2ee12
BUG: 1171077
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9246
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

features/marker: Filter internal xattrs in lookup

2014-11-17T07:35:25+00:00

        Backport of http://review.gluster.org/9061

Afr should ignore quota-size-key as part of self-heal
but should heal quota-limit key.

BUG: 1163569
Change-Id: I93d203002eac4fe20b70730c27c852d783c16d7f
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9110
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Preserve errno in case of failures on all subvols

2014-11-17T07:07:21+00:00

        Backport of http://review.gluster.org/8984

Problem:
When quorum is enabled and the fop fails on all the subvolumes,
op_errno is set to EROFS which overrides the actual errno returned
from bricks.

Fix:
Don't override the errno when fop fails on all subvols.

Change-Id: I61e57bbf1a69407230ec172a983de18d1c624fd2
BUG: 1162122
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9087
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

ec: Avoid self-heal on directories on (f)stat calls

2014-11-15T18:01:32+00:00

To avoid inconsistent directory listings, a full self-heal
cannot happen on a directory until all its contents have
been healed. This is controlled by a manual command using
getfattr recursively and in post-order.

While navigating the directories, sometimes an (f)stat fop
can be sent. This fop caused a full self-heal of the directory.

This patch makes that (f)stat only initiates a partial self-heal.

This is a backport of http://review.gluster.org/9117/

Change-Id: I0a92bda8f4f9e43c1acbceab2d7926944a8a4d9a
BUG: 1159498
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9118
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Correctly handle quota xattrs

2014-11-15T18:01:14+00:00

This is a backport of http://review.gluster.org/8990/

Change-Id: I35e11d83c318210d44b918e847cf13db35b01510
BUG: 1158088
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/8992
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

cluster/afr: Perform post-op in entry selfheal inside locks

2014-10-31T13:09:28+00:00

        Backport of: http://review.gluster.org/#/c/9020

Take entrylks in xlator domain before doing post-op (undo-pending) in
entry self-heal. This is to prevent a parallel name self-heal on
an entry under @fd->inode from reading pending xattrs while it is
being modified by SHD after entry sh below, given that
name self-heal takes locks ONLY in xlator domain and is free to read
pending changelog in the absence of the following locking.

Change-Id: I0bc92978efc0741d6e3f2439540d008e31472313
BUG: 1136821
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9030
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

ec: Correctly handle xtime extended attribute

2014-10-28T08:40:02+00:00

Change-Id: I2bd34f063d6bf1835d5ae57a8e9aa03f3ec3deb3
BUG: 1156405
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/8976
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Fix rebalance issues

2014-10-27T14:18:51+00:00

Some issues in ec xlator made that rebalance didn't complete
successfully and generated some warnings and errors in the
log. The most critical error was a race condition that caused
false corruption detection when two specific operations were
executed sequentially and they shared the same lock.

This explains the problem:

1. A setxattr is issued.
2. setxattr: ec locks the inode before updating the xattr.
3. setxattr: The xattr is updated.
4. setxattr: Upper xlator is notified that the operation completed.
5. setxattr: A background task is initiated to update the version
             of the file.
6. A stat is issued on the same file.
7. stat: Since the lock is already acquired, it's reused.
8. stat: A lookup is issued to determine version and size
         information of the file.

At this point, operations 5 and 8 can interfere. This can make that
lookup sees different information on each brick, determining that
some bricks are corrupted and incorrectly excluding them from the
operation and initiating a self-heal. In some cases this false
detection combined with self-heal could lead to invalid updates of
the trusted.ec.size xattr, leaving the file smaller than it should
be.

This only happens if the first operation does not perform a lookup,
because chained operations reuse the information returned by the
previous one, avoiding this kind of problems.

To solve this, now the background update is executed atomically with
the posterior unlock. This avoids some reuses of the lock while
updating. However this reduces performance because the window in
which new requests can reuse the lock is much smaller now. This has
been alleviated by using the same technique implemented in AFR (i.e.
waiting some time before releasing the lock).

Some minor changes also introduced in this patch:

* Bug in management of 'trusted.glusterfs.pathinfo' that was writing
  beyond the allocated space.
* Uninitialized variable.
* trusted.ec.config was not created for regular files created with
  mknod.
* An invalid state was used in access fop.

This is a backport of http://review.gluster.org/8947/

Change-Id: Idfaf69578ed04dbac97a62710326729715b9b395
BUG: 1152903
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/8948
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright