glusterfs.git/xlators/cluster, branch v3.6.3beta1

ec: Don't use inodelk on getxattr when clearing locks

2015-02-11T09:40:11+00:00

When command 'clear-locks' from cli is executed, a getxattr request
is received by ec. This request was handled as usual, first locking
the inode. Once this request was processed by the bricks, all locks
were removed, including the lock used by ec.

When ec tried to unlock the previously acquired lock (which was
already released), caused a crash in glusterfsd.

This fix executes the getxattr request without any lock acquired
for the clear-locks command.

This is a backport of http://review.gluster.org/9440/

Change-Id: I77e550d13c4673d2468a1e13fe6e2fed20e233c6
BUG: 1181977
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9444
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

ec: Fix posix compliance failures

2015-02-11T09:37:55+00:00

This patch solves some problems that caused dispersed volumes to not
pass posix smoke tests:

* Problems in open/create with O_WRONLY
    Opening files with -w- permissions using O_WRONLY returned an EACCES
    error because internally O_WRONLY was replaced with O_RDWR.

* Problems with entrylk on renames.
    When source and destination were the same, ec tried to acquire
    the same entrylk twice, causing a deadlock.

* Overwrite of a variable when reordering locks.
    On a rename, if the second lock needed to be placed at the beggining
    of the list, the 'lock' variable was overwritten and later its timer
    was cancelled, cancelling the incorrect one.

* Handle O_TRUNC in open.
    When O_TRUNC was received in an open call, it was blindly propagated
    to child subvolumes. This caused a discrepancy between real file
    size and the size stored into trusted.ec.size xattr. This has been
    solved by removing O_TRUNC from open and later calling ftruncate.

This is a backport of http://review.gluster.org/9420

Change-Id: I20c3d6e1c11be314be86879be54b728e01013798
BUG: 1159471
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9501
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

afr : Fixes to 59ba78ae1461651e290ce72013786d828545d4c1

2015-02-11T09:35:38+00:00

A bug was found while reviewing
http://review.gluster.org/9377/
(inode was not being unreffed after use).
It is fixed on master as a part of the
following change - 
http://review.gluster.org/#/c/9377/7/xlators/cluster/afr/src/afr-common.c .
Fixing the same issue in 3.6 with this patch.

Change-Id: Ibdc4be49d88613ccb1f80349eb4d368710c0c24b
BUG: 1173528
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/9450
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Raghavendra Bhat

cluster/afr: When parent and entry read subvols are different, set entry->inode to NULL

2015-02-11T09:30:02+00:00

        Backport of: http://review.gluster.org/#/c/9477

That way a lookup would be forced on the entry, and its attributes will
always be selected from its read subvol.

Change-Id: Iaba25e2cd5f83e983fc8b1a1f48da3850808e6b8
BUG: 1186119
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9562
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

ec: Fix failures with missing files

2015-02-11T09:20:24+00:00

When a file does not exist on a brick but it does on others, there
could be problems trying to access it because there was some loc_t
structures with null 'pargfid' but 'name' was set. This forced
inode resolution based on /name instead of  which
would be the correct one. To solve this problem, 'name' is always
set to NULL when 'pargfid' is not present.

Another problem was caused by an incorrect management of errors
while doing incremental locking. The only allowed error during an
incremental locking was ENOTCONN, but missing files on a brick can
be returned as ESTALE. This caused an EIO on the operation.

This patch doesn't care of errors during an incremental locking. At
the end of the operation it will check if there are enough successfully
locked bricks to continue or not.

This is a backport of http://review.gluster.org/9407/

Change-Id: I9360ebf8d819d219cea2d173c09bd37679a6f15a
BUG: 1183716
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9560
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat

cluster/ec: Do not modify quota, selinux xattrs in healing

2015-02-04T11:54:47+00:00

        Backport of http://review.gluster.org/9401

Problem:
EC heal tries to heal quota-size, selinux xattrs as well.  quota-size is
private to the brick but since quotad accesses them using the standard
interface as well, they can not be filtered in the fops.

Fix:
Ignore QUOTA_SIZE_KEY and SELINUX xattrs during heal.

BUG: 1178590
Change-Id: Id569a49ef996e5507f4474c99b6cdc22781ad82d
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9454
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

cluster/ec: Handle internal xattr get/set

2015-02-04T11:53:33+00:00

        Backport of http://review.gluster.org/9385

Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.

Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.

BUG: 1182490
Change-Id: Ie32ebb95ee67cabbb9488951097a517172b45bcf
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9455
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

afr: Don't write to sparse regions of sink.

2015-02-03T13:24:56+00:00

Backport of http://review.gluster.org/9480

Problem:
When data-self-heal-algorithm is set to 'full', shd just reads from
source and writes to sink. If source file happened to be sparse (VM
workloads), we end up actually writing 0s to the corresponding regions
of the sink causing it to lose its sparseness.

Fix:
If the source file is sparse, and the data read from source and sink are
both zeros for that range, skip writing that range to the sink.

Change-Id: Id23d953fe2c8c64cde5ce3530b52ef91a7583891
BUG: 1187547
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9515
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

cluster/dht: Fix incorrect updates to parent times

2015-02-03T13:16:00+00:00

        Backport of: http://review.gluster.org/9457

In directory write FOPs, as far as updates to timestamps associated
with parent by DHT is concerned, there are three possibilities:
a) time (in sec) gotten from child of DHT < time (in sec) in inode ctx
b) time (in sec) gotten from child of DHT = time (in sec) in inode ctx
c) time (in sec) gotten from child of DHT > time (in sec) in inode ctx

In case (c), for time in nsecs, it is the value returned by DHT's child
that must be selected. But what DHT_UPDATE_TIME ends up doing is to choose
the maximum of (time in nsec gotten from DHT's child, time in nsec in inode ctx).

Change-Id: I1046bb7147ab48eca5c477be03ef2d4630e7752d
BUG: 1186119
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9490
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

Cluster/DHT : Fixed crash due to null deref

2015-01-21T12:00:09+00:00

A lookup on a linkto file whose trusted.glusterfs.dht.linkto
xattr points to a subvol that is not part of the volume
can cause the brick process to segfault due to a null dereference.
Modified to check for a non-null value before attempting to access
the variable.

> Change-Id: Ie8f9df058f842cfc0c2b52a8f147e557677386fa
> BUG: 1159571
> Signed-off-by: Nithya Balachandran 
> Reviewed-on: http://review.gluster.org/9034
> Tested-by: Gluster Build System 
> Reviewed-by: venkatesh somyajulu 
> Reviewed-by: Vijay Bellur 
> Signed-off-by: Raghavendra Bhat 

Change-Id: I53b086289d2386d269648653629a0750baae07a4
BUG: 1184191
Reviewed-on: http://review.gluster.org/9467
Reviewed-by: Vijay Bellur 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat