glusterfs.git/xlators/debug/trace/src/trace.c, branch v4.1.1

posix: Introduce flags for validity of iatt members

2017-12-29T17:13:25+00:00

v1 of the patch started off as adding new fields to iatt that can be
filled up using statx but the discussions were more around introducing
masks to check the validity of different fields from a RIO perspective.
To that extent, I have dropped the statx call in this version and
introduced a 64 bit mask for existing fields. The masks I have defined
are similar with the statx() flags' masks.

I have *not* changed iatt_to_stat() to use the macros IATT_TYPE_VALID,
IATT_GFID_VALID etc before blindly copying from struct iatt to struct.

Also fixed warnings in xlators because of atime/mtime/ctime seconds
field change from uint32_t to int64_t.

Change-Id: I4ac614f1e8d5c8246fc99d5bc2d2a23e7941512b
Signed-off-by: Ravishankar N

libglusterfs: specify ctx in gf_log_set_loglevel

2017-12-06T23:45:23+00:00

specify ctx in gf_log_set_loglevel, instead of getting it from a thread
specific variable.

Change-Id: I498f826e8e32231235a6b0005026a27c327727fd
BUG: 1521213
Signed-off-by: Zhang Huan

xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure

2017-10-13T16:23:02+00:00

Problem: strncpy was being called with a source string of length
equal to the size argument at lines 3110 and 3114.

Solution: Calculate the size argument from the size of the
destination argument.

Change-Id: I1fed6f8f47c5512b9489bfb3297e7a9911eacbc8
BUG: 789278
Signed-off-by: Kamal Mohanan

xlator/debug :coverity Issue BUFFER_SIZE

2017-10-10T15:46:20+00:00

Issue :Calling strncpy with a source string whose length (2 chars)
is greater than or equal to the size argument (2) will fail to
null-terminate "trace_fop_names[i].name".

Solution : The size argument is obtained from
sizeof(trace_fop_names[i].name).

Change-Id: I99fad2693054f3af84d78da34c61258233d3049a
BUG: 789278
Signed-off-by: Subha sree Mohankumar

debug/trace: Implement seek fop

2017-06-09T07:20:37+00:00

Change-Id: Idd1b92201348a76a6145b38799a3a46cab730540
BUG: 1458193
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17437
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

debug/trace: Print entries' iatts in readdirp cbk

2017-01-20T10:46:55+00:00

Change-Id: Iab2b4fa44b22aad0745e9f9249d8adba0acd7de1
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/16432
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G

build: correctly format some (s)size_t messages

2016-07-17T13:36:58+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

BUG: 1198849
Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14933
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System

debug/trace: Print {acm}times as integers

2016-03-29T12:49:59+00:00

This helps in debugging issues with mtime, ctime etc.

Change-Id: I4a0335f17c6b40e6c627658e91f43989c3efca22
BUG: 1302948
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/13826
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

all: reduce "inline" usage

2015-09-01T11:55:15+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Venky Shankar

debug/trace: Print total write size in trace_writev

2015-08-31T10:11:06+00:00

This is some information I find useful while debugging issues
in shard translator.

Change-Id: Ic35c34c2f52d27b3617fc722dabe558de2056b67
BUG: 1258311
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12053
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Vijay Bellur