glusterfs.git/xlators/experimental/jbr-server, branch v3.10dev

jbr: fix unused variable warnings/errors

2016-08-29T12:00:23+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I68c210f3bcc0f7754a89095c0d1408d57d5bd4a2
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15244
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Jeff Darcy

dict: Don't expose get_new_dict/dict_destroy

2016-07-26T06:47:33+00:00

get_new_dict/dict_destroy is causing confusion where, dict_new/dict_destroy or
get_new_dict/dict_unref are used instead of dict_new/dict_unref.

Change-Id: I4cc69f5b6711d720823395e20fd624a0c6c1168c
BUG: 1296043
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/13183
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Krutika Dhananjay

jbr: coverity, resource leak

2016-07-22T15:12:15+00:00

Change-Id: I62428808ce52569ff0298b0fcdd07cbaec1621dc
BUG: 1358944
CID: 1357871
Signed-off-by: Zhou Zhengping 
Reviewed-on: http://review.gluster.org/14977
Reviewed-by: Vijay Bellur 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

core: use readdir(3) with glibc, and associated cleanup

2016-07-18T11:59:42+00:00

Starting with glibc-2.23 (i.e. what's in Fedora 25), readdir_r(3)
is marked as deprecated. Specifically the function decl in 
has the deprecated attribute, and now warnings are thrown during the
compile on Fedora 25 builds.

The readdir(_r)(3) man page (on Fedora 25 at least) and World+Dog say
that glibc's readdir(3) is, and always has been, MT-SAFE as long as
only one thread is accessing the directory object returned by opendir().
World+Dog also says there is a potential buffer overflow in readdir_r().
World+Dog suggests that it is preferable to simply use readdir(). There's
an implication that eventually readdir_r(3) will be removed from glibc.
POSIX has, apparently deprecated it in the standard, or even removed it
entirely.

Over and above that, our source near the various uses of readdir(_r)(3)
has a few unsafe uses of strcpy()+strcat().

(AFAIK nobody has looked at the readdir(3) implemenation in *BSD to see
if the same is true on those platforms, and we can't be sure of MacOS
even though we know it's based on *BSD.)

Change-Id: I5481f18ba1eebe7ee177895eecc9a80a71b60568
BUG: 1356998
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/14838
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kotresh HR 
Reviewed-by: Jeff Darcy

build: correctly format some (s)size_t messages

2016-07-17T13:36:58+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

BUG: 1198849
Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14933
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System

core: assorted spelling mistakes reported by Debian

2016-05-26T15:55:16+00:00

See also
> Change-Id: I567a4be8f0f31f6285550f243fe802895f6bc43b

Reported-by: Patrick Matthäi 
BUG: 1336793

Change-Id: Icb9a6ff94d86663a5bca4ba931d810439c02556e
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14526
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Jeff Darcy

jbr/locking: Define path for lock/unlock fops in JBR

2016-05-26T15:27:43+00:00

lock/unlock fops need to be handled differently than
other 'regular' fops, so as to avoid chances of deadlock
in blocking calls. This patch addresses the same in the
following manner, with a caveat.

1. On receiving the fop if the node is a follower, it
   performs the operation (irrespective of it being
   lock/unlock fop), and returns the result.

2. If the node is a leader it follows the following paths
   for lock and unlock fops:

   For lock fops :
   -> It performs the fop on itself. If it is a failure, it
      sends -ve ack to the client. If it is successful, it
      dispatches the fop to the followers.
   -> On receiving responses from the followers, it checks
      for quorum (including the leader's outcome). If
      quorum is met, it sends +ve ack to the client.
   -> If quorum is not met, then it *should* issue a rollback
      to the followers, followed by the rollback on the leader.
      It should then send -ve ack to he client.

   For unlock fops:
   -> It dispatches the fop on the followers first.
   -> On receiving responses from the followers, it performs
      the fop on itself. On completion, it checks for quorum
      (including the leader's outcome). If quorum is met, it
      sends +ve ack to the client.
   -> If quorum is not met, then it *should* issue a rollback
      on itslef, followed by the rollback on the followers.
      It should then send -ve ack to he client.

Caveat:
   -> jbr-server does not have a rollback framework yet,
      and hence this patch does not perform the rollbacks as
      discussed in the failure scenarios above. The rollback
      framework will be a different dependent patch.

Change-Id: I26961b27cb85f324c1ffeee80e82ec082ffa4465
BUG: 1333370
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/14226
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

jbr: Making fop functions more modular to reuse more code

2016-05-25T18:52:44+00:00

Putting bigger chunks of re-usable code like leader checks
and init into functions thereby reducing the size of the
'fop' call.

Introduced 'perform_local_op' in the 'fop' call, where
regular functions as of now just call dispatch, but fops
like 'lk' can do their fop specific operations.

Introduced selective_generate to allow certain functions
for a particular fop to be generated. The rest of the
functions can be customised and added in jbr.c

Change-Id: I3754ed68983e763329e14a2faef911428e36e4f0
BUG: 1336328
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/14355
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

nsr/jbr: Renaming nsr to jbr

2016-04-25T19:05:35+00:00

As per community consensus, we have decided to rename
nsr to jbr(Journal-Based-Replication). This is the patch
to rename the "nsr" code to "jbr"

Change-Id: Id2a9837f2ec4da89afc32438b91a1c302bb4104f
BUG: 1328043
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13899
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy