glusterfs.git/xlators/features/gfid-access, branch release-3.5

features/gfid-access: Fix entry operations

2014-07-08T08:13:15+00:00

        Backport of http://review.gluster.org/8204

Problem:
When more than one aux-mounts are performing rmdir .gfid//dir
simultaneously, then sometimes a hang is observed.  In gfid-access xlator When
virtual parent/inode are replaced with real parent/inode in loc, virtual
pargfid/gfid are not replaced with real pargfid/gfid respectively. Afr is using
parent_loc->gfids to order the entry locks. But parent_loc->gfid contains
random/virtual gfid generated by gfid-access xlator. Entrylk in client xlator
is using loc->inod->gfid for sending entrylk which has 'real' gfid. Because the
ordering is happening based on random gfids, One mount orders the locks as (L1,
L2) where as the other orders them as (L2, L1) leading to a dead-lock thus
a hang.

Fix:
Replace virtual pargfid/gfid with real pargfid/gfid when virtual-inodes are
replaced with real-inodes in loc.

BUG: 1114501
Change-Id: I13016de1da11762e0697792d76e6e946d991c0a4
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8251
Reviewed-by: Kotresh HR 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/gfid-access: Fix inode leaks and loc path corruption

2014-07-08T08:11:50+00:00

        Backport of http://review.gluster.org/8009
        Backport of http://review.gluster.org/8163

BUG: 1112659
Change-Id: Ic70a3ddfcfef88909c12ca6791a8e20c3fee2eae
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8250
Reviewed-by: Kotresh HR 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

feautre/gfid-access: Fix EINVAL when stat on .gfid

2014-07-07T07:22:28+00:00

Problem: Some of the inode operations on '.gfid'
virtual directory was resulting in the error
EINVAL from dht after failing to find the layout.

Solution: Inode operations on '.gfid' virtual directory
should not wind further down and should be handled
accordingly in the gfid-access translator itself.

Change-Id: I156cb10ffea0c46b0d747e26f74538d7fb01a1dd
BUG: 1105891
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/8011
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Venky Shankar 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8234
Reviewed-by: Niels de Vos

features/gfid-access: Fix memory leaks.

2014-06-10T09:37:49+00:00

Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
BUG: 1104919
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/7983
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/gfid-access: calloc gfid and set in xdata

2014-06-08T14:58:10+00:00

Backport of http://review.gluster.org/#/c/7978/

Problem: the gfid passed to ga_fill_tmp_loc() was a stack variable which
the function set in the xdata dictionary. Accessing it in a later point
in time gave unexpected values.

This was easy to hit when AFR was involved like so:
ga_mknod()--->xxx-->afr_mknod():
In afr_mknod transaction, once the stack-winds for the lock-phase are sent,
the gfid in xdata becomes out of scope. When we send the actual op i.e.
afr_mknod_wind(), the gfid in xdata is stale, causing posix to set junk
gfids on the files.

Fix:
calloc the gfid and set it in the dict.

Thanks to Pranith for the RCA!

Change-Id: Ief2080836dc2923dec4be44dda4f6211430e535e
BUG: 1104959
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7985
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

geo-rep/gfid-access: Fix errno for non-existent GFID.

2014-03-03T05:05:29+00:00

Because of http://review.gluster.org/#/c/6318/ patch,
ESTALE is returned for a lookukp on non-existent GFID.
But ENOENT is more appropriate when lookup happens
through virtual .gfid directory on aux-gfid-mount
point. This is avoids confusion for the consumers
of gfid-access-translator like geo-rep which expects
ENOENT.

Change-Id: I4add2edf5958bb59ce55d02726e6b3e801b101bb
BUG: 1069191
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/7154
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Venky Shankar 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/7163
Reviewed-by: Vijay Bellur

features/gfid-access: fix lookup on .gfid//bname

2014-01-27T15:51:53+00:00

In gfid translator, lookup was not handling the case when
the lookup is sent on .gfid//bname. In this case,
we flip with fake inode of the parent with the real inode
in loc and send it downwards.

Change-Id: I639ff1dce10ffc045da419e333d455e208b6a0f0
BUG: 1057881
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/6795
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6807

features/gfid-access: populating inode during virtual_lookup_cbk.

2014-01-27T15:51:17+00:00

Setting appropriate ia_type and gfid for the inode, obtained during
virtual_lookup_cbk of a directory by doing an "inode_link".

Change-Id: I9582570c82e70ff5f1d4e441f9e9868ef82e9dc6
BUG: 1054199
Signed-off-by: Ajeet Jha 
Reviewed-on: http://review.gluster.org/6806
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gfid-access: fix the issue of entry creation with wrong gfid

2014-01-27T15:50:48+00:00

* dict_set was happening with a string instead of 'uuid_t' causing
  entry creations to happen with wrong gfid

* revalidate was causing excessive ESTALE logs as lookup was
  happening on '.gfid/' path itself causing server to become clueless

Change-Id: I3b76ce7fdec9c2ff785be21f506f859f489f80f0
BUG: 1054199
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/6520
Reviewed-by: Anand Avati 
Tested-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6805
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gfid-access: do chown() after creating the new entries.

2014-01-27T15:50:21+00:00

changing the 'frame->root->uid' on the fly is not a good idea as
posix-acl xlator on brick process would fail the op.

Change-Id: I996b43e4ce6efb04f52949976339dad6eb89bede
Signed-off-by: Amar Tumballi 
BUG: 847839
Reviewed-on: http://review.gluster.org/5833
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6801
Reviewed-by: Vijay Bellur