glusterfs.git/xlators/features/marker/src/marker.c, branch exp

marker: Fix inode value in loc, in setxattr fop

2016-11-17T10:53:15+00:00

On recieving a rename fop, marker_rename() stores the,
oldloc and newloc in its 'local' struct, once the rename
is done, the xtime marker(last updated time) is set on
the file, but sending a setxattr fop. When upcall
receives the setxattr fop, the loc->inode is NULL and
it crashes. The loc->inode can be NULL only in one valid
case, i.e. in rename case where the inode of new loc
can be NULL. Hence, marker should have filled the inode
of the new_loc before issuing a setxattr.

Change-Id: Id638f678c3daaf4a5c29b970b58929d377ae8977
BUG: 1394131
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/15826
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR 
Smoke: Gluster Build System 
Reviewed-by: Rajesh Joseph

features/marker: Fix dict_get errors when key is NULL

2016-04-21T11:37:39+00:00

Change-Id: I25e497459441334c13af77b3fec83c42a7a92ac4
BUG: 1319581
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/13793
Smoke: Gluster Build System 
Tested-by: Vijaikumar Mallikarjuna 
Reviewed-by: Vijaikumar Mallikarjuna 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Venky Shankar

marker: do mq_reduce_parent_size_txn in FG for unlink & rmdir

2016-04-06T12:15:00+00:00

* If a "rm -rf" is performed by a client, we initiate a
  marker background operation mq_reduce_parent_size_txn
  for rmdir and unlink.

  mq_reduce_parent_size_txn can fail when updating
  size on the ancestor directories, if these directories
  are removed during the txn as the child-parent association
  removed in the dentry list.

  So execute mq_reduce_parent_size_txn in foreground
  and then do the UNWIND for rmdir and unlink FOP

Change-Id: Iefcdced4c6ae0dbd43f92814d0ddcd1e33825864
BUG: 1322489
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13874
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

storage/posix: send proper iatt attributes for the root inode

2016-03-26T16:33:48+00:00

* changes in posix to send proper iatt attributes for the root directory
  when ancestry is built. Before posix was filling only the gfid and the
  inode type in the iatt structure keeping rest of the fields zeros. This
  was cached by posix-acl and used to send EACCES when some fops came on
  that object if the uid of the caller is same as the uid of the object on
  the disk.

* getting and setting inode_ctx in function 'posix_acl_ctx_get' is not atomic
  and can lead to memory leak when there are multiple looups for an
  inode at same time. This patch fix this problem

* Linking an inode in posix_build_ancestry, can cause a race in
  posix_acl.
  When parent inode is linked in posix_build_ancestry, and before
  it reaches posix_acl_readdirp_cbkc, reate/lookup can
  come on a leaf-inode, as parent-inode-ctx not yet updated
  in posix_acl_readdirp_cbk, create/lookup can fail
  with EACCESS. So do the inode linking in the quota xlator

Change-Id: I3101eefb65551cc4162c4ff2963be1b73deacd6d
BUG: 1320818
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/13730
Tested-by: Vijaikumar Mallikarjuna 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

marker: set inode ctx before lookup unwind

2016-03-22T06:28:56+00:00

When a file is unlinked before it was accounted by the marker,
then we may see error "ctx for the node ... is NULL" at many places.
This is actually not an error and can be ignored.

It is better to set the inode ctx before lookup/create is unwind
back to protocol server

Change-Id: I462b5542951f2fc2964f59af7a31978979dab1de
BUG: 1318158
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13748
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

geo-rep: Mask xtime and stime xattrs

2016-02-26T09:52:12+00:00

Allow access to xtime and stime xattrs only
to gsyncd client and mask them for the rest.

This is to prevent afr from performing self
healing on marker xtime and geo-rep stime
xattr which is not expected as each of which
gets updated them from backend brick and
should not be healed.

Change-Id: I24c30f3cfac636a55fd55be989f8db9f8ca10856
BUG: 1296496
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/13242
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Venky Shankar

quota: Fix incorrect disk usage shown on a tiered volume

2016-02-11T06:09:26+00:00

When quota is enabled on a tiered volume, incorrect data usage is
shown, it is because, during the process of migrating files in tiering,
we are accounting both for the src file and dst file at some point. By the
time we make the srcfile as a T file, marker has already accounted the
contri and has updated it's parent and also we are not accounting for the
truncate operation done, which accounts to incorrect data usage even after
unlinking the file. The size can increase drastically with multiple promotes
and demotes since the contri keeps changing and the parent is being updated.

Change-Id: Ie567228786713d7dc257ff374a69ad3be40f9e82
BUG: 1304970
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13363
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Vijaikumar Mallikarjuna 
NetBSD-regression: NetBSD Build System

quota: handle quota xattr removal when quota is enabled again

2016-01-07T08:20:27+00:00

When a quota is disable and enabled again before completing
the cleanup operation, this can remove the new xattrs
and quota accounting can become wrong

Remove removing the xattr, check if quota enabled again and the
xattr is new

Change-Id: Idda216f1e7346a9b843dbc112ea3e6faa9c47483
BUG: 1293601
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13065
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

quota: add 'quota-version' to xlator volume_options structure

2015-12-09T05:28:48+00:00

Below error is seen in brick log:
0-vol1-quota: option 'quota-version' is not recognized

So add this option to the volume_options structure of
marker xlator

Change-Id: I1bd68a537936ee0f9af85dac74f1377f84edb8f4
BUG: 1283178
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12878
Reviewed-by: Manikandan Selvaganesh 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

marker : fixing memory leak issue in marker

2015-11-23T19:03:25+00:00

In marker_readdirp_cbk, variable resolvedpath is not properly freed
and because of which there was a memory leak. The patch fixes it.

Change-Id: I9d80f72e3551aa912369257da3e8e2b261a2067f
BUG: 1284419
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12719
Reviewed-by: Vijaikumar Mallikarjuna 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur