glusterfs.git/xlators/features/marker/utils/syncdaemon, branch v3.4.4beta1

geo-rep / gsyncd: Separate log file directory for Mountbroker sessions

2013-02-05T01:34:56+00:00

... so that a mountbroker session which is initiated b/w master
and slave does not use the same log file if it's started after
a normal geo-rep session b/w master and slave. This results in
EPERM as the log file is owned by root and the geo-rep slave
process (now running as a non privileged user) does not have
access to it.

Also, having separate log file directory for mountbroker sessions
looks clean.

NOTE: geo-rep's client mount log file location remains unchanged.

Change-Id: Ic7a732e250aee5393b9c3f6ebf6dfe2c310b7fe4
BUG: 893960
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/4407
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep: do not access BaseException.message in syncdutils

2012-12-18T22:17:35+00:00

http://www.python.org/dev/peps/pep-0352/ explains that the .message
property of BaseException is being removed. Most of the other exception
handlers access .args[] which should be suitable for this
case too.

Change-Id: I1810450b78d2b3d7f8bd07f2beb02cbe9e2adecb
BUG: 888346
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/4328
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep / gsyncd: play nicely with peer multiplexing when setting a checkpoint

2012-12-04T20:13:02+00:00

The gsyncd invocation that instruments the "geo-rep config" command is
multiplexed over peers to ensure the uniformity of configuration.
In general, that works well, but checkpoint setting is a special case,
because (unlike other instances of config-set) it is logged (as recording
of checkpoint events is part of the feature).

Problem is that the path components leading to the log file are
created only on the original node, where gsyncd was started.
Therefore the logging attempt will fail on the other nodes.

Fix: ignore if opening the logfile on behalf of checkpoint setting
fails with ENOENT.

Change-Id: I677f3f081bf4b9e3ba4d25d58979d86931e6beb4
BUG: 881997
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/4248
Reviewed-by: Niels de Vos 
Tested-by: Christos Triantafyllidis 
Reviewed-by: Christos Triantafyllidis 
Reviewed-by: Anand Avati

geo-rep / gsyncd,glusterd: do not hardcode socket path

2012-11-29T00:54:07+00:00

... in gsyncd python code. Indeed, use the configuration
mechanism to set it suitably from glusterd.

Change-Id: I9fe2088b14d28588d1e64fe892740cc5755b8365
BUG: 868877
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/4143
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-replication: catch select.error on select()

2012-11-29T00:23:49+00:00

tailer() in resource.py does not correctly catch exceptions from
select(). select() can raise an instance of the select.error class and
the current expression only catches ValueError (and the instance will
have reference called selecterror).

The geo-rep log contains a call trace like this:
> E [syncdutils:190:log_raise_exception] : FAIL:
> Traceback (most recent call last):
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 216, in twrap
> tf(*aa)
> File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 123, in tailer
> poe, _ ,_ = select([po.stderr for po in errstore], [], [], 1)
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 276, in select
> return eintr_wrap(oselect.select, oselect.error, *a)
> File "/usr/libexec/glusterfs/python/syncdaemon/syncdutils.py", line 269, in eintr_wrap
> return func(*a)
> error: (9, 'Bad file descriptor')

BUG: 880308
Change-Id: I2babe42918950d0e9ddb3d08fa21aa3548ccf7c5
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/4233
Reviewed-by: Peter Portante 
Reviewed-by: Csaba Henk 
Tested-by: Gluster Build System

geo-rep/gsyncd: work around rsync argument overflow

2012-09-07T23:50:08+00:00

instead of passing the files to be synced as args to rsync, have rsync
read them on stdin with '-0 --files-from=-'

Change-Id: Ic3f71a0269941ce50051af8adfad183a52a79b01
BUG: 855306
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/3917
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

geo-rep / gsycnd: restore the generic signature for sendmark_regular

2012-07-30T18:18:20+00:00

Earlier fixes to 842330 changed the generic (*a, **kw) signature,
although that was not related to the issue.

We restore the generic signature as it was used for a reason
(proxy methods that do none or only algebraic transformations
on passed arguments idiomatically have generic signature, both
to serve as visual cue and agnosticism wrt. the inner API).

Change-Id: Ib609a3a58be53d78b7f1221a3c162c6aec8fd488
BUG: 842330
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3754
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

gsyncd / geo-rep: Fix sendmark() invocation for Normal Mixin

2012-07-25T14:08:21+00:00

Change-Id: I0ae81ab01418becba83e401ec36c6db5323945e8
BUG: 842330
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/3725
Tested-by: Vijay Bellur 
Reviewed-by: Vijay Bellur

Fixes for gsyncd / geo-rep and FUSE listxattr

2012-07-24T09:45:05+00:00

This patch fixes two problems with recent changes to
Geo-Replication

First:
------
Recent changes to geo-replication relies on Rsync to tranfer
extended attributes. Essentially Rsync would invoke a listxattr()
and then getxattr() the set reutrned by listxattr() and finally
transfer it to the remote slave. Xattrs like security.selinux would
create problems as they are not allowed to be set explicitly (unless
there's a rule that allows this). So, to make Rsync behave sanely we
filter out all "*.selinux*" xattrs from listxattr() (which is getxattr()
with ->name as NULL).

Second:
-------
Python's "if {..} else {..}" shortcut ".. and .. or .." was misused here.
This is a straightforward fix by interchanging last two variables (classes
in this case). Also fix a typo in sendmark_regular() definition.

Change-Id: I097b5f5d88a36c7eef5560a78d4332948a545942
BUG: 842330
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/3714
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gsyncd / geo-rep: Fix typo in 'purge' flow

2012-07-20T15:32:52+00:00

Change-Id: I6c329b895178545d16b0cb9f01ad116f5342f752
BUG: 841855
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/3706
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur