glusterfs.git/xlators/features/snapview-client/src/snapview-client.c, branch v5.0

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu

All: run codespell on the code and fix issues.

2018-07-22T14:40:16+00:00

Please review, it's not always just the comments that were fixed.
I've had to revert of course all calls to creat() that were changed
to create() ...

Only compile-tested!

Change-Id: I7d02e82d9766e272a7fd9cc68e51901d69e5aab5
updates: bz#1193929
Signed-off-by: Yaniv Kaul

snapview: Coverity Fixes

2017-11-08T02:15:29+00:00

Coverity ID: 259
Coverity ID: 163

Change-Id: I7f7753b870715e1176826fb8dfbe81119750d113
BUG: 789278
Signed-off-by: Ashish Pandey

uss/svc: Send the first lookup to the normal graph

2017-08-14T07:30:20+00:00

When parent inode is not looked up before, the inode type
won't be set. In this scenario we should send the lookup
to the normal graph first.

Change-Id: I5d3e53f5c1c33a17be32204f3114749d9b1e6db8
BUG: 1480591
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/18028
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k

uss/svc: fix double free on xdata dictionary

2017-07-09T05:23:48+00:00

we were taking unref on wrong dictionary which results
in wrong memory access.

Change-Id: Ic25a6c209ecd72c9056dfcb79fabcfc650dd3c1e
BUG: 1467513
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17691
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee

svc: send revalidate lookup on special dir

2017-07-09T04:57:48+00:00

.snaps directory is a virtual direcotory, that doesn't
exist on the backend. Even though it is a special dentry,
it doesn't have a dedicated inode. So the inode number is
always random. Which means it will get different inode
number when reboot happens on snapd process.

Now with windows client the show-direcotry feature requires
a lookup on the .snpas direcoty post readdirp on root.
If the snapd restarted after a lookup, then subsequent lookup
will fail, because linked inode will be stale.

This patch will do a revalidate lookup with a new inode.

Change-Id: If97c07ecb307cefe7c86be8ebd05e28cbf678d1f
BUG: 1467513
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17690
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Smoke: Gluster Build System

features/uss: Remove redundant dict_unref

2017-01-06T18:04:39+00:00

In case dict_set_dynstr_with_alloc fails, dict_unref is done
when exection jumps to label 'out'.

Change-Id: I083386b7f85207348ba0bc353b5d1036ab821a15
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/16321
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

snapshot/uss: client-side log is filled with "invalid-argument" error

2016-05-31T18:54:51+00:00

xdata is used without checking if it is NULL or not.

Change-Id: Ib6ddaab28ec3b430b8d646aada0456d3cc9978cb
BUG: 1339149
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/14511
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

snapshot/uss: client log is filled with "invalid argument: inode" error

2016-05-25T14:23:37+00:00

svc_inode_ctx_get is called even if inode is NULL. We should not call
this function if inode is NULL

Change-Id: I5c3f17633ca88e5b6f40d4acf14a09e14b7ef62b
BUG: 1339149
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/14525
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

snapshot: svc_stat collides with define from /usr/include/rpc/svc.h

2016-04-27T09:11:56+00:00

Compiling fails with this error:

    snapview-client.c:559:24: error: macro "svc_stat" passed 4 arguments, but takes just 1
               dict_t *xdata)
                            ^
    snapview-client.c:560:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
     {
     ^
    snapview-client.c:2412:26: error: ‘svc_stat’ undeclared here (not in a function)
             .stat          = svc_stat,
                              ^

svc_* is the common prefix for (SUN)RPC functions provided by system
headers. svc_stat() seems to be an existing function name. This happens
because change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 causes
 included through "glusterfs.h". Prepending gf_ for all svc_*
functions works around the symbol collision.

Change-Id: Idc86b719c48675a5154c54d844c1899d14d46e2a
BUG: 1328502
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14035
Smoke: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System