glusterfs.git/xlators/features/snapview-server, branch v3.6.0beta3

snapview-server: get the handle if its absent before doing any fop

2014-09-18T18:02:31+00:00

* Now that NFS server does inode linking in readdirp, it can resolve the
  gfid (i.e. find the right inode from its inode table) present in the
  filehandle sent by the NFS client on which a fop came. So instead of
  sending the lookup on that entry, it directly sends the fop. But
  snapview-server does not get the handle for the entries in readdirp
  (because doing a lookup on each entry via gfapi would be costly. So it
   waits till a lookup is done on that inode, to get the handle and the
   fs instance and fill it in the inode context). So when NFS resoves the
   gfid and directly sends the fop, snapview-server will not be able to
   perform the fop as the inode contet would not contain the fs instance
   and the handle. So fops should check for the handle before doing gfapi
   calls. If the handle and fs instance are not present in the inode context
   they should get them by doing an explicit lookup on the entry.

rebase of the patch http://review.gluster.org/#/c/8324/

Change-Id: I70c9c8edb2e7ddad79cf6ade3e041b9d02241cd1
BUG: 1143961
Reviewed-on: http://review.gluster.org/8768
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

snapview-server: register a callback with glusterd to get

2014-09-18T17:59:30+00:00

 notifications

* As of now snapview-server is polling (sending rpc requests to glusterd) to
  get the latest list of snapshots at some regular time intervals
  (non configurable). Instead of that register a callback with glusterd so that
  glusterd sends notifications to snapd whenever a snapshot is created/deleted
  and snapview-server can configure itself.

rebase of the patch http://review.gluster.org/#/c/8150/

Change-Id: Iee2582b1a823d50c79233a41cf2106f458b40691
BUG: 1143961
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/8767
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

USS: initialize a list before using it.

2014-09-18T17:54:30+00:00

backport of the patch http://review.gluster.org/8569 by
Raghavendra G 

Change-Id: I7b25fdf27c6d7ff66d24925bc73d9c6681259d37
BUG: 1143961
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/8764
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

osx: snapview-server fails to build on OSX use 'syscall.h'

2014-08-15T19:21:50+00:00

Change-Id: Ib9443913abb89c6a04a8723bced4c77128047bd0
BUG: 1130307
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8487
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

make snapview-server more compatible with NFS server

2014-07-16T09:27:50+00:00

* There was no handle based API for listxattr. With this change, glfs_h_getxattrs
  also handles the listxattr functionality by checking whether the name is NULL
  or not (like posix). But all the gfapi functions for listxattr
  (glfs_h_getxattrs AND glfs_listxattr AND glfs_flistxattr) returns the names of
  the xattrs in a buffer provided by the caller. But snapview-server has to
  return the list of xattrs in a dict itself (similar to posix xlator). But
  the buffer just contains the names of the xattrs. So for each xattr, a zero
  byte value is set (i.e. "") into the dict and sent back. Translators which
  do xattr caching (as of now md-cache which caches selinux and acl related
  xattrs) should not cache those xattrs whose value is a zero byte data ("").
  So made changes in md-cache to ignore zero byte values.

* NFS server was not linking the inodes to inode table in readdirp. This was
  leading to applications getting errors. The below set of operations would
  lead to applications getting error
  1) ls -l in one of the snaopshots (snapview-server would generate gfids for
     each entry on the fly and link the inodes associated with those entries)
  2) NFS server upon getting readdirp reply would not link the inodes of the
     entries. But it used to generate filehandles for each entry and associate
     the gfid of that entry with the filehandle and send it as part of the
     reply to nfs client.
  3) NFS client would send the filehandle of one of those entries when some
     activity is done on it.
  4) NFS server would not be able to find the inode for the gfid present in the
     filehandle (as the inode was not linked) and would go for hard resolution
     by sending a lookup on the gfid by creating a new inode.
  5) snapview-client will not able to identify whether the inode is a real inode
     existing in the main volume or a virtual inode existing in the snapshots
     as there would not be any inode context.
  6) Since the gfid upon which lookup is sent is a virtual gfid which is not
     present in the disk, lookup would fail and the application would get an
     error.

  To handle above situation, now nfs server also does inode linking in readdirp.

Change-Id: Ibb191408347b6b5f21cff72319ccee619ea77bcd
BUG: 1115949
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/8230
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra G 
Reviewed-by: Vijay Bellur

snapview/server: warning cleanup after clang complaints

2014-06-18T06:18:13+00:00

- svs_inode_new()/svs_fd_new() should only need "no" arguments as
  presented

- define variables only with usability :-)

Change-Id: I10a8d189a088701b29f26b6e4913560e32d16e75
BUG: 1089172
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/7998
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

Minor fixes for correcting the goto statements for frame destroy and checking pthread_mutex_lock return values

2014-06-16T12:19:56+00:00

* Also some coverity fixes

Signed-off-by: Anand Subramanian 

Change-Id: I0c27b913e62b0a072e508e37a3fb3421a9ca9503
BUG: 1105439
Signed-off-by: Anand Subramanian 
Reviewed-on: http://review.gluster.org/8071
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Get snapshot info dynamically via new rpc and infra for snapview-server to refresh snaplist

2014-06-15T17:33:23+00:00

BUG: 1105439
Change-Id: I4bb312a53d88f6f4955e69a3ef2b4955ec17f26d
Signed-off-by: Anand Subramanian 
Reviewed-on: http://review.gluster.org/8001
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

get the path from the loc->path in the lookup instead of resolver doing it

2014-06-13T16:54:43+00:00

Change-Id: I7448e1199f4fd32fb0ae127b36dcf06641a153a9
BUG: 1108887
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/8053
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

snapview-server: coverity fixes

2014-06-09T11:52:27+00:00

Change-Id: If4c866b1155bedabd5cf65dae22fa565b7440938
BUG: 1094815
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/7975
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur