glusterfs.git/xlators/features, branch release-3.11

gfapi: Duplicate the buffer sent in setxattr calls

2017-08-12T13:42:27+00:00

Issue:
The caller of glfs_setxattr sends a buffer to set as the value.
We create a dict in which the pointer to the value is set.
Underlying layers like md-cache take a ref on this dict to store
the value for a longer time. But the moment setxattr is complete,
the caller of glfs_setxattr can free the value memory.

Solution:
memcpy the setxattr value to the gluster buffer.

> Reviewed-on: https://review.gluster.org/17967
> Reviewed-by: soumya k 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> (cherry picked from commit e11296f8e52b7e3b13d21b41d4fa34baea878edf)

Change-Id: I58753fe702e8b7d0f6c4f058714c65d0ad5d7a0a
BUG: 1479656
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/18002
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

snapview-server : Refresh the snapshot list during each reconnect

2017-07-03T12:52:45+00:00

Currently we are refreshing the snapshot list either when there is
a request from glusterd or the very first initialization. But if
anything changed after when glusterd is down then there is no
mechanism to refresh the snashot dentries.

This patch will refresh snapshot list during each reconnect

backport of>

>Change-Id: I3ed655572d777f60d57dd479d190f75553591267
>BUG: 1448150
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/17178
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Amar Tumballi 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>Reviewed-by: Raghavendra Bhat 

Change-Id: I3ed655572d777f60d57dd479d190f75553591267
BUG: 1463512
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17585
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

features/changelog: Add xattr as special type in changelog entry

2017-07-03T12:50:31+00:00

When both SETATTR and SETXATTR fops are happening on gfid within the
rollover time then, SETXATTR were not logged.
In Which case we will miss the xattr fop in slave.

This patch will be fix the same

Backport of>
>Change-Id: Ia75538ad1fd2797dbcf90d20dfa89f756009243d
>BUG: 1448914
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/17205
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kotresh HR 
>Smoke: Gluster Build System 

Change-Id: Ia75538ad1fd2797dbcf90d20dfa89f756009243d
BUG: 1463513
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17587
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR

core: assorted typos and spelling mistakes from Debian lintian

2017-07-03T12:47:48+00:00

Plus minor readability improvements.

Reported-by: pmatthaei@debian.org
master BUG: 1466785
master https://review.gluster.org/17660
Change-Id: I5393819a2fc9f240a19811143bb57b127df717cf
BUG: 1466801
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17661
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

feature/changelog: Fix buffer overflow crash

2017-07-03T12:43:25+00:00

The buffer used to hold the basename  was hard coded
to the size of NAME_MAX(255). It might lead to buffer
overflow crashes when the basename which is sent
is more than NAME_MAX length. Fixed the same.

> Change-Id: I6c1cad3ccaeb8c55549b1d3c5f96a198f65ba2b7
> BUG: 1463178
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17579
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
(cherry picked from commit b224f4253b7d3de3077ee35c8bdc20618eae4b7c)

Change-Id: I6c1cad3ccaeb8c55549b1d3c5f96a198f65ba2b7
BUG: 1463626
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17593
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Zhou Zhengping 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Shyamsundar Ranganathan

feature/bitrot: Fix ondemand scrub

2017-06-19T15:50:33+00:00

The flag which keeps tracks of whether the scrub
frequency is changed from previous value should
not be considered for on-demand scrubbing. It
should be considered only for 'scrub-frequency'
where it should not be re-scheduled if it is
set to same value again. But in case ondemand
scrub, it should start the scrub immediately
no matter what the scrub-frequency.

Reproducer:
1. Enable bitrot
2. Set scrub-throttle
3. Set ondemand scrub
Make sure glusterd is not restarted while doing
below steps

> Change-Id: Ice5feaece7fff1579fb009d1a59d2b8292e23e0b
> BUG: 1461845
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17552
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra Bhat 
> NetBSD-regression: NetBSD Build System 
(cherry picked from commit f0fb166078d59cab2a33583591b6448326247c40)


Change-Id: Ice5feaece7fff1579fb009d1a59d2b8292e23e0b
BUG: 1462127
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17555
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

index: Do not proceed with init if brick is not mounted

2017-06-19T15:48:10+00:00

..or else when a volume start force is given, we end up creating
/brick-path/.glusterfs/indices folder and various subdirs under it and
eventually starting the brick process.

As a part of this patch, glusterd_get_index_basepath() is added in
glusterd, who will then use it to create the basepath during
volume-create, add-brick, replace-brick and reset-brick. It also uses this
function to set the 'index-base' xlator option for the index translator.

> Reviewed-on: https://review.gluster.org/17426
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Pranith Kumar Karampuri 
(cherry picked from commit b58a15948fb3fc37b6c0b70171482f50ed957f42)

Change-Id: Id018cf3cb6f1e2e35b5c4cf438d1e939025cb0fc
BUG: 1462636
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17562
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

core: fix spelling errors

2017-06-13T14:34:34+00:00

fixes for various minor spelling errors and typos

master BUG: 1457808
master: https://review.gluster.org/17442

Reported-by: Patrick Matthäi 
Change-Id: Ic1be36f82e3d822bbdc9559878bd79520fc0fcd5
BUG: 1459090
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17475
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

upcall: Update the access time in missing cases

2017-06-13T14:23:58+00:00

Issue: In fops like rename, link, unlink etc, the parent
dirrs' client access time was not being updated. And in fops like
create, link, symlink etc. the new file/dirs' client access time was
not updated.

Solution: Update the client access time for both parent and new entry.

> Reviewed-on: https://review.gluster.org/17450
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Niels de Vos 
> (cherry picked from commit 149db390fd89beee1e8a3d946d4224ba2a9b4711)

Change-Id: Id9f63583216ae857f6251dca15797ac66fa85430
BUG: 1460895
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/17526
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

features/shard: Handle offset in appending writes

2017-05-29T14:12:20+00:00

When a file is opened with append, all writes are appended at the end of file
irrespective of the offset given in the write syscall. This needs to be
considered in shard size update function and also for choosing which shard to
write to.

At the moment shard piggybacks on queuing from write-behind
xlator for ordering of the operations. So if write-behind is disabled and
two parallel appending-writes come both of which can increase the file size
beyond shard-size the file will be corrupted.

 >BUG: 1455301
 >Change-Id: I9007e6a39098ab0b5d5386367bd07eb5f89cb09e
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: https://review.gluster.org/17387
 >Smoke: Gluster Build System 
 >Reviewed-by: Krutika Dhananjay 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 

BUG: 1456225
Change-Id: I9007e6a39098ab0b5d5386367bd07eb5f89cb09e
Signed-off-by: Pranith Kumar K 
Reviewed-on: https://review.gluster.org/17404
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan