glusterfs.git/xlators/features, branch v3.10.6

posix: add null gfid checks

2017-09-17T12:55:23+00:00

Backport of https://review.gluster.org/17975

...in file/dir creation and lookup codepaths. The check is relaxed for
fops coming from trash xlator at the moment until trash has client side
logic to send the create fops with gfid-req.

Also fixed the missing trash pid assignment in creates sent by trash
xlator. Without this, truncated files won't be moved to .trashcan.

Change-Id: Ieddd7f0634850e7c7010e4fbb4ad1eead35888c8
BUG: 1491985
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/18302
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

features/shard: Return aggregated size in stbuf of LINK fop

2017-09-17T12:48:22+00:00

        Backport of:
        > Change-Id: I42df7679d63fec9b4c03b8dbc66c5625f097fac0
        > Reviewed-on: https://review.gluster.org/18209
        > BUG: 1488546
        > cherry-picked from 91430817ce5bcbeabf057e9c978485728a85fb2b

Change-Id: I42df7679d63fec9b4c03b8dbc66c5625f097fac0
BUG: 1488719
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/18212
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

features/shard: Increment counts in locks

2017-09-17T12:48:06+00:00

       Backport of https://review.gluster.org/18203

Problem:
Because create_count/eexist_count are incremented without locks, all the shards may not
be created because call_count will be lesser than what it needs to be. This can lead
to crash in shard_common_inode_write_do() because inode on which we want to do
fd_anonymous() is NULL

Fix:
Increment the counts in frame->lock

 >Change-Id: Ibc87dcb1021e9f4ac2929f662da07aa7662ab0d6
 >BUG: 1488354
 >Signed-off-by: Pranith Kumar K 

Change-Id: Ibc87dcb1021e9f4ac2929f662da07aa7662ab0d6
BUG: 1488391
Signed-off-by: Pranith Kumar K 
Reviewed-on: https://review.gluster.org/18206
Smoke: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
CentOS-regression: Gluster Build System

xlators/ganesha : remove ganesha xlator code from 3.10

2017-09-07T11:43:08+00:00

The commit e4a4043 have removed ganesha xlator from glusterfs codebase.
But while reverting back ganesha changes, the Makefile.am in xlators/ganesha
got resurrected.

Change-Id: I6efaacaf1fe426da974608ddac5eae4a43800983
BUG: 1486542
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/18147
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY

refcount: typecast function for calling on free

2017-08-11T11:22:43+00:00

All of the functions called to free the refcounted structure are doing a
typecast from (void*) to their own type taht is being free'd. This
really is not needed and the refcount interface is made a little simpler
without the requirement of typecasting.

With this small improvement in the API, all callers are updated too.

Cherry picked from commit f2ca301bd741e3e3f076cd3f72fcd377bcef2a1a:
> Change-Id: I32473b6d1799f62861d4b2d78ea30c09e6c80ab1
> BUG: 1416889
> Signed-off-by: Niels de Vos 
> Reviewed-on: https://review.gluster.org/16471
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Xavier Hernandez 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 

Backport note: This patch makes it easier to backport changes that use
               gf_refcount_t. There is no functional change.

Change-Id: I32473b6d1799f62861d4b2d78ea30c09e6c80ab1
BUG: 1471870
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17913
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

core: assorted typos and spelling mistakes from Debian lintian

2017-07-01T15:58:24+00:00

Plus minor readability improvements.

Reported-by: pmatthaei@debian.org
master BUG: 1466785
master https://review.gluster.org/17660
release-3.11 BUG: 1466801
release-3.11 https://review.gluster.org/17661
Change-Id: I5393819a2fc9f240a19811143bb57b127df717cf
BUG: 1466852
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17663
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

feature/changelog: Fix buffer overflow crash

2017-06-30T11:45:49+00:00

The buffer used to hold the basename  was hard coded
to the size of NAME_MAX(255). It might lead to buffer
overflow crashes when the basename which is sent
is more than NAME_MAX length. Fixed the same.

> Change-Id: I6c1cad3ccaeb8c55549b1d3c5f96a198f65ba2b7
> BUG: 1463178
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17579
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
(cherry picked from commit b224f4253b7d3de3077ee35c8bdc20618eae4b7c)

Change-Id: I6c1cad3ccaeb8c55549b1d3c5f96a198f65ba2b7
BUG: 1463623
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17592
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Zhou Zhengping 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur

feature/bitrot: Fix ondemand scrub

2017-06-20T04:54:16+00:00

The flag which keeps tracks of whether the scrub
frequency is changed from previous value should
not be considered for on-demand scrubbing. It
should be considered only for 'scrub-frequency'
where it should not be re-scheduled if it is
set to same value again. But in case ondemand
scrub, it should start the scrub immediately
no matter what the scrub-frequency.

Reproducer:
1. Enable bitrot
2. Set scrub-throttle
3. Set ondemand scrub
Make sure glusterd is not restarted while doing
below steps

> Change-Id: Ice5feaece7fff1579fb009d1a59d2b8292e23e0b
> BUG: 1461845
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17552
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra Bhat 
> NetBSD-regression: NetBSD Build System 
(cherry picked from commit f0fb166078d59cab2a33583591b6448326247c40)

Change-Id: Ice5feaece7fff1579fb009d1a59d2b8292e23e0b
BUG: 1462080
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17553
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Talur

features/worm: Adding implementation for ftruncate

2017-04-13T15:37:23+00:00

Problem:
Since the ftruncate fop was not handled in the worm feature, when
truncate and write was happening on a worm-retained/worm file, it was
giving the EROFS error but truncating the file, which is not correct.

> Change-Id: I1a7e904655210d78bce9e01652ac56f3783b5aed
> BUG: 1438810
> Signed-off-by: karthik-us 
> Reviewed-on: https://review.gluster.org/16995
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Niels de Vos 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Ravishankar N 
> Smoke: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Raghavendra Talur 
(cherry picked from commit c5a4a77848024d2adf8cd4f35d550ba90c174fc7)

Change-Id: I815049d37d95597021e11b1e3d25d56bb83623c4
BUG: 1437763
Signed-off-by: karthik-us 
Reviewed-on: https://review.gluster.org/16999
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Shyamsundar Ranganathan

features/shard: Fix vm corruption upon fix-layout

2017-04-13T15:35:57+00:00

Backport of:
> Change-Id: I8a2e97d91ba3275fbc7174a008c7234fa5295d36
> BUG: 1440051
> Reviewed on: https://review.gluster.org/17010
> (cherry-picked from commit 99c8c0b03a3368d81756440ab48091e1f2430a5f)

shard's writev implementation, as part of identifying
presence of participant shards that aren't in memory,
first sends an MKNOD on these shards, and upon EEXIST error,
looks up the shards before proceeding with the writes.

The VM corruption was caused when the following happened:
1. DHT had n subvolumes initially.
2. Upon add-brick + fix-layout, the layout of .shard changed
   although the existing shards under it were yet to be migrated
   to their new hashed subvolumes.
3. During this time, there were writes on the VM falling in regions
   of the file whose corresponding shards were already existing under
   .shard.
4. Sharding xl sent MKNOD on these shards, now creating them in their
   new hashed subvolumes although there already exist shard blocks for
   this region with valid data.
5. All subsequent writes were wound on these newly created copies.

The net outcome is that both copies of the shard didn't have the correct
data. This caused the affected VMs to be unbootable.

FIX:
For want of better alternatives in DHT, the fix changes shard fops to do
a LOOKUP before the MKNOD and upon EEXIST error, perform another lookup.

Change-Id: I8a2e97d91ba3275fbc7174a008c7234fa5295d36
BUG: 1426508
RCA'd-by: Raghavendra Gowdappa 
Reported-by: Mahdi Adnan 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17021
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri