glusterfs.git/xlators/features, branch v3.5.0beta3

features/quota: fix crash in error handling after building ancestry.

2014-02-08T16:22:22+00:00

Change-Id: Ifbebf1aa496d49a6c4bb30258b83aaf9792828e5
BUG: 1059833
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6924
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

quota: get directory size before enforcing quota on rename

2014-02-06T07:05:59+00:00

        Backport of http://review.gluster.org/6155

BUG: 1023974
Change-Id: Icb4bca8c4a5fa9b14855478e69b1315f2e9a3c3d
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/6887
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System

quota: fix recording of last alert log message

2014-02-06T07:05:51+00:00

        Backport of http://review.gluster.org/6532

PROBLEM:

Alert log messages, corresponding to disk usage crossing soft-limit on a
directory, weren't being logged as often as expected.

CAUSE:

The mechanism in place to log alert messages, once every alert-time
seconds, set the previous logged time incorrectly.

FIX:

Update previous logged time only if we logged an alert message, ie. when
the "time was right" to alert.

BUG: 969461
Change-Id: Ie019c180c97d2b049fa664b14ce087b88e3b578f
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/6886
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System

features/marker: Filter quota xattrs on file as well

2014-02-03T04:26:13+00:00

Problem:
Quota contributions of a file/directory are tracked by quota
xlator using xattrs on the file. Quota allows these xattrs to be
healed as part of metadata self-heal. This leads to
wrong quota calculations on this brick after self-heal because
quota xattrs don't represent the actual contributions on the
brick anymore.

Fix:
Don't let self-heal of this xattr happen as part of self-heal
by filtering quota xattrs on file in listxattr.

Change-Id: Iea68a116595ba271e58c6fdcc3dd21c7bb55ebb3
BUG: 1035576
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6374
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6812

mgmt/glusterd: make sure quota enforcer has established connection with quotad before marking quota as enabled.

2014-01-29T06:46:35+00:00

without this patch there is a window of time when quota is marked as
enabled in quota-enforcer, but connection to quotad wouldn't have been
established. Any checklimit done during this period can result in a
failed fop because of unavailability of quotad.

Change-Id: I0d509fabc434dd55ce9ec59157123524197fcc80
Signed-off-by: Raghavendra G 
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6572
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6820

features/quota: Handle the corner case in statfs call

2014-01-29T06:41:59+00:00

Problem: Even though limit is not set quota used to send 'quota-deem-statfs'
key in the dictionary resulting in incorrect calculations.

Change-Id: I643cb35cca6648e40f1c745135280876958ddaa9
BUG: 1046894
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6607
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6840
Reviewed-by: Vijay Bellur

features/quota: Metadata cleanup

2014-01-29T06:39:43+00:00

Quota and marker uses 'trusted.glusterfs.quota*' and 'trusted.pgfid*' xattrs to
store its configurations and accounting information and also to build the
parent inode chain in case of absense of path.

Problem:
After disabling and then enabling quota back, the xattrs may contain stale data
leading to impaired accounting and thus improper enforcement.

Solution:
Clean up all the quota related xattrs after quota disable.

Marker xlator implements a virtual xattr to cleanup quota and pgfid xattrs. In
this approach glusterd mounts an auxiliary mount and sends the below command to
all the files by crawling the mountpoint.

 #setfattr -n "glusterfs.quota-xattr-cleanup" -v 1 

Credit:
Krishnan Parthasarathi 
Varun Shastry          
Change-Id: I9380eca58a285dc27dd572de1767aac8f2cd8049
BUG: 969461
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6369
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6838

features/quota: maintain correct link_count in ancestry building

2014-01-28T16:49:30+00:00

codepath.

Ancestry building codepath can be executed simultaneously when a file
has hardlinks. So, following fixes are needed:

* modify local->link_count under locks in ancestry building codepath.
* before invoking check_limit on newly constructed parents,
  link_count should not be set, but instead incremented by as many
  number of new invocations of check_limit.
* decrementing link_count and the check whether the count has hit zero
  to resume the waiting call_stub should be atomic.

Change-Id: I6f52e50547362a5ded6bd9f085570223aea372d1
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6491
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6819

features/quota: remove in-memory accounting of files in enforcer

2014-01-28T16:47:26+00:00

Accounting was done in enforcer (though marker is the ultimate source
of truth) to offset cached directory size becoming stale. However,
with enforcer being moved to brick we can no longer maintain correct
cluster wide size for a directory. Hence removing accounting code from
enforcer.

Change-Id: I5ea94234da4da85ed5f5ced1354d8de3454b3fcb
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6434
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6818

features/quota: use STACK_WIND_TAIL when quota is turned off.

2014-01-28T16:46:12+00:00

Change-Id: I8a0b7f3a1995a72560c210efbad1eaafb0bdf329
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6373
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6816