glusterfs.git/xlators/features, branch v3.7.2

features/bitrot: fix fd leak in truncate (stub)

2015-06-19T08:37:54+00:00

    Backport of http://review.gluster.org/#/c/11077

The need to perform object versioning in the truncate() code path
required an fd to reuse existing versioning infrastructure that's
used by fd based operations (such as writev(), ftruncate(), etc..).

This tempted the use of anonymous fd which was never ever unref()'d
after use resulting in fd and/or memory leak depending on the code
path taken. Versioning resulted in a dangling file descriptor left
open in the filesystem effecting the signing process of a given
object (no release() would be trigerred, hence no signing would be
performed). On the other hand, cases where the object need not be
versioned, the anonymous fd in still ref()'d resulting in memory
leak (NOTE: there's no "dangling" file descriptor in this case).

Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
BUG: 1232179
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11300
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

libgfchangelog: Fix crash in gf_changelog_process

2015-06-19T07:12:29+00:00

Problem:
    Crash observed in gf_changelog_process and
    gf_changelog_callback_invoker.

Cause:
    Assignments to arguments passed to thread is done
    post thread creation. If the thread created gets
    scheduled before the assignment and access these
    variables, it would crash with segmentation fault.

Solution:
    Assignments to arguments are done prior to the thread
    creation.

BUG: 1233044
Change-Id: I520599ab43026d25f4064ce71bd5a8b8e0d4b90a
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11273
Reviewed-on: http://review.gluster.org/11308
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

quota: fix double accounting with rename operation

2015-06-19T05:33:30+00:00

This is a backport of http://review.gluster.org/#/c/11264/

> When a rename operation is performed, we are renaming
> the file first and performing remove-xattr when reducing
> the contri size from parents.
> This remove-xattr fails as the file is alreday renamed,
> this failure causes reduce-parent-size to abort resulting
> in double quota accounting
>
> This patch fixes the problem. We don't need to perform remove-xattr
> operation on a file when performing reduce-parent-size txn as this
> will be alreday done before starting reduce-parent-size txn
>
> Change-Id: If86e3dbb0233f6deaaa90bee72cb0ec1689c7325
> BUG: 1232572
> Signed-off-by: vmallika 

Change-Id: I7b12962d731ce9acf3ac78a99b2c23491722b78a
BUG: 1233117
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11312
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

features/bitrot: tuanble object signing waiting time value for bitrot

2015-06-17T16:38:59+00:00

 Currently bitrot using 120 second waiting time for object to be signed
 after all fop's released. This signing waiting time value should be tunable.

 Command for changing the signing waiting time will be
 #gluster volume bitrot  signing-time 

Change-Id: I89f3121564c1bbd0825f60aae6147413a2fbd798
BUG: 1231832
Signed-off-by: Gaurav Kumar Garg 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11105
(cherry picked from commit 554fa0c1315d0b4b78ba35a2d332d7ac0fd07d48)
Reviewed-on: http://review.gluster.org/11235
Tested-by: Gluster Build System

quota: don't log error when disk quota exceeded

2015-06-17T12:16:23+00:00

This is a backport of http://review.gluster.org/#/c/11135

> When disk quota exceeded, quota enforcer logs
> alert message, so no need to log error message
> as this can fill up the log file
>
> Change-Id: Ia913f47bc0cedb7c0a9c611330ee5124d3bb6c9d
> BUG: 1229609
> Signed-off-by: vmallika 

Change-Id: I7b0b91965d8eb1b38ef6fa5ce0276a6b6da3372d
BUG: 1232135
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11242
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

changetimerecorder : port log messages to a new framework

2015-06-17T08:12:14+00:00

        Backport of http://review.gluster.org/#/c/10938/

Cherry picked from 00f9a61fe8884062c141edd662424625d349a377
>Change-Id: I66e7ccc5e62482c3ecf0aab302568e6c9ecdc05d
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10938
>Tested-by: Gluster Build System 
>Reviewed-by: Joseph Fernandes
>Signed-off-by: Mohamed Ashiq 

Change-Id: I66e7ccc5e62482c3ecf0aab302568e6c9ecdc05d
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11195
Tested-by: Gluster Build System 
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes

upcall: prevent busy loop in reaper thread

2015-06-15T09:29:07+00:00

http://review.gluster.org/10342 introduced a cleanup thread for expired
client entries. When enabling the 'features.cache-invalidation' volume
option, the brick process starts to run in a busy-loop. Obviously this
is not intentional, and a process occupying 100% of the cycles on a CPU
or core is not wanted.

Cherry picked from commit a367d4c6965e1f0da36f17ab6c5fdbd37925ebdd)\:
> Change-Id: I453c612d72001f4d8bbecdd5ac07aaed75b43914
> BUG: 1200267
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11198
> Reviewed-by: soumya k 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: I453c612d72001f4d8bbecdd5ac07aaed75b43914
BUG: 1231516
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11211
Tested-by: Gluster Build System 
Reviewed-by: soumya k

features/changelog: Do htime setxattr without XATTR_REPLACE flag

2015-06-12T18:37:43+00:00

HTIME_KEY marks the last changelog rolled over. The xattr is
maintained on .glusterfs/changelog/htime/HTIME.TSTAMP file.
On every rollover of the changelog file, the xattr is updated.
It is being updated with XATTR_REPLACE flag as xattr gets
created during changelog enable. But it is once found that
the xattrs on the file is cleared and is not reproduced later
on. This patch protects that case, if it happens by setting
xattr without XATTR_REPLACE flag in failure case.

The reason behind doing this in failure case is not to mask
the actual cause of xattrs getting cleared. This provides
the log message if the original issue still exists but the
consequential effects are fixed.

Also changed the log messages to depict the events happened
during changelog enable.

Change-Id: I699ed09a03667fd823d01d65c9c360fa7bc0e455
BUG: 1230694
Reviewed-On: http://review.gluster.org/#/c/11150/
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11181
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/qemu-block: Don't unref root inode

2015-06-12T08:57:50+00:00

        Backport of http://review.gluster.org/11002
                    http://review.gluster.org/11076

Root inode doesn't participate in ref/unref. Don't do it
in fini as by the time fini is called itable would be destroyed.

BUG: 1226272
Change-Id: I776d8e9359c8b51763d9d2588a80311434a0ede3
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11047
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Poornima G

features/changelog: Avoid setattr fop logging during rename

2015-06-12T05:26:16+00:00

Problem:
        When a file is renamed and the (renamed)file's Hashing
falls into a different brick, DHT creates a special file(linkto file)
in the brick(Hashed subvolume) and carries out setattr operation
on that file.

Currently, Changelog records this(setattr) operation in Hashed
subvolume. glusterfind in turn records this operation
as MODIFY operation.

So, there is a NEW entry in Cached subvolume and MODIFY entry
in Hashed subvolume for the same file.

Solution:
        Avoid logging setattr operation carried out, by
marking the operation as internal fop using xdata.

In changelog translator, check whether setattr is set
as internal fop and skip accordingly.

Change-Id: I21b09afb5a638b88a4ccb822442216680b7b74fd
BUG: 1230687
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/11183
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G