glusterfs.git/xlators/features, branch v3.8.4

feature/bitrot: Fix recovery of corrupted hardlink

2016-09-09T14:05:06+00:00

Problem:
When a file with hardlink is corrupted in ec volume,
the recovery steps mentioned was not working.
Only name and metadata was healing but not the data.

Cause:
The bad file marker in the inode context is not removed.
Hence when self heal tries to open the file for data
healing, it fails with EIO.

Background:
The bitrot deletes inode context during forget.

Briefly, the recovery steps involves following steps.
   1. Delete the entry marked with bad file xattr
      from backend. Delete all the hardlinks including
      .glusters hardlink as well.
   2. Access the each hardlink of the file including
      original from the mount.

The step 2 will send lookup to the brick where the files
are deleted from backend and returns with ENOENT. On
ENOENT, server xlator forgets the inode if there are
no dentries associated with it. But in case hardlinks,
the forget won't be called as dentries (other hardlink
files) are associated with the inode. Hence bitrot stube
won't delete it's context failing the data self heal.

Fix:
Bitrot-stub should delete the inode context on getting
ENOENT during lookup.

>Change-Id: Ice6adc18625799e7afd842ab33b3517c2be264c1
>BUG: 1373520
>Signed-off-by: Kotresh HR 
>Reviewed-on: http://review.gluster.org/15408
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Raghavendra Bhat 
(cherry picked from commit b86a7de9b5ea9dcd0a630dbe09fce6d9ad0d8944)


Change-Id: Ice6adc18625799e7afd842ab33b3517c2be264c1
BUG: 1374565
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/15433
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat

build: correctly format some (s)size_t messages

2016-09-07T14:00:48+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

Cherry picked from commit 3af889f02722f4636d2ea30570de6477e8b5a3a9:
> BUG: 1198849
> Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14933
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Smoke: Gluster Build System 

This patch is not really recommended for backporting, but we do have a
new smoke test that fails when these warnings pop-up. It is cleaner to
correct the code in the release-3.7 branch then to modify the smoke test
to skip this branch.

Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
BUG: 1373530
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15410
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

features/upcall: segment fault while join thread reaper_thr in fini()

2016-09-05T09:07:18+00:00

reaper_thr thread may not be started according to option
'cache-invalidation', if it's not started, join it in fini will cause a
segment fault.

Cherry picked from commit 7f0042dce94edb58c92662d9e4f852ba006d12dc:
> Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
> BUG: 1369524
> Signed-off-by: Ryan Ding 
> [ndevos: check .reaper_init_done and make it a boolean]
> Reviewed-on: http://review.gluster.org/15298
> Smoke: Gluster Build System 
> Reviewed-by: soumya k 
> Reviewed-by: Niels de Vos 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
BUG: 1371194
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15336
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ryan Ding 
Reviewed-by: soumya k

features/locks: fix fdctx leak in locks xlators

2016-08-26T15:02:49+00:00

Problem:
Locks xlators is leaking fdctx in pl_release when
inode_ctx_get return non-zero

Fix:
This patch fixes fdctx leak in pl_release path

> Reviewed-on: http://review.gluster.org/15302
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Pranith Kumar Karampuri 
> Tested-by: Pranith Kumar Karampuri 

Change-Id: Icd5c5c681b7d890e7971b3b06d4258a51d45097d
BUG: 1370390
Signed-off-by: Yanping.gao 
Signed-off-by: Oleksandr Natalenko 
Reviewed-on: http://review.gluster.org/15323
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

arbiter: Fix memleak in arbiter_inode ctx

2016-08-24T21:51:05+00:00

Backport of http://review.gluster.org/#/c/15289/

Problem:
The iattbuf ptr stored in arbiter's inode context was not freed during inode
forget.

Fix:
Change it to a statically allocated value so that we don't have to deal
with allocating/freeing it.

Change-Id: Id1b73b8aee1fb5c4174d0734bd20e168432b1abd
BUG: 1369748
Reported-by: Benjamin Edgar 
Signed-off-by: Ravishankar N 

(cherry picked from commit 4aa52061a51b97c4f865b402f977b3b43f5471a7)

Change-Id: I1c2d5c8d0f4222ec6ef16b1740e6daf956212d6f
Reviewed-on: http://review.gluster.org/15306
Tested-by: Ravishankar N 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

quota: change the log level from warning to info

2016-08-24T10:52:41+00:00

This is a backport of http://review.gluster.org/#/c/14940/

> Change-Id: Icac7d87bb6c5ecc813528690e03c821bbe3789b5
> BUG: 1357463
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/14940
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Prashanth Pai 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Vijay Bellur 

Change-Id: I4c4afb0d32b3bce764a4eb88f8d403f4dad10d8f
BUG: 1368927
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/15229
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G

snapshot/uss: client log is filled with "invalid argument: inode" error

2016-08-22T08:53:05+00:00

svc_inode_ctx_get is called even if inode is NULL. We should not call
this function if inode is NULL

> BUG: 1339149
> Signed-off-by: Rajesh Joseph 
> Reviewed-on: http://review.gluster.org/14525
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
(cherry picked from commit edcc6a4ef4f39d5e3073195d45011e3cdfa7c091)

BUG: 1367297
Signed-off-by: Rajesh Joseph 
Change-Id: I5c3f17633ca88e5b6f40d4acf14a09e14b7ef62b
Reviewed-on: http://review.gluster.org/15170
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Tested-by: Avra Sengupta 
Reviewed-by: Avra Sengupta 
Reviewed-by: Niels de Vos

snapshot/uss: client-side log is filled with "invalid-argument" error

2016-08-22T08:52:54+00:00

xdata is used without checking if it is NULL or not.


> BUG: 1339149
> Signed-off-by: Rajesh Joseph 
> Reviewed-on: http://review.gluster.org/14511
> Smoke: Gluster Build System 
> Reviewed-by: Raghavendra Talur 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
(cherry picked from commit f55a973e581aaa25bbe38be83e007e1b2eaed659)

BUG: 1367297
Signed-off-by: Rajesh Joseph 
Change-Id: Ib6ddaab28ec3b430b8d646aada0456d3cc9978cb
Reviewed-on: http://review.gluster.org/15171
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Niels de Vos

features/libgfchangelog: Log failure in gf_histroy_changelog

2016-08-19T06:05:25+00:00

Add error logs if gf_history_changelog fails. If requested
changelog range is not available, log the error and exit
instead of continuing the loop and exiting in readdir
without logging. Also fixed the duplicate MSGID number in
'changelog-lib-messages.h'

> Change-Id: Icd71b89ae23b48a71380657ba5649029c32fabfd
> BUG: 1362151
> Signed-off-by: Kotresh HR 
> Reviewed-on: http://review.gluster.org/15064
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 

Change-Id: Icd71b89ae23b48a71380657ba5649029c32fabfd
BUG: 1365879
Signed-off-by: Kotresh HR 
(cherry picked from commit 949472d7561d3bfd67d8204e433a25dbc8a596cc)
Reviewed-on: http://review.gluster.org/15138
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK

snapshot/uss: log is filled with gfid is NULL error

2016-08-19T04:39:37+00:00

In snapview-server if the lookup came on missing entry
then it does not have proper context to see if it is the
case of "Stale file handle" or ENOENT. We should not log
this error in GF_LOG_ERROR level, instead this should be
a debug log.


> BUG: 1339149
> Signed-off-by: Rajesh Joseph 
> Reviewed-on: http://review.gluster.org/14514
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
(cherry picked from commit dca1c08c6384e34403d8b5ad6eaf0931529168ac)

BUG: 1367297
Signed-off-by: Rajesh Joseph 
Change-Id: I8f7cc0e117e9a6dd9482da2e94a56f2ed731a442
Reviewed-on: http://review.gluster.org/15166
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Atin Mukherjee