glusterfs.git/xlators/mgmt/glusterd/src/glusterd-brick-ops.c, branch v3.8rc2

cli/glusterd: add/remove brick fixes for arbiter volumes

2016-05-24T08:35:57+00:00

Backport of: http://review.gluster.org/14126

1.Provide a command to convert replica 2 volumes to arbiter volumes.
Existing self-heal logic will automatically heal the file hierarchy into
the arbiter brick, the progress of which can be monitored using the
heal info command.

Syntax: gluster volume add-brick  replica 3 arbiter 1


2. Add checks when removing bricks from arbiter volumes:
- When converting from arbiter to replica 2 volume, allow only arbiter
  brick to be removed.
- When converting from arbiter to plain distribute volume, allow only if
  arbiter is one of the bricks that is removed.

3. Some clean-up:
- Use GD_MSG_DICT_GET_SUCCESS instead of GD_MSG_DICT_GET_FAILED to
log messages that are not failures.
- Remove unused variable `brick_list`
- Move 'brickinfo->group' related functions to glusted-utils.

Change-Id: Ifa75d137c67ffddde7dcb8e0df0873163e713119
BUG: 1337387
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/14502
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: copy real_path from older brickinfo during brick import

2016-05-20T09:33:10+00:00

Backport of http://review.gluster.org/14306

In glusterd_import_new_brick () new_brickinfo->real_path will not be populated
for the first time and hence if the underlying file system is bad for the same
brick, import will fail resulting in inconsistent configuration data.

Fix is to populate real_path from old brickinfo object.

Also there were many cases where we were unnecessarily calling realpath() and
that may cause in failure. For eg - if a remove brick is executed with a brick
whoose underlying file system has crashed, remove-brick fails since realpath()
call fails. We'd need to call realpath() here as the value is of no use.Hence
passing construct_realpath as _gf_false in glusterd_volume_brickinfo_get_by_brick ()
is a must in such cases.

Change-Id: I7ec93871dc9e616f5d565ad5e540b2f1cacaf9dc
BUG: 1337114
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14306
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/14411

glusterd: remove-brick commit should not succeed when migration failed

2016-05-05T13:30:31+00:00

While remove a brick if the data migration was not successful,
remove-brick commit should not succeed as this can lead to
data loss.

Backport of http://review.gluster.org/#/c/12513/

> Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
> BUG: 1278325
> Signed-off-by: Sakshi Bansal 
> Reviewed-on: http://review.gluster.org/12513
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Tested-by: Atin Mukherjee 

Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
BUG: 1332370
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/14190
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System

glusterd: populate brickinfo->real_path conditionally

2016-04-11T18:39:16+00:00

glusterd_brickinfo_new_from_brick () is called from multiple places and one of
them is glusterd_brick_rpc_notify where its very well possible that an
underlying brick's file system has crashed and a disconnect event has been
received. In this case glusterd tries to build the brickinfo from the brickid in
the RPC request, however the same fails as glusterd_brickinfo_new_from_brick ()
fails from realpath.

Fix is to skip populating real_path if its a disconnect event.

Change-Id: I9d9149c64a9cf2247abb731f219c1b1eef037960
BUG: 1325841
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13965
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

glusterd / afr : Enable auto heal when replica count increases

2016-03-21T17:51:00+00:00

In replicate volumes, when a brick is added to a replicate
group, heal to the new brick should be triggered.
Also, the new brick should not be considered as source for
healing till it is up to date.

Previously, extended attributes had to be set manually on
the bricks for this to happen. This patch is part 1 patch
to automate this process.

Change-Id: I29958448618372bfde23bf1dac5dd23dba1ad98f
BUG: 1276203
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/12451
Reviewed-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ravishankar N 
Smoke: Gluster Build System

Tier: making detach start fail when brick on hot tier is down

2016-03-03T11:51:14+00:00

Currently detach tier start happens even when a hot brick is down
this might lead to data loss.

This patch prevents the detach tier start from being executed
successfully if a brick in hot tier is down

Change-Id: I3b6047a44bd01b8a6887d41f799f64de6bf075ef
BUG: 1309999
Signed-off-by: hari 
Reviewed-on: http://review.gluster.org/13474
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Gaurav Kumar Garg 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd/tier: Reset to reconfigured values after detach-tier

2015-11-26T19:39:17+00:00

After detach-tier commit , we have to reset the option
reconfigured for tier volume

Change-Id: Iae0210259720d6ac14ccc0cc339dc9f54a0c4571
BUG: 1285046
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12736
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

cluster/tier make cache mode default for tiered volumes

2015-11-17T12:18:17+00:00

The default mode for tiered volumes must be cache. The current
test mode was for engineering and should ordinarily not be used
by customers.

Change-Id: I20583f54a9269ce75daade645be18ab8575b0b9b
BUG: 1282076
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/12581
Tested-by: Gluster Build System 
Reviewed-by: mohammed rafi  kc

cluster/tier: Disallow detach commit when detach in progress

2015-11-16T12:10:02+00:00

1. Check if detach is running, disallow detach commit if so.
2. Cleanup shutdown of tier daemon on detach: do not rerun fix-layout,
   do not send incorrect status back to glusterd.

Change-Id: I97202f748773c1176396a4ffd32a4c7fa9b9c1bc
BUG: 1279637
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/12560
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: brick failed to start

2015-11-16T09:19:58+00:00

brick volfiles are generated in post validate, if
it is running version higher than GLUSTER_3_7_5,
else will be running in syncop.

If the code fall back to syncop, and volume is stopped
then we were returning the operation with out generating
volfiles.

Change-Id: I3b16ee29de19c5d34e45d77d6b7e4b665c2a4653
BUG: 1282322
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12552
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee