glusterfs.git/xlators/mgmt/glusterd/src/glusterd-ganesha.c, branch v3.8.8

glusterd/ganesha : persist value set by teardown in info file

2016-07-04T05:39:18+00:00

During teardown, all the volumes exported via NFS-Ganesha will be
unexported. So all related volume options need to reset. Currently
this change made using dict_set on volopt dictionary, i.e change
is only reflected in memory not persisted in the volume info file
Therefore incase of glusterd restart this data can be lost.

Also this patch fix similar issue in ganesha_manage_export().

Upstream reference :
>Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
>BUG: 1349270
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14778
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaleb KEITHLEY 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 16c34b101f604a09a5c735fb39815c59ee4ecbdb)

Change-Id: Ib843ac30adb28a70e13a9a1df57020ef2f3db8a4
BUG: 1351151
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14831
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd-ganesha : copy ganesha export configuration files during reboot

2016-05-18T13:55:39+00:00

glusterd creates export conf file for ganesha using hook script during
volume start and ganesha_manage_export() for volume set command. But this
routine is not added in glusterd restart scenario.
Consider the following case, in a three node cluster a volume got exported
via ganesha while one of the node is offline(glusterd is not running).
When the node comes back online, that volume is not exported on that node
due to the above mentioned issue.
Also I have removed unused variables from glusterd_handle_ganesha_op()
For this patch to work pcs cluster should running on that be node.

Upstream reference
>Change-Id: I5b2312c2f3cef962b1f795b9f16c8f0a27f08ee5
>BUG: 1330097
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14063
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: soumya k 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit f71e2fa49af185779b9f43e146effd122d4e9da0)

Change-Id: I5b2312c2f3cef962b1f795b9f16c8f0a27f08ee5
BUG: 1336801
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14397
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd: default value of nfs.disable, change from false to true

2016-04-27T07:59:30+00:00

Next step in eventual deprecation of glusterfs nfs server in favor
of ganesha.nfsd.

Also replace several open-coded strings with constant.

Change-Id: If52f5e880191a14fd38e69b70a32b0300dd93a50
BUG: 1092414
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13738
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Tested-by: Atin Mukherjee 
Reviewed-by: Niels de Vos

glusterd: remove unused large memory/buffer allocations

2016-03-24T09:28:22+00:00

This patch cleans dead buffer allocations which are never used in the
code.

Change-Id: I8c55837434fd5bf9dde9fb7b070fdefbf64cf4a3
BUG: 1253828
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/11928
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee

ganesha: coverity fix in glusterd-ganesha.c

2016-03-07T13:18:29+00:00

CID 1351698

Allocating buffer of size stat.st_size) to read lines from the file
without an overrrun feels like a bit of a  hack. While it's extremely
unlikely that the file would ever be more than a thousand bytes long,
a) we don't want to use bad patterns (and set bad examples or
precedents for elsewhere in the source), and b) what if somehow the
file did become "large." We just don't want to ever risk allocating
huge amounts of memory by accident.

And all the superfluous logic to copy the resulting string? We have
gf_strdup() for that.

And a clean coverity. See following gerrit review comments for the URL.

Change-Id: I5860d6995d0eed06667fd2369df6be53ccff6ceb
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13614
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

all: fixes for clang compile warnings

2016-02-15T09:32:26+00:00

cli/src/cli-cmd-parser.c (chenk)
cli/src/cli-xml-output.c (spandit)
cli/src/cli.c (chenk)
libglusterfs/src/common-utils.c (vmallika)
libglusterfs/src/gfdb/gfdb_sqlite3.c (jfernand +1)
rpc/rpc-transport/socket/src/socket.c (?)
xlators/cluster/afr/src/afr-transaction.c (?)
xlators/cluster/dht/src/dht-common.h (srangana +2)
xlators/cluster/dht/src/dht-selfheal.c (srangana +2)
xlators/debug/io-stats/src/io-stats.c (R. Wareing)
xlators/features/barrier/src/barrier.c (vshastry)
xlators/features/bit-rot/src/bitd/bit-rot-scrub.h (vshankar +1)
xlators/features/shard/src/shard.c (kdhananj +1)
xlators/mgmt/glusterd/src/glusterd-ganesha.c (skoduri)
xlators/mgmt/glusterd/src/glusterd-handler.c (atinmu)
xlators/mgmt/glusterd/src/glusterd-op-sm.h (atinmu)
xlators/mgmt/glusterd/src/glusterd-snapshot.c (spandit)
xlators/mgmt/glusterd/src/glusterd-syncop.c (atinmu)
xlators/mgmt/glusterd/src/glusterd-volgen.c (atinmu)
xlators/protocol/client/src/client-messages.h (mselvaga +1)
xlators/storage/bd/src/bd-helper.c (M. Mohan Kumar)
xlators/storage/bd/src/bd.c (M. Mohan Kumar)
xlators/storage/posix/src/posix.c (nbalacha +1)

Change-Id: I85934fbcaf485932136ef3acd206f6ebecde61dd
BUG: 1293133
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13031
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System

glusterd-ganesha xlator parser for ganesha-ha.conf

2015-12-01T19:24:25+00:00

The current method for parsing ganesha-ha.conf is prone to issues :
Before the patch :
- no double quote leads to segfault
   e.g. : HA_CLUSTER_NODES=server1,server2
- no check for comments.
   e.g. : #HA_CLUSTER_NODES="server1,server2"
      would be used if preceding the real value

This is an attempt to a cleaner parser:
1- factorization of parsing code, creating 1 dedicated, more generic
parser
2- double quote are no longer mandatory
3- should not segfault
4- lines are no longer limited to 1024 chars

Resolves RHBZ 1283211

Change-Id: I75f11461fe1b84915d1c5cfe945b47bd81abc2b1
BUG: 1283211
Signed-off-by: Cedric Buissart 
Reviewed-on: http://review.gluster.org/12588
Tested-by: NetBSD Build System 
Reviewed-by: jiffin tony Thottan 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

core: use syscall wrappers instead of direct syscalls -- glusterd

2015-10-28T13:55:04+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: I28bf2a5f7730b35914e7ab57fed91e1966b30073
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12379
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd: initialize the daemon services on demand

2015-07-27T07:14:01+00:00

As of now all the daemon services are initialized at glusterD init path. Since
socket file path of per node daemon demands the uuid of the node, MY_UUID macro
is invoked as part of the initialization.

The above flow breaks the usecases where a gluster image is built following a
template could be Dockerfile, Vagrantfile or any kind of virtualization
environment. This means bringing instances of this image would have same UUIDs
for the node resulting in peer probe failure.

Solution is to lazily initialize the services on demand.

Change-Id: If7caa533026c83e98c7c7678bded67085d0bbc1e
BUG: 1238135
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11488
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Gaurav Kumar Garg 
Reviewed-by: Kaushal M

glusterd: Porting left out log messages to new framework

2015-06-27T06:32:01+00:00

Change-Id: I70d40ae3b5f49a21e1b93f82885cd58fa2723647
BUG: 1235538
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/11388
Tested-by: NetBSD Build System 
Reviewed-by: Anand Nekkunti 
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M