glusterfs.git/xlators/mgmt/glusterd/src/glusterd-geo-rep.c, branch v3.8.11

glusterd/geo-rep: Fix geo-rep config issue

2017-01-08T11:00:57+00:00

Problem:
Geo-replication config commands fail when geo-rep
status is in 'Created'.

Cause:
During staging phase of geo-rep config, it checks
for the existence of 'monitor.pid' file. But the
pid file gets created only on start of geo-rep.
Hence it fails.

Fix:
Do not check for the existence of pid-file during
staging for config commands. It is not required.

> Change-Id: I626d368b249cf0423c7f49b4284465508371f566
> BUG: 1404678
> Signed-off-by: Kotresh HR 
> Reviewed-on: http://review.gluster.org/16132
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 
> Reviewed-by: Atin Mukherjee 

Change-Id: I626d368b249cf0423c7f49b4284465508371f566
BUG: 1410699
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16342
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos

glusterd (geo-rep): fix unused variable warnings/errors

2017-01-08T10:59:21+00:00

This patch fixes the fd leak when geo-rep config
command is run while geo-rep is running.

NOTE:
The patch is backport of http://review.gluster.org/15263
which was one of the collection of patches to fix the
bug https://bugzilla.redhat.com/show_bug.cgi?id=1369124

> Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
> BUG: 1369124
> Signed-off-by: Kaleb S. KEITHLEY 
> Reviewed-on: http://review.gluster.org/15263
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Saravanakumar Arumugam 

Change-Id: I2edacd3d0f3924b1be0f0398ba9ac076459c5a61
BUG: 1410708
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16344
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System

geo-rep: Do not restart workers when log-rsync-performance config change

2016-12-30T05:15:59+00:00

Geo-rep restarts workers when any of the configurations changed. We
don't need to restart workers if tunables like log-rsync-performance
is modified.

With this patch, Geo-rep workers will get new "log-rsync-performance"
config automatically without restart.

> Reviewed-on: http://review.gluster.org/15816
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Kotresh HR 

BUG: 1402728
Change-Id: I40ec253892ea7e70c727fa5d3c540a11e891897b
Signed-off-by: Aravinda VK 
(cherry picked from commit a268e2865c21ec8d2b4fed26715e986cfcc66fad)
Reviewed-on: http://review.gluster.org/16069
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR

glusterd/geo-rep: Fix glusterd crash

2016-12-14T07:09:14+00:00

Problem:
glusterd crashes when geo-rep mountbroker setup is
created if the slave user length is more than
8 characters.

Cause:
_POSIX_LOGIN_NAME_MAX is used which is 9 including
NULL byte.

Analysis:
While the man page says it sufficient for portability, but
acutally it's not. Linux allows the creation of username
upto 32 characters by default where the max length is 256.
And NetBSD's max is 17.

Linux:
  #getconf LOGIN_NAME_MAX
   256
NetBSD:
  #getconf LOGIN_NAME_MAX
   17

Fix:
Use LOGIN_NAME_MAX instead of _POSIX_LOGIN_NAME_MAX

>Reviewed-on: http://review.gluster.org/16053
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Aravinda VK 
>Reviewed-by: Atin Mukherjee 

Change-Id: I26b7230433ecbbed6e6914ed39221a478c0266a8
BUG: 1403109
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/16085
Tested-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

glusterd/geo-rep: Handle empty monitor.status during upgrade

2016-08-19T10:46:52+00:00

Problem:
Consider geo-replication is in Stopped state.
Following which, glusterfs is upgraded (where monitor.status is the 
new status file).

Now, When geo-replication status command is run,
empty monitor status file gets created.

Now, if glusterd is restarted, it reads empty monitor status
and  starts geo-replication session. This is incorrect as session
was in Stopped state earlier.

Solution:
If monitor status is empty, error out and avoid
starting geo-replication session.

Note: if monitor status is empty, geo-rep session is displayed
as Stopped state.

Change-Id: Ifb3db896e5ed92b927764cf1163503765cb08bb4
BUG: 1368053
Signed-off-by: Saravanakumar Arumugam 
> Reviewed-on: http://review.gluster.org/14830
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Jeff Darcy 
(cherry picked from commit f938b3a26ffab9482d5f910ee76d2bb2b370517f)
Reviewed-on: http://review.gluster.org/15196
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

georep: add reset-sync-time option for session delete

2016-08-03T09:32:27+00:00

Set the stime xattr at all the brick roots to (0,0) if the argument
reset-sync-time has been provided on the command-line.
To avoid testing against directory specific stime, the remote
stime is assumed to be minus_infinity, if the root directory
stime is set to (0,0), before the directory scan begins.
This triggers a full volume resync to slave in the case of a
geo-rep session recreation with the same master-slave volume
pair.

Command synopsis:
gluster volume geo-replication  :: delete \
    [reset-sync-time]

Update gluster cli man page to include new sub-command reset-sync-time.

> Reviewed-on: http://review.gluster.org/14051
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Aravinda VK 
> Reviewed-by: Kotresh HR 

(cherry picked from commit 70fd68d94f768c098b3178c151fa92c5079a8cfd)

Change-Id: Ie4ce03b9425ed9bb81eda8681058c0fc6f990948
BUG: 1357773
Signed-off-by: Milind Changire 
Reviewed-on: http://review.gluster.org/14953
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK 
Reviewed-by: Niels de Vos

glusterd/geo-rep: Add relative path validation to copy file command

2016-07-05T11:58:48+00:00

Added validation for input file, command fails if input file path is
relative path pointing outside of GLUSTERD_WORKDIR.

BUG: 1350785
Change-Id: I329d43ebed69bfe9fe03d6be70dc8c78a605ffc5
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/14772
(cherry picked from commit 888de8851e718d8e3117e47fa35cfc075b998f62)
Reviewed-on: http://review.gluster.org/14819
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()

2016-06-17T09:30:55+00:00

SuSE build system post-compile analysis aborts pkg build due to
unsafe strcat, strncat usage.

mainline
>    BUG: 1347354
>    http://review.gluster.org/14745

Change-Id: I52ac41e1172d0c1e5695a91b9f731cc9e7de4db4
BUG: 1347355
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14746
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Avra Sengupta

glusterd/geo-rep: Avoid started status check if same host

2016-06-13T14:40:04+00:00

After carrying out add-brick, session creation is carried out
again, to involve new brick in the session. This needs to be done,
even if the session is in Started state.

While involving slave uuid as part of a session, User is warned
if session is in Started state. This check needs to be avoided
if it is same slave host and session creation needs to be proceeded.

> Change-Id: Ic73edd5bd9e3ee55da96f5aceec0bafa14d3f3dd
> BUG: 1342979
> Signed-off-by: Saravanakumar Arumugam 
> Reviewed-on: http://review.gluster.org/14653
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 
(cherry picked from commit c62493efadbcf5085bbd65a409eed9391301c154)

Change-Id: Ic73edd5bd9e3ee55da96f5aceec0bafa14d3f3dd
BUG: 1344607
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/14711
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

glusterd/geo-rep: upgrade path when slave vol uuid involved

2016-06-13T10:36:56+00:00

slave volume uuid is involved in identifying a geo-replication
session.

This patch addresses upgrade path, where existing geo-rep session
is gracefully upgraded to involve slave volume uuid.

Change-Id: Ib7ff5109b161592f24fc86fc7e93a407655fab86
BUG: 1342452
Reviewed-on: http://review.gluster.org/#/c/14425/
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/14640
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK