glusterfs.git/xlators/mgmt/glusterd/src/glusterd-handshake.c, branch v5.11

glusterd-handshake: prevent a buffer overflow

2018-11-08T15:47:43+00:00

as key size in xdr can be anything, it can be bigger than the
'NAME_MAX' allowed in the structure, which can allow for service denial
attacks.

Fixes: CVE-2018-14653

Fixes: bz#1647664
Change-Id: I2dc5e99af27ddf44c12c94b07e51adb8674cce80
Signed-off-by: Amar Tumballi

mgmt/glusterd: use proper path to the volfile

2018-10-05T14:24:35+00:00

Till now, glusterd was generating the volfile path for the snapshot
volume's bricks like this.

/snaps//

But in reality, the path to the brick volfile for a snapshot volume is

/snaps///

The above workaround was used to distinguish between a mount command used
to mount the snapshot volume, and a brick of the snapshot volume, so that
based on what is actually happening, glusterd can return the proper volfile
(client volfile for the former and the brick volfile for the latter). But,
this was causing problems for snapshot restore when brick multiplexing is
enabled. Because, with brick multiplexing, it tries to find the volfile
and sends GETSPEC rpc call to glusterd using the 2nd style of path i.e.

/snaps///

So, when the snapshot brick (which is multiplexed) sends a GETSPEC rpc
request to glusterd for obtaining the brick volume file, glusterd was
returning the client volume file of the snapshot volume instead of the
brick volume file.

Change-Id: I28b2dfa5d9b379fe943db92c2fdfea879a6a594e
fixes: bz#1636162
Signed-off-by: Raghavendra Bhat 
(cherry picked from commit 83a89296a3d12a3fc2a643c0630be5ce659204ea)

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu

multiple xlators (mgmt): strncpy()->sprintf(), reduce strlen()'s

2018-09-07T16:17:18+00:00

xlators/mgmt/glusterd/src/glusterd-geo-rep.c
xlators/mgmt/glusterd/src/glusterd-handshake.c
xlators/mgmt/glusterd/src/glusterd-sm.c
xlators/mgmt/glusterd/src/glusterd-store.c
xlators/mgmt/glusterd/src/glusterd-utils.c
xlators/mgmt/glusterd/src/glusterd-volgen.c
xlators/mgmt/glusterd/src/glusterd-volume-ops.c
xlators/mgmt/glusterd/src/glusterd.c

strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.

Instead, use snprintf(). Try to ensure output is not
truncated.

Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.

Compile-tested only!

Change-Id: Ib5d001857236f43e41c4a51b5f48e1a33110aaeb
updates: bz#1193929
Signed-off-by: Yaniv Kaul

xlators/mgmt/glusterd/src/glusterd-handshake.c : reduce size or re-scope message variable

2018-08-23T04:19:46+00:00

The the error and/or message variable was either:
- Reduced in size - from 2048 bytes to 64 bytes, for example.
or
- Changed in scope - defined in a smaller scope.

Compile-tested only!

Change-Id: I9c609415667844ee034b7eb2b67bdbc19d38819d
updates: bz#1193929
Signed-off-by: Yaniv Kaul

mgmt/glusterd: Fix resource leaks in glusterd-handshake.c

2018-08-23T03:44:30+00:00

Addresses the following CIDs:

1124768: fd leak in __server_getspec() if spec_fd happens to be 0
1202400: Memory leak in get_snap_volname_and_volinfo()
1214622: Memory leak in glusterd_create_missed_snap()
1214623: Memory leak in an error path of __server_get_volume_info()

Change-Id: I33910b4125d25205e76e0d13cf0256d47bd8fc3c
updates: bz#789278
Signed-off-by: Vijay Bellur

glusterd: Coverity issues with type FORWARD_NULL

2018-07-24T23:55:12+00:00

This patch fixes coverity issues 102, 103, 112 and 119 from [1]

[1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/

Updates: bz#789278

Change-Id: I99762eb0bcbd974a5250434777db63520f2ce2e6
Signed-off-by: Sanju Rakonde

Fix compile warnings

2018-07-10T14:28:24+00:00

This patch fixes compile warnings that appear with newer compilers. The
solution applied is only to remove the warnings, but it doesn't always
solve the problem in the best way. It assumes that the problem will never
happen, as the previous code assumed.

Change-Id: I6e8470d6c2e2dbd3bd7d324b5fd2f92ffdc3d6ec
updates: bz#1193929
Signed-off-by: Xavi Hernandez

glusterd: connect to an existing brick process when qourum status is NOT_APPLICABLE_QUORUM

2018-01-05T07:31:43+00:00

First of all, this patch reverts commit 635c1c3 as the same is causing a
regression with bricks not coming up on time when a node is rebooted.
This patch tries to fix the problem in a different way by just trying to
connect to an existing running brick when quorum status is not
applicable.

Change-Id: I0efb5901832824b1c15dcac529bffac85173e097
BUG: 1509845
Signed-off-by: Atin Mukherjee

glusterd : Fix glusterd mem leaks

2017-12-12T12:08:30+00:00

Problem:   glusterd eats a huge amount of meory during volume set/stop/start.

Solution:  At the time of compare graph topology create a graph and populate
           key values in the dictionary, after finished graph comparison we
           do destroy the new graph.At the time of construct graph we don't take
           any reference and for server xlators we do take reference in
           server_setvolume so in glusterd we do take reference after prepare
           a new graph while we do create a graph to compare graph topology.

BUG: 1520245
Change-Id: I573133d57771b7dc431a04422c5001a06b7dda9a
Signed-off-by: Mohit Agrawal