glusterfs.git/xlators/mgmt/glusterd/src/glusterd-op-sm.c, branch v3.3.2qa1

calls to dict_allocate_and_serialize() are not 64-bit clean

2012-08-03T10:54:50+00:00

All calls to dict_allocate_and_serialize() pass the address of a 32-bit
type, but must cast it to the 64-bit pointer type (size_t *).

This happens to work on LE machines, but even if it's apparently benign,
it's still a bug. On BE machines it is not benign.

GF_PROTOCOL_DICT_SERIALIZE() hacks around it by creating a size_t temp
var, but that's, well, a hack, IMO when you consider that all the callers
are actually passing &; the param should just be a u_int * and
eliminate the buggy casts and the temp var in the macro.

Nobody apparently uses the Fedora/EPEL PPC RPMs, but they might. People
are trying to build gluster.org bits on SPARC and tripping over this.

Change-Id: I92ea139f9e3e91ddbbb32a51b96fa582a9515626
Signed-off-by: Kaleb S. KEITHLEY 
BUG: 838928
Reviewed-on: http://review.gluster.com/3643
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Run post hooks on a different thread

2012-05-29T10:20:37+00:00

This change ensures post hooks can 'wait' if need be
and _not_ prevent glusterd from being able to run other operations
meanwhile.

Also ensures that post hook scripts are 'serialized'
between transactions. ie, post hook scripts of txn1 are completed
before post hook scripts of txn2 are started, where txn1 happens before
txn2.

Change-Id: Iaeb676737d8c67e7151127c8d1fd8c2891e10aee
BUG: 806996
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3476
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Added glusterd command specific optional args for hooks scripts.

2012-05-04T04:26:07+00:00

start volume: --first=yes if the volume is the first to be started
              and --first=no otherwise

stop volume: --last=yes if the volume is the last to be stopped
              and --last=no otherwise

set volume: -o key=value ... for every key, value supplied in
            volume set command

Change-Id: Ia8530771f8b9d7424fd1c736cb4c3622b5cabec2
BUG: 806996
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3260
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

rebalance: handshake_event_notify to make fsd talk to glusterd

2012-04-25T11:05:35+00:00

Event_notify can be used by others to communicate with glusterd.
A cbk event is also added for future use.

req has a op, and dict.
rsp has op_ret, op_errno, and dict.

With this, rebalance process can update the status before
exiting.

Signed-off-by: shishir gowda 
Change-Id: If5c0ec00514eb3a109a790b2ea273317611e4562
BUG: 807126
Reviewed-on: http://review.gluster.com/3013
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

glusterd: glusterd_op_build_payload() fix for geo-rep

2012-04-25T07:29:20+00:00

Change-Id: I9f625022fa6d70ccda70d197e4124fa73be8e776
BUG: 815603
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3215
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur

glusterd: Moved 'hooks' interface code to glusterd-hooks.*

2012-04-19T07:36:26+00:00

Change-Id: Ia7c0e37154414bddb05516e11b3cc4e6ae83ff38
BUG: 806996
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3142
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd : Fixes for breakages caused by volume-id validation

2012-04-17T13:26:15+00:00

Fixes glusterd_op_build_payload() to,
1. take account of status cmd type when building payload for "volume status" to
   prevent "volume status all" from failing.
2. take account of volname being "help/help-xml" in volume set to prevent
   "volume set help/help-xml" from failing
3. obtain volname using key "master" prevent "volume geo-replication" commands
   from failing

Also, fails op and sets correct op_errstr if volume not found during
glusterd_dict_set_volid(), to make sure cli displays proper message.

Change-Id: I40ded15c50b54a82ee61bf6d6e9d07f571679c8c
BUG: 812801
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3157
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

dht/rebalance: Display migration failure count

2012-04-13T07:52:09+00:00

Change-Id: Ib2f8be2c98eae1b4df5d2090c1f1eec8ab264a35
BUG: 811923
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3135
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

glusterd: Added volume-id to 'op' dictionary

2012-04-13T06:07:08+00:00

Volume-id passed in op dictionary would help detect possible split brains
among peers in a cluster. The idea is to check if the volume's id and
the vol-id that was passed are equal.
ie, same volume name, but different volume id indicate that glusterd
'metadata' of one of the participating peers is stale or there is
a split brain.

This is over and above the existing checksum based validation of peer
supplied cluster 'metadata' (ie, volume info file).

Change-Id: I1049ef249e417e540ccb4243e450f92fcd0f46f9
BUG: 797734
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3083
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

mgmt/glusterd: Use the correct status string for filtering

2012-04-05T12:16:20+00:00

Change-Id: Id62bec56aeda0cede19369708242f0b92f800125
BUG: 807556
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3075
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur