glusterfs.git/xlators/mgmt/glusterd/src/glusterd-op-sm.c, branch v3.7.16

glusterd: copy real_path from older brickinfo during brick import

2016-05-20T09:33:20+00:00

Backport of http://review.gluster.org/14306

In glusterd_import_new_brick () new_brickinfo->real_path will not be populated
for the first time and hence if the underlying file system is bad for the same
brick, import will fail resulting in inconsistent configuration data.

Fix is to populate real_path from old brickinfo object.

Also there were many cases where we were unnecessarily calling realpath() and
that may cause in failure. For eg - if a remove brick is executed with a brick
whoose underlying file system has crashed, remove-brick fails since realpath()
call fails. We'd need to call realpath() here as the value is of no use.Hence
passing construct_realpath as _gf_false in glusterd_volume_brickinfo_get_by_brick ()
is a must in such cases.

Change-Id: I7ec93871dc9e616f5d565ad5e540b2f1cacaf9dc
BUG: 1337113
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14306
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/14410

glusterd-ganesha : copy ganesha export configuration files during reboot

2016-05-06T12:59:44+00:00

glusterd creates export conf file for ganesha using hook script during
volume start and ganesha_manage_export() for volume set command. But this
routine is not added in glusterd restart scenario.
Consider the following case, in a three node cluster a volume got exported
via ganesha while one of the node is offline(glusterd is not running).
When the node comes back online, that volume is not exported on that node
due to the above mentioned issue.
Also I have removed unused variables from glusterd_handle_ganesha_op()
For this patch to work pcs cluster should running on that be node.

Upstream reference
>Change-Id: I5b2312c2f3cef962b1f795b9f16c8f0a27f08ee5
>BUG: 1330097
>Signed-off-by: Jiffin Tony Thottan i
>Reviewed-on: http://review.gluster.org/14063
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: soumya k 
>Reviewed-by: Atin Mukherjee 

Change-Id: I5b2312c2f3cef962b1f795b9f16c8f0a27f08ee5
BUG: 1333661
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14233
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
CentOS-regression: Gluster Build System

glusterd: fix validation of lower op-version check in volume set

2016-04-27T05:04:06+00:00

Commit 2d87a98 introduced a validation to fail lowering down the
cluster.op-version. Commit 2eb8758 actually changed the variable value from
cluster's op-version to volume's op-version which resulted the logic go for a
toss.

Change-Id: I70df32b75c3a3fe47dc840c4a655059e5b124bca
BUG: 1330545
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/14069
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/14077

glusterd: populate brickinfo->real_path conditionally

2016-04-18T13:57:04+00:00

Backport of http://review.gluster.org/13965

glusterd_brickinfo_new_from_brick () is called from multiple places and one of
them is glusterd_brick_rpc_notify where its very well possible that an
underlying brick's file system has crashed and a disconnect event has been
received. In this case glusterd tries to build the brickinfo from the brickid in
the RPC request, however the same fails as glusterd_brickinfo_new_from_brick ()
fails from realpath.

Fix is to skip populating real_path if its a disconnect event.

Change-Id: I9d9149c64a9cf2247abb731f219c1b1eef037960
BUG: 1326174
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13965
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/13973

glusterd: Fix connected clients check during 'volume set'

2016-03-23T10:15:07+00:00

  Backport of 2eb8758 from master

Use the volume's newly calulatedclient-op-version for the connected
clients check. This prevents rejection of server options of higher
op-version when clients of lower op-version are connected. Also,
initialize the variables of the newly calculated volume op-version and
client-op-version with the current values, instead of the cluster
op-version.

Change-Id: Ieb36f97c677a5457feba54bef20e154c0456e70e
BUG: 1320377
Signed-off-by: Kaushal M 
Reviewed-originally-on: http://review.gluster.org/5786
Reviewed-on: http://review.gluster.org/13814
Tested-by: Atin Mukherjee 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: disabling enable-shared-storage option should not delete volume

2016-03-21T17:55:48+00:00

This patch is a backport of: http://review.gluster.org/#/c/12232/

Previously, when you create volume with "glusterd_shared_storage" name
and if user disable, enable-shared-storage option then gluster will
delete the "glusterd_shared_storage" volume.

With this fix gluster will do appropriate validation of
enable-shared-storage option and it will not delete volume with
"glusterd_shared_storage" name if it is a user created volume.

Signed-off-by: Gaurav Kumar Garg 

  >> Change-Id: I2bd92f938fb3de6ef496a934933bdcea9f251491
  >> BUG: 1266818
  >> Signed-off-by: Gaurav Kumar Garg 
  >> Reviewed-on: http://review.gluster.org/12232
  >> Reviewed-by: Atin Mukherjee 
  >> Reviewed-by: Anand Nekkunti 
  >> Tested-by: NetBSD Build System 
  >> Tested-by: Gluster Build System 

Change-Id: I8cb160fece702a730e25dadbc740e74efc57483e
BUG: 1317425
Reviewed-on: http://review.gluster.org/13695
Tested-by: Gaurav Kumar Garg 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee

glusterd: avoid setting op-version lower than current cluster op-version

2016-03-09T02:18:12+00:00

This patch is backport of: http://review.gluster.org/#/c/13622/

Currently glusterd allow setting a cluster op-version which is lower than
current cluster op-version. Though command is successful but it does not
set that lower op-version.

With this fix it will return error message "Required op-version
(requested op-version) should not be lower than current cluster
op-version (current cluster op-version)"

Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
BUG: 1315562
Signed-off-by: Gaurav Kumar Garg 

  >> Change-Id: Ia5b61858ee22a5a26721ec12ab12ff48e1a40c82
  >> BUG: 1315186
  >> Signed-off-by: Gaurav Kumar Garg 
  >> Reviewed-on: http://review.gluster.org/13622
  >> Smoke: Gluster Build System 
  >> CentOS-regression: Gluster Build System 
  >> NetBSD-regression: NetBSD Build System 
  >> Reviewed-by: Atin Mukherjee 
(cherry picked from commit 2d87a981657ee23d00c20813deddeb320e0afa8f)

Change-Id: Ie75b2a0c43ab2c5a908f4d3800e1df62770d315b
Reviewed-on: http://review.gluster.org/13635
Tested-by: Gaurav Kumar Garg 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: add pending_node only if hxlator_count is valid

2015-12-10T06:44:04+00:00

Backport of http://review.gluster.org/#/c/12843/
Fixes a regression introduced by commit
0ef62933649392051e73fe01c028e41baddec489 . See BZ for bug
description.

Problem:
    To perform GLUSTERD_BRICK_XLATOR_OP, the rpc requires number of xlators (n) the
    op needs to be performed on and the xlator names are populated in dictionary
    with xl-0, xl-1...  xl-n-1 as keys. When Volume heal full is executed, for each
    replica group, glustershd on the local node may or may not be selected to
    perform heal by glusterd.  XLATOR_OP rpc should be sent to the shd running on
    the same node by glusterd only when glustershd on that node is selected at
    least once. This bug occurs when glusterd sends the rpc to local glustershd
    even when it is not selected for any of the replica groups.
    
Fix:
    Don't send the rpc to local glustershd when it is not selected even once.

Change-Id: I2c8217a8f00f6ad5d0c6a67fa56e476457803e08
BUG: 1284863
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/12905
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

afr/glusterd: Fix naming issue in tier related changes

2015-12-02T08:49:21+00:00

changing some of the function names added recently as
part of the tiering changes.

Back port of>
>Change-Id: I238831128ee00cdf83f8a80be937d3528d133099
>BUG: 1275489
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/12431
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: Gluster Build System 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: Id2125e20690e697948a7e48529d853626e345879
BUG: 1285978
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12774
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: Change volume start into v3 framework

2015-11-26T04:44:25+00:00

As part of volume start, if the volume is of tier type
then we need to start tiering daemon also. But before
starting tier daemon all the bricks should be started.

So by changing volume start into v3 framework, we can
do tier start in post validate phase

Backport of>
>Change-Id: If921067f4739e6b9a3239fc5717696eaf382c22a
>BUG: 1284372
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/12718
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Avra Sengupta 
>Reviewed-by: Atin Mukherjee 

(cherry picked from commit 03f731a8b32db7bef7c5e9ffc11c16f670ffe960)

Change-Id: Id6fd5555d16d605eb344efd9b9e261644469ecef
BUG: 1285335
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12749
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee